<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote gmail_quote_container"><div dir="ltr" class="gmail_attr">On Tue, Sep 23, 2025 at 6:38 AM Paul Szczepanek <<a href="mailto:paul.szczepanek@arm.com">paul.szczepanek@arm.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Split TestSuite methods between test run methods<br>
and packet related methods.<br>
<br>
Depends-on: series-36111 ("Split DTS framework and public API")<br>
<br>
Signed-off-by: Paul Szczepanek <<a href="mailto:paul.szczepanek@arm.com" target="_blank">paul.szczepanek@arm.com</a>><br>
Reviewed-by: Luca Vizzarro <<a href="mailto:luca.vizzarro@arm.com" target="_blank">luca.vizzarro@arm.com</a>><br>
---<br>
doc/api/dts/api.packet.rst | 8 +<br>
doc/api/dts/api.rst | 4 +-<br>
doc/api/dts/api.test.rst | 8 +<br>
doc/guides/tools/dts.rst | 2 +-<br>
dts/api/packet.py | 311 ++++++++++++++++++++++++++++++++++++<br>
dts/api/test.py | 126 +++++++++++++++<br>
dts/framework/test_suite.py | 305 +----------------------------------<br>
7 files changed, 460 insertions(+), 304 deletions(-)<br>
create mode 100644 doc/api/dts/api.packet.rst<br>
create mode 100644 doc/api/dts/api.test.rst<br>
create mode 100644 dts/api/packet.py<br>
create mode 100644 dts/api/test.py<br><br>
diff --git a/dts/api/packet.py b/dts/api/packet.py<br>
new file mode 100644<br>
index 0000000000..bf6f3e1be8<br>
--- /dev/null<br>
+++ b/dts/api/packet.py<br>
@@ -0,0 +1,311 @@<br>
+# SPDX-License-Identifier: BSD-3-Clause<br>
+# Copyright(c) 2025 Arm Limited<br>
+<br>
+"""Features common to all test suites.<br>
+<br>
+The module defines the :class:`TestSuite` class which doesn't contain any test cases, and as such<br>
+must be extended by subclasses which add test cases. The :class:`TestSuite` contains the basics<br>
+needed by subclasses:<br>
+<br>
+ * Testbed (SUT, TG) configuration,<br>
+ * Packet sending and verification,<br>
+ * Test case verification.<br>
+"""<br></blockquote><div><br></div><div>It looks like this docstring is taken directly from the old test_suite.py and needs to be updated.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
+<br><br></blockquote><div><br></div><div>Looks good overall, I think we can merge when the docstring update is sent.</div><div><br></div><div>Reviewed-by: Patrick Robb <<a href="mailto:probb@iol.unh.edu">probb@iol.unh.edu</a>> </div></div></div>