<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=Windows-1252">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<div>
<div style="font-family: Calibri; text-align: left; color: rgb(0, 0, 255); margin-left: 5pt; font-size: 10pt;">
[AMD Official Use Only - AMD Internal Distribution Only]</div>
<br>
</div>
<div style="font-family: Verdana, Geneva, sans-serif; font-size: 9pt; color: rgb(0, 0, 0);" class="elementToProof">
Hi Bruce, </div>
<div class="elementToProof"><br>
</div>
<hr style="display: inline-block; width: 98%;">
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<b>From:</b> Bruce Richardson <bruce.richardson@intel.com><br>
<b>Sent:</b> Friday, October 17, 2025 10:10 PM<br>
<b>To:</b> Tummala, Sivaprasad <Sivaprasad.Tummala@amd.com><br>
<b>Cc:</b> david.hunt@intel.com <david.hunt@intel.com>; honnappa.nagarahalli@arm.com <honnappa.nagarahalli@arm.com>; anatoly.burakov@intel.com <anatoly.burakov@intel.com>; jerinj@marvell.com <jerinj@marvell.com>; radu.nicolau@intel.com <radu.nicolau@intel.com>;
gakhil@marvell.com <gakhil@marvell.com>; cristian.dumitrescu@intel.com <cristian.dumitrescu@intel.com>; Yigit, Ferruh <Ferruh.Yigit@amd.com>; konstantin.ananyev@huawei.com <konstantin.ananyev@huawei.com>; dev@dpdk.org <dev@dpdk.org><br>
<b>Subject:</b> Re: [PATCH] test/ring_perf: add optional cross L3 core selection </div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);" class="elementToProof">
<br>
</div>
<div style="font-size: 11pt;" class="elementToProof">Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.<br>
<br>
<br>
On Fri, Oct 17, 2025 at 04:34:04PM +0000, Sivaprasad Tummala wrote:<br>
>> Enhances test_ring_perf to optionally select two cores on<br>
>> the same socket but on different L3 caches using hwloc.<br>
>><br>
>> This allows performance characterization of ring library<br>
>> on processors with split L3 cache architectures, providing<br>
>> more realistic measurements of inter-core communication<br>
>> and cache effects.<br>
>><br>
>> The feature is conditional on hwloc being present, ensuring<br>
>> builds succeed on systems without hwloc.<br>
>><br>
>> Signed-off-by: Sivaprasad Tummala <sivaprasad.tummala@amd.com><br>
>> ---<br>
>> app/test/test_ring_perf.c | 75 +++++++++++++++++++++++++++++++++++++++<br>
>> config/meson.build | 8 +++++<br>
>> 2 files changed, 83 insertions(+)<br>
>><br>
>> diff --git a/app/test/test_ring_perf.c b/app/test/test_ring_perf.c<br>
<br>
<snip><br>
<br>
>> diff --git a/config/meson.build b/config/meson.build<br>
>> index b8c1f127a2..75630254f2 100644<br>
>> --- a/config/meson.build<br>
>> +++ b/config/meson.build<br>
>> @@ -313,6 +313,14 @@ else<br>
>> add_project_arguments('-include', 'rte_config.h', language: 'c')<br>
>> endif<br>
>><br>
>> +hwloc_dep = dependency('hwloc', required : false)<br>
>> +if hwloc_dep.found()<br>
>> + add_project_arguments('-DHAVE_HWLOC=1', language : 'c')<br>
>> + add_project_link_arguments('-lhwloc', language: 'c')<br>
>> + dpdk_extra_ldflags += '-lhwloc'<br>
>> + message('hwloc found — enabling L3 cache–aware topology support')<br>
>> +endif<br>
>> +<br>
><br>
> Hi,<br>
> <br>
> I think this is the wrong place to put this. This will make the whole DPDK<br>
> build depend on hwloc and add it to the pkg-config file.<br>
> <br>
> Instead, it's only the unit test binary that actually has the dependency,<br>
> based on this patch, so just add the dep there, and add it to the cflags<br>
> for that component only.<br>
><br>
>/Bruce<br>
</div>
<div style="font-size: 11pt; color: rgb(0, 0, 0);" class="elementToProof">ACK, <span style="font-family: Verdana, Geneva, sans-serif;">
I’ll restrict the hwloc dependency and related flag to the test application only in v2.</span></div>
</body>
</html>