<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=Windows-1252">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<div>
<div style="font-family: Calibri; text-align: left; color: rgb(0, 0, 255); margin-left: 5pt; font-size: 10pt;">
[AMD Official Use Only - AMD Internal Distribution Only]</div>
<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);" class="elementToProof">
Hi Bruce, </div>
<hr style="display: inline-block; width: 98%;">
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<b>From:</b> Bruce Richardson <bruce.richardson@intel.com><br>
<b>Sent:</b> Monday, October 20, 2025 2:27 PM<br>
<b>To:</b> Tummala, Sivaprasad <Sivaprasad.Tummala@amd.com><br>
<b>Cc:</b> honnappa.nagarahalli@arm.com <honnappa.nagarahalli@arm.com>; anatoly.burakov@intel.com <anatoly.burakov@intel.com>; jerinj@marvell.com <jerinj@marvell.com>; radu.nicolau@intel.com <radu.nicolau@intel.com>; gakhil@marvell.com <gakhil@marvell.com>;
cristian.dumitrescu@intel.com <cristian.dumitrescu@intel.com>; Yigit, Ferruh <Ferruh.Yigit@amd.com>; konstantin.ananyev@huawei.com <konstantin.ananyev@huawei.com>; dev@dpdk.org <dev@dpdk.org><br>
<b>Subject:</b> Re: [PATCH v2] test/ring_perf: add optional cross L3 core selection
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="font-size: 11pt;" class="elementToProof">Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.<br>
<br>
<br>
On Sat, Oct 18, 2025 at 06:48:27AM +0000, Sivaprasad Tummala wrote:<br>
>> Enhances test_ring_perf to optionally select two cores on<br>
>> the same socket but on different L3 caches using hwloc.<br>
>><br>
>> This allows performance characterization of ring library<br>
>> on processors with split L3 cache architectures, providing<br>
>> more realistic measurements of inter-core communication<br>
>> and cache effects.</div>
<div style="font-size: 11pt; color: rgb(0, 0, 0);" class="elementToProof">>><span style="font-family: Verdana, Geneva, sans-serif;"> </span></div>
<div style="font-size: 11pt;" class="elementToProof"><span style="color: rgb(0, 0, 0);">>></span><span style="font-family: Verdana, Geneva, sans-serif; color: rgb(0, 0, 0);"> </span>The feature is conditional on hwloc being present, ensuring</div>
<div style="font-size: 11pt;" class="elementToProof"><span style="color: rgb(0, 0, 0);">>></span><span style="font-family: Verdana, Geneva, sans-serif; color: rgb(0, 0, 0);"> </span>builds succeed on systems without hwloc.</div>
<div style="font-size: 11pt;" class="elementToProof">>><br>
>> Signed-off-by: Sivaprasad Tummala <sivaprasad.tummala@amd.com><br>
>><br>
>> v2:<br>
>> * Localized hwloc dependency to test app only.<br>
>> * Optimized get_two_l3caches() by moving socket and L3 cache ID<br>
>> retrieval to the outer loop.<br>
>> ---<br>
>> app/meson.build | 8 ++++-<br>
>> app/test/test_ring_perf.c | 76 +++++++++++++++++++++++++++++++++++++++<br>
>> 2 files changed, 83 insertions(+), 1 deletion(-)<br>
>><br>
>> diff --git a/app/meson.build b/app/meson.build<br>
>> index 1798db3ae4..5443043f0c 100644<br>
>> --- a/app/meson.build<br>
>> +++ b/app/meson.build<br>
>> @@ -46,6 +46,12 @@ if get_option('default_library') == 'static' and not is_windows<br>
>> default_ldflags += ['-Wl,--export-dynamic']<br>
>> endif<br>
>><br>
>> +hwloc_dep = dependency('hwloc', required : false)<br>
>> +if hwloc_dep.found()<br>
>> + default_cflags += ['-DHAVE_HWLOC=1']<br>
>> + message('hwloc found — enabling L3 cache–aware topology support')<br>
>> +endif<br>
>> +<br>
>> foreach app:apps<br>
>> name = app<br>
>> build = true<br>
>> @@ -60,7 +66,7 @@ foreach app:apps<br>
>><br>
>> # use "deps" for internal DPDK dependencies, and "ext_deps" for<br>
>> # external package/library requirements<br>
>> - ext_deps = []<br>
>> + ext_deps = [hwloc_dep]<br>
>> deps = []<br>
>><br>
>> if not enable_apps.contains(app)<br>
><br>
>I still think we can limit this more. No need, for example, for test-pmd or<br>
>test-cmdline, for that matter, to depend on hwloc. Therefore, I'd suggest<br>
>moving the dependency code to app/test/meson.build and adding it there.<br>
><br>
>/Bruce</div>
<div style="font-size: 11pt;" class="elementToProof"><br>
</div>
<div style="font-size: 11pt;" class="elementToProof">ACK! Will fix this in v3 <br>
<br>
</div>
</body>
</html>