<div dir="ltr">Hi Sameer,<div><br></div><div>Thanks for the heads up. It looks like the Github Robot has a failure but I think it is a spurious false fail, so I just sent a recheck request for that. I expect that failure will be overwritten with a PASS soon.</div><div><br></div><div>There are also 2 warnings on your patch, which I can address, but they will not preclude your patch from being merged (as they are only a WARN, not a FAIL).</div><div><br></div><div>Thanks.</div></div><br><div class="gmail_quote gmail_quote_container"><div dir="ltr" class="gmail_attr">On Fri, Oct 31, 2025 at 1:10 PM Sameer Vaze <<a href="mailto:svaze@qti.qualcomm.com">svaze@qti.qualcomm.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div class="msg528728163559859775"> <div dir="ltr"> <div style="font-family:Aptos,Aptos_EmbeddedFont,Aptos_MSFontService,Calibri,Helvetica,sans-serif;font-size:11pt;color:rgb(0,0,0)"> <br> </div> <div id="m_528728163559859775Signature"> <div style="font-family:Aptos,Aptos_EmbeddedFont,Aptos_MSFontService,Calibri,Helvetica,sans-serif;font-size:11pt;color:rgb(0,0,0)"> Hey Patrick</div> <div style="font-family:Aptos,Aptos_EmbeddedFont,Aptos_MSFontService,Calibri,Helvetica,sans-serif;font-size:11pt;color:rgb(0,0,0)"> <br> </div> <div style="font-family:Aptos,Aptos_EmbeddedFont,Aptos_MSFontService,Calibri,Helvetica,sans-serif;font-size:11pt;color:rgb(0,0,0)"> I followed <a id="m_528728163559859775OWA1ca9f512-d97b-9bdf-6aac-161c55ee1852" href="https://core.dpdk.org/testing/#requesting-a-patch-retest" target="_blank"> https://core.dpdk.org/testing/#requesting-a-patch-retest</a> to request a rebase and recheck since the failures don't seem related to my changes. It doesn't look like the retests were picked up. Did I miss something?</div> <div style="font-family:Calibri,Arial,Helvetica,sans-serif;font-size:11pt;color:rgb(0,0,0)"> <br> </div> <div style="font-family:Calibri,Arial,Helvetica,sans-serif;font-size:11pt;color:rgb(0,0,0)"> Thanks<br> Sameer Vaze</div> </div> <div id="m_528728163559859775appendonsend"></div> <hr style="display:inline-block;width:98%"> <div id="m_528728163559859775divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Sameer Vaze <<a href="mailto:svaze@qti.qualcomm.com" target="_blank">svaze@qti.qualcomm.com</a>><br> <b>Sent:</b> Tuesday, October 28, 2025 11:19 AM<br> <b>To:</b> Sunila Sahu <<a href="mailto:ssahu@marvell.com" target="_blank">ssahu@marvell.com</a>>; Fan Zhang <<a href="mailto:fanzhang.oss@gmail.com" target="_blank">fanzhang.oss@gmail.com</a>>; Ashish Gupta <<a href="mailto:ashishg@marvell.com" target="_blank">ashishg@marvell.com</a>><br> <b>Cc:</b> <a href="mailto:dev@dpdk.org" target="_blank">dev@dpdk.org</a> <<a href="mailto:dev@dpdk.org" target="_blank">dev@dpdk.org</a>><br> <b>Subject:</b> Re: [PATCH] compressdev: fix coverity issue</font> <div> </div> </div> <div dir="ltr"> <p style="text-align:center"><span style="background-color:rgb(255,255,0);font-size:14px;font-family:sans-serif;color:rgb(0,0,0)"><strong>WARNING:</strong> This email originated from outside of Qualcomm. Please be wary of any links or attachments, and do not enable macros.</span></p> <div> <div style="font-family:Aptos,Aptos_EmbeddedFont,Aptos_MSFontService,Calibri,Helvetica,sans-serif;font-size:11pt;color:rgb(0,0,0)"> Recheck-request: rebase=main, iol-sample-apps-testing, iol-compile-amd64-testing</div> <div id="m_528728163559859775x_appendonsend"></div> <hr style="display:inline-block;width:98%"> <div id="m_528728163559859775x_divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>From:</b> Sameer Vaze <<a href="mailto:svaze@qti.qualcomm.com" target="_blank">svaze@qti.qualcomm.com</a>><br> <b>Sent:</b> Friday, October 24, 2025 12:47 PM<br> <b>To:</b> Sunila Sahu <<a href="mailto:ssahu@marvell.com" target="_blank">ssahu@marvell.com</a>>; Fan Zhang <<a href="mailto:fanzhang.oss@gmail.com" target="_blank">fanzhang.oss@gmail.com</a>>; Ashish Gupta <<a href="mailto:ashishg@marvell.com" target="_blank">ashishg@marvell.com</a>><br> <b>Cc:</b> <a href="mailto:dev@dpdk.org" target="_blank">dev@dpdk.org</a> <<a href="mailto:dev@dpdk.org" target="_blank">dev@dpdk.org</a>>; Sameer Vaze <<a href="mailto:svaze@qti.qualcomm.com" target="_blank">svaze@qti.qualcomm.com</a>><br> <b>Subject:</b> [PATCH] compressdev: fix coverity issue</font> <div> </div> </div> <div><font size="2"><span style="font-size:11pt"> <div>Adds missing free before end of function<br> <br> Signed-off-by: Sameer Vaze <<a href="mailto:svaze@qti.qualcomm.com" target="_blank">svaze@qti.qualcomm.com</a>><br> ---<br> drivers/compress/zlib/zlib_pmd.c | 1 +<br> 1 file changed, 1 insertion(+)<br> <br> diff --git a/drivers/compress/zlib/zlib_pmd.c b/drivers/compress/zlib/zlib_pmd.c<br> index 3a2485b54e..1d7651dd7d 100644<br> --- a/drivers/compress/zlib/zlib_pmd.c<br> +++ b/drivers/compress/zlib/zlib_pmd.c<br> @@ -126,6 +126,7 @@ process_zlib_inflate_chksum(struct rte_comp_op *op,<br> free(dictionary);<br> return;<br> }<br> + free(dictionary);<br> }<br> <br> static void<br> -- <br> 2.31.1<br> <br> </div> </span></font></div> </div> </div> </div> </div></blockquote></div>