<html xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"> <head> <meta http-equiv="Content-Type" content="text/html; charset=utf-8"> <meta name="Generator" content="Microsoft Word 15 (filtered medium)"> <style></style> </head> <body lang="EN-US" link="#467886" vlink="#96607D" style="word-wrap:break-word"> <div class="WordSection1"> Hi,<o:p></o:p> <o:p> </o:p> <a href="https://dpdk.readthedocs.io/en/v16.04/contributing/patches.html#:~:text=The%20mailing%20list%20for%20DPDK%20development%20is%20dev%40dpkg.org.,is%20also%20worth%20registering%20for%20the%20DPDK%20Patchwork">5. Contributing Code to DPDK — Data Plane Development Kit 16.04.0 documentation</a><o:p></o:p> <o:p> </o:p> Please refer to this link. And about the description, I think it would be good to describe that the real issue is missing to set the proper value in the error branch.<o:p></o:p> <o:p> </o:p> <div> <div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in"> From: Yang Xu <xu.yang3@zte.com.cn> Sent: Monday, November 17, 2025 5:12 PM To: NBU-Contact-Thomas Monjalon (EXTERNAL) <thomas@monjalon.net>; Dariusz Sosnowski <dsosnowski@nvidia.com>; Slava Ovsiienko <viacheslavo@nvidia.com>; Bing Zhao <bingz@nvidia.com>; Ori Kam <orika@nvidia.com>; Suanming Mou <suanmingm@nvidia.com>; Matan Azrad <matan@nvidia.com>; xu.yang3@zte.com.cn; yao.chenghu@zte.com.cn Cc: dev@dpdk.org Subject: [PATCH v2 1/1] net/mlx5: fix set port down if detect anomaly<o:p></o:p> </div> </div> <o:p> </o:p> <table class="MsoNormalTable" border="1" cellpadding="0" style="background:#FFEB9C"> <tbody> <tr> <td style="padding:.75pt .75pt .75pt .75pt"> External email: Use caution opening links or attachments <o:p></o:p> </td> </tr> </tbody> </table> <o:p> </o:p> MLX network interface card link detection will set the interface to a down state upon detecting an anomaly. Fixes: 1256805 ("move linux-specific functions") Signed-off-by: Yang Xu <<a href="mailto:xu.yang3@zte.com.cn">xu.yang3@zte.com.cn</a>> --- .mailmap | 1 + drivers/net/mlx5/linux/mlx5_ethdev_os.c | 1 + test.eml | 21 +++++++++++++++++++++ 3 files changed, 23 insertions(+) create mode 100644 test.eml diff --git a/.mailmap b/.mailmap index 34a99f93a1..14d6ee93dd 100644 --- a/.mailmap +++ b/.mailmap @@ -1891,3 +1891,4 @@ Zoltan Kiss <<a href="mailto:zoltan.kiss@schaman.hu">zoltan.kiss@schaman.hu</a>> <<a href="mailto:zoltan.kiss@linaro.org">zoltan.kiss@linaro.org</a>> Zorik Machulsky <<a href="mailto:zorik@amazon.com">zorik@amazon.com</a>> Zyta Szpak <<a href="mailto:zyta@marvell.com">zyta@marvell.com</a>> <<a href="mailto:zr@semihalf.com">zr@semihalf.com</a>> Zyta Szpak <<a href="mailto:zyta@marvell.com">zyta@marvell.com</a>> <<a href="mailto:zyta.szpak@semihalf.com">zyta.szpak@semihalf.com</a>> +Yang Xu <<a href="mailto:xu.yang3@zte.com.cn">xu.yang3@zte.com.cn</a>> diff --git a/drivers/net/mlx5/linux/mlx5_ethdev_os.c b/drivers/net/mlx5/linux/mlx5_ethdev_os.c index 9daeda5435..03531ae879 100644 --- a/drivers/net/mlx5/linux/mlx5_ethdev_os.c +++ b/drivers/net/mlx5/linux/mlx5_ethdev_os.c @@ -504,6 +504,7 @@ mlx5_link_update(struct rte_eth_dev *dev, int wait_to_complete) return -rte_errno; } } else if (ret < 0) { + dev->data->dev_link = {0}; return ret; } } while (wait_to_complete || retry-- > 0); diff --git a/test.eml b/test.eml new file mode 100644 index 0000000000..f30ef5dc8a --- /dev/null +++ b/test.eml @@ -0,0 +1,21 @@ +./../dpdk-patch/0001-net-mlx5-fix-set-port-down-if-detect-anomaly.patch +(mbox) Adding cc: Yang Xu <<a href="mailto:xu.yang3@zte.com.cn">xu.yang3@zte.com.cn</a>> from line 'From: Yang Xu <<a href="mailto:xu.yang3@zte.com.cn">xu.yang3@zte.com.cn</a>>' +(body) Adding cc: Yang Xu <<a href="mailto:xu.yang3@zte.com.cn">xu.yang3@zte.com.cn</a>> from line 'Signed-off-by: Yang Xu <<a href="mailto:xu.yang3@zte.com.cn">xu.yang3@zte.com.cn</a>>' +Dry-OK. Log says: +Server: 10.5.231.43 +MAIL FROM:<<a href="mailto:xu.yang3@zte.com.cn">xu.yang3@zte.com.cn</a>> +RCPT TO:<y> +RCPT TO:<<a href="mailto:xu.yang3@zte.com.cn">xu.yang3@zte.com.cn</a>> +From: Yang Xu <<a href="mailto:xu.yang3@zte.com.cn">xu.yang3@zte.com.cn</a>> +To: y +Cc: Yang Xu <<a href="mailto:xu.yang3@zte.com.cn">xu.yang3@zte.com.cn</a>> +Subject: [PATCH v2 1/1] net/mlx5: fix set port down if detect anomaly +Date: Fri, 14 Nov 2025 10:14:11 +0800 +Message-Id: <<a href="mailto:20251114021411.3606817-1-xu.yang3@zte.com.cn">20251114021411.3606817-1-xu.yang3@zte.com.cn</a>> +X-Mailer: git-send-email 2.27.0 +In-Reply-To: <y> +References: <y> +MIME-Version: 1.0 +Content-Transfer-Encoding: 8bit + +Result: OK -- 2.27.0<o:p></o:p> </div> </body> </html>