<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=utf-8"> <style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style> </head> <body dir="ltr"> <div> <div style="font-family: Calibri; text-align: left; color: rgb(0, 0, 255); margin-left: 5pt; font-size: 10pt;"> [AMD Official Use Only - AMD Internal Distribution Only]</div> <br> </div> <div style="font-family: Verdana, Geneva, sans-serif; font-size: 9pt; color: rgb(0, 0, 0);" class="elementToProof"> Hi Thomas, </div> <div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> <br> </div> <hr style="display: inline-block; width: 98%;"> <div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> <b>From:</b> Thomas Monjalon <thomas@monjalon.net><br> <b>Sent:</b> Wednesday, November 19, 2025 6:27 PM<br> <b>To:</b> Tummala, Sivaprasad <Sivaprasad.Tummala@amd.com><br> <b>Cc:</b> Konstantin Ananyev <konstantin.ananyev@huawei.com>; Nithin Dabilpuram <nithind1988@gmail.com>; stable@dpdk.org <stable@dpdk.org>; jerinj@marvell.com <jerinj@marvell.com>; kirankumark@marvell.com <kirankumark@marvell.com>; ndabilpuram@marvell.com <ndabilpuram@marvell.com>; yanzhirun_163@163.com <yanzhirun_163@163.com>; david.marchand@redhat.com <david.marchand@redhat.com>; ktraynor@redhat.com <ktraynor@redhat.com>; konstantin.v.ananyev@yandex.ru <konstantin.v.ananyev@yandex.ru>; bruce.richardson@intel.com <bruce.richardson@intel.com>; maxime.coquelin@redhat.com <maxime.coquelin@redhat.com>; aconole@redhat.com <aconole@redhat.com>; dev@dpdk.org <dev@dpdk.org>; stable@dpdk.org <stable@dpdk.org><br> <b>Subject:</b> Re: [PATCH] examples/l3fwd-graph: remove redundant Tx queue limit </div> <div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> <br> </div> <div style="font-size: 11pt;" class="elementToProof">Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.<br> <br> <br> 19/11/2025 13:08, Tummala, Sivaprasad:<br> > From: Thomas Monjalon <thomas@monjalon.net><br> > 06/10/2025 10:58, Tummala, Sivaprasad:<br> > > From: Konstantin Ananyev <konstantin.ananyev@huawei.com><br> > > > > On Mon, Sep 1, 2025 at 11:39 PM Sivaprasad Tummala<br> > > > > <sivaprasad.tummala@amd.com> wrote:<br> > > > > ><br> > > > > > In `l3fwd-graph` application, Tx queues are configured per lcore<br> > > > > > to enable a lockless design and achieve optimal performance.<br> > > > > ><br> > > > > > The `MAX_TX_QUEUE_PER_PORT` macro, defined as `RTE_MAX_ETHPORTS`,<br> > > > > > introduced an artificial constraint on the number of Tx queues<br> > > > > > and limited core-scaling performance.<br> > > > > ><br> > > > > > This patch removes the unused `MAX_TX_QUEUE_PER_PORT` macro and<br> > > > > > redundant Tx queue check, allowing Tx queues to scale directly<br> > > > > > with the no. of lcores.<br> > > > > ><br> > > > > > Fixes: 08bd1a174461 ("examples/l3fwd-graph: add graph-based l3fwd skeleton")<br> > > > > > Cc: ndabilpuram@marvell.com<br> > > > > > Cc: stable@dpdk.org<br> > > > > ><br> > > > > > Signed-off-by: Sivaprasad Tummala <sivaprasad.tummala@amd.com><br> > > > > > ---<br> > > > > > examples/l3fwd-graph/main.c | 3 ---<br> > > > > > 1 file changed, 3 deletions(-)<br> > > > > ><br> > > > > > diff --git a/examples/l3fwd-graph/main.c b/examples/l3fwd-graph/main.c<br> > > > > > index 92cdaa1ebe..12908acbba 100644<br> > > > > > --- a/examples/l3fwd-graph/main.c<br> > > > > > +++ b/examples/l3fwd-graph/main.c<br> > > > > > @@ -49,7 +49,6 @@<br> > > > > > #define RX_DESC_DEFAULT 1024<br> > > > > > #define TX_DESC_DEFAULT 1024<br> > > > > ><br> > > > > > -#define MAX_TX_QUEUE_PER_PORT RTE_MAX_ETHPORTS<br> > > > > > #define MAX_RX_QUEUE_PER_PORT 128<br> > > ><br> > > > AFAIK, in the mainline we actually have:<br> > > > #define MAX_TX_QUEUE_PER_PORT RTE_MAX_LCORE<br> > > ><br> > > In l3fwd-graph app, this change is not available and instead we have<br> > >> #define MAX_TX_QUEUE_PER_PORT RTE_MAX_ETHPORTS<br> > >><br> > >> > since:<br> > >> > commit 88256ed85338c572d73006e4c4530a52d3b477ff<br> > >> > Author: Harman Kalra <hkalra@marvell.com><br> > >> > Date: Tue Jan 12 23:54:46 2021 +0530<br> > >> ><br> > >> > examples/l3fwd: remove limitation on Tx queue count<br> > >> ><br> > >> > What I am missing here?<br> >> >> This patch marked here was fixing l3fwd app and not l3fwd-graph<br> >><br> >> > Why not applying the same change to both examples?<br> >> Yes, that's what the patch is intended for to fix l3fwd-graph and tx queues will scale with lcores and limited by RTE_MAX_LCORES.<br> <br> >But it is not done the same way.<br> > Here you remove MAX_TX_QUEUE_PER_PORT.<br> > Do you want to do the same in l3fwd?</div> <div style="font-size: 11pt;" class="elementToProof">Yes, it's better to fix the same in l3fwd<span style="font-family: "Segoe UI", "Segoe UI Web (West European)", -apple-system, BlinkMacSystemFont, Roboto, "Helvetica Neue", sans-serif; color: rgb(66, 66, 66); background-color: rgba(0, 0, 0, 0); font-weight: 400;"> as "MAX_TX_QUEUE_PER_PORT" is redundant.</span></div> <div style="font-size: 11pt;" class="elementToProof"><span style="font-family: "Segoe UI", "Segoe UI Web (West European)", -apple-system, BlinkMacSystemFont, Roboto, "Helvetica Neue", sans-serif; color: rgb(66, 66, 66); background-color: rgba(0, 0, 0, 0); font-weight: 400;">I can submit a separate patch for l3fwd. </span></div> <div style="font-size: 11pt;" class="elementToProof"><br> </div> </body> </html>