<div dir="auto">Send a new series and I replace the one in next net</div><br><div class="gmail_quote gmail_quote_container"><div dir="ltr" class="gmail_attr">On Mon, Feb 2, 2026, 20:01 Dimon <<a href="mailto:dimon.zhao@nebula-matrix.com">dimon.zhao@nebula-matrix.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div><div style="font-family:Tahoma,Arial,STHeitiSC-Light,SimSun"><div style="clear:both;font-family:Tahoma,Arial,STHeitiSC-Light,SimSun"><span style="font-family:Tahoma,Arial,STHeitiSC-Light,SimSun"><span>Hi Thomas,<br></span></span><div style="clear:both"><br></div><div style="clear:both">Thank you for the feedback about splitting the Coverity fixes patch by issue type.</div><div style="clear:both">You're absolutely right - it addresses three distinct problems and should be separate commits.<br></div><div style="clear:both"><br></div><div style="clear:both">Now the patch is already queued to next-net, and since then five additional nbl driver fixes have been merged:<br></div><div style="clear:both">net/nbl: improve mailbox exception handling<br></div><div style="clear:both">net/nbl: fix mbuf double-free in queue cleanup<br></div><div style="clear:both">net/nbl: fix mbuf headroom usage in packet Tx<br></div><div style="clear:both">net/nbl: fix memzone leak on queue release<br></div><div style="clear:both">net/nbl: fix hardware stats interrupt nesting issue<br></div><div style="clear:both"><br></div><div><span>What should I do? Should I ask Stephen to help revert these 6 commits and then resubmit them?</span></div></div><div style="clear:both;font-family:Tahoma,Arial,STHeitiSC-Light,SimSun"><span style="font-family:Tahoma,Arial,STHeiti,SimSun"><br></span></div><div style="clear:both;font-family:Tahoma,Arial,STHeitiSC-Light,SimSun"><span style="font-family:Tahoma,Arial,STHeiti,SimSun"><br></span></div><div style="clear:both;font-family:Tahoma,Arial,STHeitiSC-Light,SimSun"><span style="font-family:Tahoma,Arial,STHeiti,SimSun"><br></span></div><div style="clear:both;font-family:Tahoma,Arial,STHeitiSC-Light,SimSun"><span style="font-family:Tahoma,Arial,STHeiti,SimSun">------------------------------------------------------------------</span></div><blockquote style="margin-right:0px;margin-top:0px;margin-bottom:0px;font-family:Tahoma,Arial,STHeiti,SimSun;font-size:14px;color:rgb(0,0,0)"><div><div style="clear:both">发件人：Thomas Monjalon <<a href="mailto:thomas@monjalon.net" target="_blank" rel="noreferrer">thomas@monjalon.net</a>></div><div style="clear:both">发送时间：2026年2月2日(周一) 04:29</div><div style="clear:both">收件人：Dimon<<a href="mailto:dimon.zhao@nebula-matrix.com" target="_blank" rel="noreferrer">dimon.zhao@nebula-matrix.com</a>></div><div style="clear:both">抄　送：dev<<a href="mailto:dev@dpdk.org" target="_blank" rel="noreferrer">dev@dpdk.org</a>>; stable<<a href="mailto:stable@dpdk.org" target="_blank" rel="noreferrer">stable@dpdk.org</a>>; Kyo Liu<<a href="mailto:kyo.liu@nebula-matrix.com" target="_blank" rel="noreferrer">kyo.liu@nebula-matrix.com</a>>; Leon<<a href="mailto:leon.yu@nebula-matrix.com" target="_blank" rel="noreferrer">leon.yu@nebula-matrix.com</a>>; Sam<<a href="mailto:sam.chen@nebula-matrix.com" target="_blank" rel="noreferrer">sam.chen@nebula-matrix.com</a>>; Stephen Hemminger<<a href="mailto:stephen@networkplumber.org" target="_blank" rel="noreferrer">stephen@networkplumber.org</a>></div><div style="clear:both">主　题：Re: [PATCH v3 1/1] net/nbl: fix issues reported by Coverity</div><div style="clear:both"><br></div>21/01/2026 05:36, Stephen Hemminger:<br>> On Wed, 14 Jan 2026 19:27:44 -0800<br>> Dimon Zhao <<a href="mailto:dimon.zhao@nebula-matrix.com" target="_blank" rel="noreferrer">dimon.zhao@nebula-matrix.com</a>> wrote:<br>> <br>> > Address multiple issues reported by Coverity static analysis:<br>> > <br>> > Check return values of ioctl() calls for NBL_DEV_USER_GET_BAR_SIZE<br>> > and NBL_DEV_USER_CLEAR_EVENTFD. The original code tested the return<br>> > value without capturing it from the ioctl call.<br>> > <br>> > Move debug log statement after NULL pointer validation in<br>> > nbl_dev_configure() to prevent dereference of adapter before the<br>> > check.<br>> > <br>> > Cast u16 operands to u64 before multiplication when calculating<br>> > buffer sizes and offsets to prevent potential integer overflow.<br>> > The num_txq_entries, num_rxq_entries, txq_buf_size, and rxq_buf_size<br>> > fields are all u16 types, and their product could overflow before<br>> > assignment to size_t or u64 destination variables.<br>> > <br>> > Coverity issue: 490942<br>> > Coverity issue: 490943<br>> > Coverity issue: 490946<br>> > Coverity issue: 490947<br>> > Coverity issue: 490949<br>> > Coverity issue: 490950<br>> > Coverity issue: 490951<br>> > Coverity issue: 490952<br>> > Coverity issue: 490953<br>> > Coverity issue: 490954<br>> > Coverity issue: 490955<br>> > Coverity issue: 490957<br>> > Coverity issue: 490958<br>> > Coverity issue: 490959<br>> > Fixes: a1c5ffa13b2c ("net/nbl: add channel layer")<br>> > Fixes: dc955cd24c8f ("net/nbl: add coexistence mode")<br>> > Fixes: 93b38df5a2ec ("net/nbl: support basic configuration")<br>> > Cc: <a href="mailto:stable@dpdk.org" target="_blank" rel="noreferrer">stable@dpdk.org</a><br>> > <br>> > Signed-off-by: Dimon Zhao <<a href="mailto:dimon.zhao@nebula-matrix.com" target="_blank" rel="noreferrer">dimon.zhao@nebula-matrix.com</a>><br>> <br>> Queued to next-net<br><br>After another look, I think it deserves to be split per type of issue.<br>Maybe 3 commits?<br></div></blockquote><div style="line-height:20px;clear:both"><br></div></div></div></blockquote></div>