<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=us-ascii"> <style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style> </head> <body dir="ltr"> <div class="elementToProof" style="margin-top: 1em; margin-bottom: 1em; font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> Thanks for the feedback.</div> <div class="elementToProof" style="margin-top: 1em; margin-bottom: 1em; font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> I will prepare a v2 for this patch. For the queue storage helpers, I will replace the macros with static inline functions, based on Stephen's suggestion.</div> <div class="elementToProof" style="margin-top: 1em; margin-bottom: 1em; font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> Thanks,<br> Weijun</div> <div style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> <br> </div> <div id="appendonsend"></div> <hr style="display:inline-block;width:98%" tabindex="-1"> <div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Thomas Monjalon <thomas@monjalon.net><br> <b>Sent:</b> Wednesday, June 10, 2026 9:15 AM<br> <b>To:</b> Weijun Pan <wpan3636@gmail.com>; Hemant Agrawal <hemant.agrawal@nxp.com>; Weijun Pan <wpan36@wisc.edu><br> <b>Cc:</b> dev@dpdk.org <dev@dpdk.org>; Sachin Saxena <sachin.saxena@nxp.com>; Jun Yang <jun.yang@nxp.com>; stable@dpdk.org <stable@dpdk.org>; Stephen Hemminger <stephen@networkplumber.org><br> <b>Subject:</b> Re: [PATCH] bus/fslmc: fix shadowed variables in queue storage macros</font> <div> </div> </div> <div class="BodyFragment"><font size="2"><span style="font-size:11pt;"> <div class="PlainText">07/04/2026 16:09, Stephen Hemminger:<br> > Why are these not inline functions.<br> > Macros with lower case names are likely place fore confusion like this?<br> <br> Hemant, Sachin, Weijun, please could you consider this comment?<br> <br> <br> </div> </span></font></div> </body> </html>