<HTML><BODY><div class="cl-ush0rmy68w">Kindly reminder<br>Sorry, But nobody has reviewed my small cosmetic patch on Patchwork <a href="https://patches.dpdk.org/project/dpdk/patch/20260417052334.2217652-1-lyulin.2003@mail.ru/">https://patches.dpdk.org/project/dpdk/patch/20260417052334.2217652-1-lyulin.2003@mail.ru/</a><br>Could you please review this?<br><br> <div class="mail-quote-collapse"><blockquote style="border-left:1px solid #0857A6;margin:10px;padding:0 0 0 10px"><div><div id=""><div class="cl-m4mlgc90x7"><div class="js-helper_mr_css_attr js-readmsg-msg_mr_css_attr"><div id="style_17764444091671824853_mr_css_attr"><div id="style_17764444091671824853_BODY_mr_css_attr"><div> <div class="gmail_quote_container_mr_css_attr gmail_quote_mr_css_attr"><div class="gmail_attr_mr_css_attr"><span>On Fri, Apr 17, 2026 at 1:23 AM Denis Lyulin <<a href="mailto:lyulin.2003@mail.ru">lyulin.2003@mail.ru</a>> wrote:</span></div><div class="mail-quote-collapse"><div><blockquote style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex" class="gmail_quote_mr_css_attr">Some static analyzers generate warnings about possible integer<br>overflow on multiplication. The first parameter of<br>`rte_eal_alarm_set()` is `uint64_t`, so this commit adds cast<br>of `uint32_t` values before the multiplication to prevent overflow.<br>The fix is cosmetic.<br><br>Fixes: 9d0cbaecc91a ("net/bnxt: support periodic FW health monitoring")<br>Cc: <a href="mailto:kalesh-anakkur.purayil@broadcom.com">kalesh-anakkur.purayil@broadcom.com</a><br>Cc: <a href="mailto:stable@dpdk.org">stable@dpdk.org</a><br><br>Signed-off-by: Denis Lyulin <<a href="mailto:lyulin.2003@mail.ru">lyulin.2003@mail.ru</a>></blockquote></div></div><div><span style="font-family:Calibri;font-size:11pt">Acked-by: Kishore Padmanabha <<a href="mailto:kishore.padmanabha@broadcom.com">kishore.padmanabha@broadcom.com</a>></span> </div><blockquote style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex" class="gmail_quote_mr_css_attr">---<br> drivers/net/bnxt/bnxt_ethdev.c | 8 ++++----<br> 1 file changed, 4 insertions(+), 4 deletions(-)<br><br>diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c<br>index b677f9491d..bdfab3eef2 100644<br>--- a/drivers/net/bnxt/bnxt_ethdev.c<br>+++ b/drivers/net/bnxt/bnxt_ethdev.c<br>@@ -4861,7 +4861,7 @@ static void bnxt_dev_recover(void *arg)<br> void bnxt_dev_reset_and_resume(void *arg)<br> {<br> struct bnxt *bp = arg;<br>- uint32_t us = US_PER_MS * bp->fw_reset_min_msecs;<br>+ uint64_t us = US_PER_MS * (uint64_t)bp->fw_reset_min_msecs;<br> uint16_t val = 0;<br> int rc;<br><br>@@ -5008,7 +5008,7 @@ static void bnxt_check_fw_health(void *arg)<br><br> info->last_reset_counter = val;<br><br>- rte_eal_alarm_set(US_PER_MS * info->driver_polling_freq,<br>+ rte_eal_alarm_set(US_PER_MS * (uint64_t)info->driver_polling_freq,<br> bnxt_check_fw_health, (void *)bp);<br><br> return;<br>@@ -5030,7 +5030,7 @@ static void bnxt_check_fw_health(void *arg)<br> else<br> wait_msec = info->normal_func_wait_period;<br><br>- rte_eal_alarm_set(US_PER_MS * wait_msec,<br>+ rte_eal_alarm_set(US_PER_MS * (uint64_t)wait_msec,<br> bnxt_fw_reset_cb, (void *)bp);<br> }<br><br>@@ -5048,7 +5048,7 @@ void bnxt_schedule_fw_health_check(struct bnxt *bp)<br><br> polling_freq = bp->recovery_info->driver_polling_freq;<br><br>- rte_eal_alarm_set(US_PER_MS * polling_freq,<br>+ rte_eal_alarm_set(US_PER_MS * (uint64_t)polling_freq,<br> bnxt_check_fw_health, (void *)bp);<br> bp->flags |= BNXT_FLAG_FW_HEALTH_CHECK_SCHEDULED;<br><br>--<br>2.34.1<br> </blockquote></div></div></div></div></div></div></div></div></blockquote></div></div></BODY></HTML>