<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote gmail_quote_container"><div dir="ltr" class="gmail_attr">On Fri, Aug 21, 2026 at 3:29 PM Stephen Hemminger <<a href="mailto:stephen@networkplumber.org">stephen@networkplumber.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Don't need rte_memcpy for fixed size value.<br>
<br>
Signed-off-by: Stephen Hemminger <<a href="mailto:stephen@networkplumber.org" target="_blank">stephen@networkplumber.org</a>><br>
---<br>
drivers/net/bnxt/bnxt_flow.c | 34 ++++++++++++++++++----------------<br>
1 file changed, 18 insertions(+), 16 deletions(-)<br>
<br>
diff --git a/drivers/net/bnxt/bnxt_flow.c b/drivers/net/bnxt/bnxt_flow.c<br>
index a2e590540b..901b019e66 100644<br>
--- a/drivers/net/bnxt/bnxt_flow.c<br>
+++ b/drivers/net/bnxt/bnxt_flow.c<br>
@@ -233,8 +233,9 @@ bnxt_validate_and_parse_flow_type(const struct rte_flow_attr *attr,<br>
"DMAC is invalid!");<br>
return -rte_errno;<br>
}<br>
- rte_memcpy(filter->dst_macaddr,<br>
- ð_spec->hdr.dst_addr, RTE_ETHER_ADDR_LEN);<br>
+ memcpy(filter->dst_macaddr,<br>
+ ð_spec->hdr.dst_addr,<br>
+ RTE_ETHER_ADDR_LEN);<br>
en |= use_ntuple ?<br>
NTUPLE_FLTR_ALLOC_INPUT_EN_DST_MACADDR :<br>
EM_FLOW_ALLOC_INPUT_EN_DST_MACADDR;<br>
@@ -257,8 +258,9 @@ bnxt_validate_and_parse_flow_type(const struct rte_flow_attr *attr,<br>
"SMAC is invalid!");<br>
return -rte_errno;<br>
}<br>
- rte_memcpy(filter->src_macaddr,<br>
- ð_spec->hdr.src_addr, RTE_ETHER_ADDR_LEN);<br>
+ memcpy(filter->src_macaddr,<br>
+ ð_spec->hdr.src_addr,<br>
+ RTE_ETHER_ADDR_LEN);<br>
en |= use_ntuple ?<br>
NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_MACADDR :<br>
EM_FLOW_ALLOC_INPUT_EN_SRC_MACADDR;<br>
@@ -423,23 +425,23 @@ bnxt_validate_and_parse_flow_type(const struct rte_flow_attr *attr,<br>
en |= EM_FLOW_ALLOC_INPUT_EN_SRC_IPADDR |<br>
EM_FLOW_ALLOC_INPUT_EN_DST_IPADDR;<br>
<br>
- rte_memcpy(filter->src_ipaddr,<br>
- &ipv6_spec->hdr.src_addr, 16);<br>
- rte_memcpy(filter->dst_ipaddr,<br>
- &ipv6_spec->hdr.dst_addr, 16);<br>
+ memcpy(filter->src_ipaddr, &ipv6_spec->hdr.src_addr,<br>
+ 16);<br>
+ memcpy(filter->dst_ipaddr, &ipv6_spec->hdr.dst_addr,<br>
+ 16);<br>
<br>
if (!bnxt_check_zero_bytes(ipv6_mask->hdr.src_addr.a,<br>
16)) {<br>
- rte_memcpy(filter->src_ipaddr_mask,<br>
- &ipv6_mask->hdr.src_addr, 16);<br>
+ memcpy(filter->src_ipaddr_mask,<br>
+ &ipv6_mask->hdr.src_addr, 16);<br>
en |= !use_ntuple ? 0 :<br>
NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_IPADDR_MASK;<br>
}<br>
<br>
if (!bnxt_check_zero_bytes(ipv6_mask->hdr.dst_addr.a,<br>
16)) {<br>
- rte_memcpy(filter->dst_ipaddr_mask,<br>
- &ipv6_mask->hdr.dst_addr, 16);<br>
+ memcpy(filter->dst_ipaddr_mask,<br>
+ &ipv6_mask->hdr.dst_addr, 16);<br>
en |= !use_ntuple ? 0 :<br>
NTUPLE_FLTR_ALLOC_INPUT_EN_DST_IPADDR_MASK;<br>
}<br>
@@ -591,8 +593,8 @@ bnxt_validate_and_parse_flow_type(const struct rte_flow_attr *attr,<br>
return -rte_errno;<br>
}<br>
<br>
- rte_memcpy(((uint8_t *)&tenant_id_be + 1),<br>
- vxlan_spec->hdr.vni, 3);<br>
+ memcpy(((uint8_t *)&tenant_id_be + 1),<br>
+ vxlan_spec->hdr.vni, 3);<br>
filter->vni =<br>
rte_be_to_cpu_32(tenant_id_be);<br>
filter->tunnel_type =<br>
@@ -645,8 +647,8 @@ bnxt_validate_and_parse_flow_type(const struct rte_flow_attr *attr,<br>
"Invalid TNI mask");<br>
return -rte_errno;<br>
}<br>
- rte_memcpy(((uint8_t *)&tenant_id_be + 1),<br>
- nvgre_spec->tni, 3);<br>
+ memcpy(((uint8_t *)&tenant_id_be + 1),<br>
+ nvgre_spec->tni, 3);<br>
filter->vni =<br>
rte_be_to_cpu_32(tenant_id_be);<br>
filter->tunnel_type =<br>
--</blockquote><div><span style="font-family:Calibri;font-size:11pt;background-color:transparent">Acked-by: Kishore
Padmanabha <<a href="mailto:kishore.padmanabha@broadcom.com">kishore.padmanabha@broadcom.com</a>></span> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> <br>
2.53.0<br>
<br>
</blockquote></div></div>