<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote gmail_quote_container"><div dir="ltr" class="gmail_attr">On Wed, Aug 5, 2026 at 11:37 AM Andrew Bailey <<a href="mailto:abailey@iol.unh.edu">abailey@iol.unh.edu</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">The single core forward performance test suite can run a variety of<br>
combinations of buffer sizes and number of descriptors. It is beneficial<br></blockquote><div><br></div><div>"it would be"</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
if any possible combination of these parameters could be tested against<br>
a specific delta tolerance; Rather than a globally defined tolerance for<br></blockquote><div><br></div><div>is semi colon right here?</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
all testing. Along with this, adjusting traffic duration and test<br>
repetitions helps users define a more accurate test run if they wish to<br>
get a more refined average. Furthermore, the cores allotted to TREX can<br>
vary among systems and should be defined by the user.</blockquote><div><br></div><div>nit but can you call out the specific performance test in the commit title? </div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
Signed-off-by: Andrew Bailey <<a href="mailto:abailey@iol.unh.edu" target="_blank">abailey@iol.unh.edu</a>><br><br>
#: A union type discriminating traffic generators by the `type` field.<br>
diff --git a/dts/framework/testbed_model/traffic_generator/trex.py b/dts/framework/testbed_model/traffic_generator/trex.py<br>
index d53791b0a6..2b52cfcbd1 100644<br>
--- a/dts/framework/testbed_model/traffic_generator/trex.py<br>
+++ b/dts/framework/testbed_model/traffic_generator/trex.py<br>
@@ -82,7 +82,7 @@ class TrexTrafficGenerator(PerformanceTrafficGenerator):<br>
<br>
_streaming_mode: TrexStatelessTXModes = TrexStatelessTXModes.STLTXCont<br>
<br>
- _tg_cores: int = 10<br>
+ _tg_cores: int<br></blockquote><div><br></div><div>Why not keep the default of 10 but allow cores as an optional parameter in test_run.yaml?</div><div><br></div><div>I don't feel strongly about the matter but in general I don't want "config creep" when we can avoid it. Less config is better. But yes we can add config when necessary.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
_trex_app: BlockingApp<br>
<br>
@@ -102,6 +102,7 @@ def __init__(self, tg_node: Node, config: TrexTrafficGeneratorConfig) -> None:<br>
super().__init__(tg_node=tg_node, config=config)<br>
self._tg_node_config = tg_node.config<br>
self._tg_config = config<br>
+ self._tg_cores = config.cores<br>
<br>
self._os_session = create_session(self._tg_node.config, "TRex", self._logger)<br>
<br>
diff --git a/dts/tests/TestSuite_single_core_forward_perf.py b/dts/tests/TestSuite_single_core_forward_perf.py<br>
index 57aecdf7a4..a966d44ebd 100644<br>
--- a/dts/tests/TestSuite_single_core_forward_perf.py<br>
+++ b/dts/tests/TestSuite_single_core_forward_perf.py<br>
@@ -32,14 +32,40 @@ class Config(BaseConfig):<br>
"""Performance test metrics."""<br>
<br>
test_parameters: list[dict[str, int | float]] = [<br>
- {"frame_size": 64, "num_descriptors": 1024, "expected_mpps": 1.00},<br>
- {"frame_size": 128, "num_descriptors": 1024, "expected_mpps": 1.00},<br>
- {"frame_size": 256, "num_descriptors": 1024, "expected_mpps": 1.00},<br>
- {"frame_size": 512, "num_descriptors": 1024, "expected_mpps": 1.00},<br>
- {"frame_size": 1024, "num_descriptors": 1024, "expected_mpps": 1.00},<br>
- {"frame_size": 1518, "num_descriptors": 1024, "expected_mpps": 1.00},<br>
+ {"frame_size": 64, "num_descriptors": 1024, "expected_mpps": 1.00, "delta_tolerance": 0.05},<br>
+ {<br>
+ "frame_size": 128,<br>
+ "num_descriptors": 1024,<br>
+ "expected_mpps": 1.00,<br>
+ "delta_tolerance": 0.05,<br>
+ },<br>
+ {<br>
+ "frame_size": 256,<br>
+ "num_descriptors": 1024,<br>
+ "expected_mpps": 1.00,<br>
+ "delta_tolerance": 0.05,<br>
+ },<br>
+ {<br>
+ "frame_size": 512,<br>
+ "num_descriptors": 1024,<br>
+ "expected_mpps": 1.00,<br>
+ "delta_tolerance": 0.05,<br>
+ },<br>
+ {<br>
+ "frame_size": 1024,<br>
+ "num_descriptors": 1024,<br>
+ "expected_mpps": 1.00,<br>
+ "delta_tolerance": 0.05,<br>
+ },<br>
+ {<br>
+ "frame_size": 1518,<br>
+ "num_descriptors": 1024,<br>
+ "expected_mpps": 1.00,<br>
+ "delta_tolerance": 0.05,<br>
+ },<br>
]<br>
- delta_tolerance: float = 0.05<br></blockquote><div><br></div><div>So, with this patch applied one MUST set the delta_tolerance per param, as opposed to optionally setting it per param or per testsuite? I'm not sure if it's a big lift to support both, but given that 99% of people probably want to just say "5% delta tolerance for single core forward perf testsuite" it would make sense to preserve that existing config option.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
+ traffic_duration: int = 5<br>
+ test_repetitions: int = 5<br></blockquote><div><br></div><div>Do you need to update tests_config.example.yaml? And explain which parameters are optional vs required?</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
<br>
@requires_link_topology(LinkTopology.TWO_LINKS)<br><br></blockquote><div><br></div><div>Reviewed-by: Patrick Robb <<a href="mailto:patrickrobb1997@gmail.com">patrickrobb1997@gmail.com</a>> </div></div></div>