<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"> <head> <meta http-equiv="Content-Type" content="text/html; charset=us-ascii"> <meta name="Generator" content="Microsoft Word 15 (filtered medium)"> <style></style> </head> <body lang="ZH-CN" link="blue" vlink="purple"> <div class="WordSection1"> Prefer that add these tests in “test_case_checklist.json” and at the same time filter the NICs that both mentioned in the scripts and your last patch.<o:p></o:p> In other words, it’s make sense to filter these cases that could not be supported by some NICes, both intel NICs and cavium.<o:p></o:p> <o:p> </o:p> I ‘d like to clarify that checklist is considered as blacklist while support list constitutes whitelist. <o:p></o:p> <a name="_MailEndCompose"><o:p> </o:p></a> <div style="border:none;border-left:solid blue 1.5pt;padding:0cm 0cm 0cm 4.0pt"> <div> <div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm"> <a name="_____replyseparator"></a>From: Phanendra Vukkisala [mailto:pvukkisala@marvell.com] Sent: Monday, January 7, 2019 5:39 PM To: Tu, Lijuan <lijuan.tu@intel.com>; dts@dpdk.org Cc: Vijaya Bhaskar Annayyolla <avijay@marvell.com>; Faisal Masood <fmasood@marvell.com> Subject: Re: [PATCH] conf/test_case_supportlist.json: Avoid showing fail for not supported NICs<o:p></o:p> </div> </div> <o:p> </o:p> <div id="divtagdefaultwrapper"> <div id="divtagdefaultwrapper"> Hi Lijuan,<o:p></o:p> <o:p> </o:p> I can add these tests in "test_case_checklist.json" as these are not supported on cavium devices. <o:p></o:p> But in the test scripts, I can see the tests are supported only on few NICs I have mentioned in supportlist.json <o:p></o:p> <o:p> </o:p> For instance: the syn_filter test is supported by Niantic, kawela_4, bartonhills, powerville. I have taken this reference from test scripts. <o:p></o:p> Below is test script snippet, because of verifying inside test case the result of test is showing as Failed instead of Not Applicable for other NICs.<o:p></o:p> <o:p> </o:p> <div> def test_syn_filter(self): """ Enable receipt of SYN packets """ self.verify(self.nic in ["niantic", "kawela_4", "bartonhills", "powerville"], "%s nic not support syn filter" % self.nic)<o:p></o:p> </div> <o:p> </o:p> <o:p> </o:p> If you fell I should update in "test_case_checklist.json" for cavium device only, please let me know I will do the same.<o:p></o:p> <o:p> </o:p> <div id="Signature"> <div id="divtagdefaultwrapper"> Regards,<o:p></o:p> Phanendra<o:p></o:p> </div> </div> </div> <div class="MsoNormal" align="center" style="text-align:center"> <hr size="3" width="98%" align="center"> </div> <div id="divRplyFwdMsg"> From: Tu, Lijuan <<a href="mailto:lijuan.tu@intel.com">lijuan.tu@intel.com</a>> Sent: Monday, January 7, 2019 2:13:59 PM To: Phanendra Vukkisala; <a href="mailto:dts@dpdk.org">dts@dpdk.org</a> Cc: Vijaya Bhaskar Annayyolla; Faisal Masood Subject: [EXT] RE: [PATCH] conf/test_case_supportlist.json: Avoid showing fail for not supported NICs <o:p></o:p> <div> <o:p></o:p> </div> </div> <div> <div> External Email ---------------------------------------------------------------------- Hi phanendra, If test cases are not supported by some NICs, I should be added into test_case_checklist.json. Only the cases that added in supportlist.json are supported by these specific NICs. For instance: the syn_filter you added in the support list. Syn_filter is only supported by Niantic, kawela_r, bartonhills, powerville, but not supported by Fortville and other NICes. "syn_filter": [ > + { > + "OS": [ > + "ALL" > + ], > + "NIC": [ > + "niantic", > + "kawela_4", > + "bartonhills", > + "powerville" > + ], > + "Target": [ > + "ALL" > + ], > + "Bug ID": "", > + "Comments": "This case not support on this NIC" > + } > + ], > -----Original Message----- > From: dts [<a href="mailto:dts-bounces@dpdk.org" id="LPlnk909053">mailto:dts-bounces@dpdk.org</a>] On Behalf Of Phanendra Vukkisala > Sent: Friday, January 4, 2019 5:00 PM > To: <a href="mailto:dts@dpdk.org">dts@dpdk.org</a> > Cc: Vijaya Bhaskar Annayyolla <<a href="mailto:avijay@marvell.com">avijay@marvell.com</a>>; Faisal Masood > <<a href="mailto:fmasood@marvell.com">fmasood@marvell.com</a>>; Phanendra Vukkisala <<a href="mailto:pvukkisala@marvell.com">pvukkisala@marvell.com</a>> > Subject: [dts] [PATCH] conf/test_case_supportlist.json: Avoid showing fail > for not supported NICs > > From: pvukkisala <<a href="mailto:pvukkisala@marvell.com">pvukkisala@marvell.com</a>> > > Result is showing as fail for not supported NICs. Added proper fix to avoid > show test result as fail instead of N/A. > > Signed-off-by: phanendra,vukkisala <<a href="mailto:pvukkisala@marvell.com">pvukkisala@marvell.com</a>> > --- > conf/test_case_supportlist.json | 201 > +++++++++++++++++++++++++++++++++++++++ > 1 file changed, 201 insertions(+) > > diff --git a/conf/test_case_supportlist.json > b/conf/test_case_supportlist.json index 571bb5c..c128c95 100644 > --- a/conf/test_case_supportlist.json > +++ b/conf/test_case_supportlist.json > @@ -633,5 +633,206 @@ > "Bug ID": "", > "Comments": "This case only support on FVL" > } > + ], > + "syn_filter": [ > + { > + "OS": [ > + "ALL" > + ], > + "NIC": [ > + "niantic", > + "kawela_4", > + "bartonhills", > + "powerville" > + ], > + "Target": [ > + "ALL" > + ], > + "Bug ID": "", > + "Comments": "This case not support on this NIC" > + } > + ], > + "priority_filter": [ > + { > + "OS": [ > + "ALL" > + ], > + "NIC": [ > + "niantic", > + "kawela_4", > + "bartonhills", > + "powerville" > + ], > + "Target": [ > + "ALL" > + ], > + "Bug ID": "", > + "Comments": "This case not support on this NIC" > + } > + ], > + "five_tuple_filter": [ > + { > + "OS": [ > + "ALL" > + ], > + "NIC": [ > + "niantic", > + "kawela_4" > + ], > + "Target": [ > + "ALL" > + ], > + "Bug ID": "", > + "Comments": "This case only support only on Niantic and > kawela_4" > + } > + ], > + "ethertype_filter": [ > + { > + "OS": [ > + "ALL" > + ], > + "NIC": [ > + "niantic", > + "kawela_4", > + "bartonhills", > + "powerville", > + "fortville_eagle", > + "fortville_spirit", > + "fortville_spirit_single", > + "fortpark_TLV", > + "fortville_25g" > + ], > + "Target": [ > + "ALL" > + ], > + "Bug ID": "", > + "Comments": "This case is not supported on this NIC" > + } > + ], > + "multiple_filters_10GB": [ > + { > + "OS": [ > + "ALL" > + ], > + "NIC": [ > + "niantic" > + ], > + "Target": [ > + "ALL" > + ], > + "Bug ID": "", > + "Comments": "This case only support with Niantic NIC" > + } > + ], > + "twotuple_filter": [ > + { > + "OS": [ > + "ALL" > + ], > + "NIC": [ > + "powerville", > + "bartonhills" > + ], > + "Target": [ > + "ALL" > + ], > + "Bug ID": "", > + "Comments": "This case is not supported on this NIC" > + } > + ], > + "flex_filter": [ > + { > + "OS": [ > + "ALL" > + ], > + "NIC": [ > + "powerville", > + "bartonhills" > + ], > + "Target": [ > + "ALL" > + ], > + "Bug ID": "", > + "Comments": "This case is not supported on this NIC" > + } > + ], > + "multiple_filters_1GB": [ > + { > + "OS": [ > + "ALL" > + ], > + "NIC": [ > + "powerville", > + "kawela_4", > + "bartonhills" > + ], > + "Target": [ > + "ALL" > + ], > + "Bug ID": "", > + "Comments": "This case is not supported on this NIC" > + } > + ], > + "128_queues": [ > + { > + "OS": [ > + "ALL" > + ], > + "NIC": [ > + "niantic", > + "ironpond", > + "twinpond", > + "twinville", > + "sageville", > + "sagepond", > + "magnolia_park", > + "springfountain" > + ], > + "Target": [ > + "ALL" > + ], > + "Bug ID": "", > + "Comments": "This case only support with ixgbe driver" > + } > + ], > + "rss_key_size": [ > + { > + "OS": [ > + "ALL" > + ], > + "NIC": [ > + "fortville_eagle", > + "fortville_spirit", > + "fortville_spirit_single", > + "fortville_25g", > + "niantic", > + "redrockcanyou", > + "atwood", > + "boulderrapid", > + "fortpark_TLV" > + ], > + "Target": [ > + "ALL" > + ], > + "Bug ID": "", > + "Comments": "This case is not supported on this NIC" > + } > + ], > + "vlan_qinq_tpid": [ > + { > + "OS": [ > + "ALL" > + ], > + "NIC": [ > + "fortville_eagle", > + "fortville_spirit", > + "fortville_spirit_single" > + ], > + "Target": [ > + "ALL" > + ], > + "Bug ID": "", > + "Comments": "This case is not supported on this NIC" > + } > ] > } > -- > 1.7.9.5<o:p></o:p> </div> </div> </div> </div> </div> </body> </html>