<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css" style="display:none;"><!-- P {margin-top:0;margin-bottom:0;} --></style>
</head>
<body dir="ltr">
<div id="divtagdefaultwrapper" dir="ltr" style="font-size: 12pt; color: rgb(117, 123, 128); font-family: "Palatino Linotype","Book Antiqua",Palatino,serif,"EmojiFont","Apple Color Emoji","Segoe UI Emoji",NotoColorEmoji,"Segoe UI Symbol","Android Emoji",EmojiSymbols;">
<div id="divtagdefaultwrapper" dir="ltr" style="font-size:12pt; color:rgb(117,123,128); font-family:"Palatino Linotype","Book Antiqua",Palatino,serif,"EmojiFont","Apple Color Emoji","Segoe UI Emoji",NotoColorEmoji,"Segoe UI Symbol","Android Emoji",EmojiSymbols">
<p style="margin-top:0; margin-bottom:0">Hi Lijuan,</p>
<p style="margin-top:0; margin-bottom:0"><br>
</p>
<p style="margin-top:0; margin-bottom:0"><span style="font-size: 12pt;">I can add these tests in
</span><font size="2"><span style="font-size:11pt"><span style="font-size: 12pt;"><span style="font-size: 12pt;">"t</span><span style="font-size: 12pt;">e</span><span style="font-size: 12pt;">s</span><span style="font-size: 12pt;">t</span><span style="font-size: 12pt;">_</span><span style="font-size: 12pt;">c</span><span style="font-size: 12pt;">a</span><span style="font-size: 12pt;">s</span><span style="font-size: 12pt;">e</span><span style="font-size: 12pt;">_</span><span style="font-size: 12pt;">c</span><span style="font-size: 12pt;">h</span><span style="font-size: 12pt;">e</span><span style="font-size: 12pt;">c</span><span style="font-size: 12pt;">k</span><span style="font-size: 12pt;">l</span><span style="font-size: 12pt;">i</span><span style="font-size: 12pt;">s</span><span style="font-size: 12pt;">t</span><span style="font-size: 12pt;">.</span><span style="font-size: 12pt;">j</span><span style="font-size: 12pt;">s</span><span style="font-size: 12pt;">o</span><span style="font-size: 12pt;">n"</span><span style="font-size: 12pt;">
</span><span style="font-size: 12pt;">as thes</span></span><span style="font-size: 12pt;"><span style="font-size: 12pt;">e are not supported on
</span><span style="font-size: 12pt;">cav</span><span style="font-size: 12pt;">ium</span><span style="font-size: 12pt;"> devices.
</span></span><br>
</span></font></p>
<p style="margin-top:0; margin-bottom:0"><font size="2"><span style="font-size:11pt"></span></font><span style="font-size: 12pt;">But in the test scripts, I can see the tests are supported only on few NICs I have mentioned in
</span><font size="2"><span style="font-size: 12pt;">supportlist.json</span></font><span style="font-size: 12pt;">
</span><br>
</p>
<p style="margin-top:0; margin-bottom:0"><br>
</p>
<span style="font-size: 12pt;"></span>
<p style="margin-top:0; margin-bottom:0"><span style="font-size: 12pt;">For instance: the syn_filter test is supported by
</span><font size="2"><span style="font-size: 12pt;">Niantic, kawela_4, bartonhills, powerville</span></font><span style="font-size: 12pt;">. I have taken this reference from test scripts.
</span><br>
<span style="font-size: 12pt;"></span></p>
<span style="font-size: 12pt;"></span><span style="font-size: 12pt;"></span>
<p style="margin-top:0; margin-bottom:0"><span style="font-size: 12pt;">Below is test script snippet, because of verifying inside test case the result of test is showing as Failed instead of Not Applicable for other NICs.</span><br>
<span style="font-size: 12pt;"></span></p>
<span style="font-size: 12pt;"></span>
<p style="margin-top:0; margin-bottom:0"><br>
<span style="font-size: 12pt;"></span></p>
<span style="font-size: 12pt;"></span>
<p style="margin-top:0; margin-bottom:0"></p>
<span style="font-size: 12pt;"></span>
<div><span style="font-size: 12pt; font-family: Arial,Helvetica,sans-serif;"> def test_syn_filter(self):</span><br>
<span style="font-size: 12pt; font-family: Arial,Helvetica,sans-serif;"></span><span style="font-size: 12pt; font-family: Arial,Helvetica,sans-serif;"> """
</span><br>
<span style="font-size: 12pt; font-family: Arial,Helvetica,sans-serif;"></span><span style="font-size: 12pt; font-family: Arial,Helvetica,sans-serif;"> Enable receipt of SYN packets</span><br>
<span style="font-size: 12pt; font-family: Arial,Helvetica,sans-serif;"></span><span style="font-size: 12pt; font-family: Arial,Helvetica,sans-serif;"> """</span><br>
<span style="font-size: 12pt; font-family: Arial,Helvetica,sans-serif;"></span><span style="font-size: 12pt; font-family: Arial,Helvetica,sans-serif;"> self.verify(self.nic in ["niantic", "kawela_4", "bartonhills", "powerville"], "%s nic not support
syn filter" % self.nic)</span><br>
<span style="font-size: 12pt; font-family: Arial,Helvetica,sans-serif;"></span></div>
<span style="font-size: 12pt; font-family: Arial,Helvetica,sans-serif;"></span><br>
<p></p>
<p style="margin-top:0; margin-bottom:0"><br>
</p>
<p style="margin-top:0; margin-bottom:0"><font size="2"><span style="font-size:11pt"><span style="font-size: 12pt;"><span style="font-size: 12pt;"></span></span><span style="font-size: 12pt;">If you fell I should update
</span><span style="font-size: 12pt;">in </span><font size="2"><span style="font-size:11pt"><span style="font-size: 12pt;">"test_case_checklist.json" for cavium device only</span></span></font><span style="font-size: 12pt;">, please let me know I will
</span><span style="font-size: 12pt;">d</span><span style="font-size: 12pt;">o the same.</span></span></font></p>
<p style="margin-top:0; margin-bottom:0"><br>
</p>
<div id="Signature">
<meta content="text/html; charset=UTF-8">
<div id="divtagdefaultwrapper" dir="ltr" style="font-size:12pt; color:rgb(0,0,0); font-family:Calibri,Helvetica,sans-serif,"EmojiFont","Apple Color Emoji","Segoe UI Emoji",NotoColorEmoji,"Segoe UI Symbol","Android Emoji",EmojiSymbols">
<p style="margin-top:0; margin-bottom:0"><span style="font-family:"Palatino Linotype","Book Antiqua",Palatino,serif; background-color:rgb(255,255,255); color:rgb(117,123,128)">Regards,</span></p>
<span style="background-color:rgb(255,255,255); color:rgb(117,123,128)"></span>
<p style="margin-top:0; margin-bottom:0"><span style="font-family:"Palatino Linotype","Book Antiqua",Palatino,serif"><span style="background-color:rgb(255,255,255); color:rgb(117,123,128)">Phanendra</span><span style="color:rgb(117,123,128)"></span></span><br>
</p>
</div>
</div>
</div>
<hr style="display:inline-block; width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font style="font-size:11pt" face="Calibri, sans-serif" color="#000000"><b>From:</b> Tu, Lijuan <lijuan.tu@intel.com><br>
<b>Sent:</b> Monday, January 7, 2019 2:13:59 PM<br>
<b>To:</b> Phanendra Vukkisala; dts@dpdk.org<br>
<b>Cc:</b> Vijaya Bhaskar Annayyolla; Faisal Masood<br>
<b>Subject:</b> [EXT] RE: [PATCH] conf/test_case_supportlist.json: Avoid showing fail for not supported NICs</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt">
<div class="PlainText">External Email<br>
<br>
----------------------------------------------------------------------<br>
Hi phanendra,<br>
<br>
If test cases are not supported by some NICs, I should be added into test_case_checklist.json.<br>
Only the cases that added in supportlist.json are supported by these specific NICs.<br>
<br>
For instance: the syn_filter you added in the support list.<br>
Syn_filter is only supported by Niantic, kawela_r, bartonhills, powerville, but not supported by Fortville and other NICes.<br>
<br>
"syn_filter": [<br>
> + {<br>
> + "OS": [<br>
> + "ALL"<br>
> + ],<br>
> + "NIC": [<br>
> + "niantic",<br>
> + "kawela_4",<br>
> + "bartonhills",<br>
> + "powerville"<br>
> + ],<br>
> + "Target": [<br>
> + "ALL"<br>
> + ],<br>
> + "Bug ID": "",<br>
> + "Comments": "This case not support on this NIC"<br>
> + }<br>
> + ],<br>
<br>
<br>
> -----Original Message-----<br>
> From: dts [<a href="mailto:dts-bounces@dpdk.org" id="LPlnk909053" class="OWAAutoLink" previewremoved="true">mailto:dts-bounces@dpdk.org</a>] On Behalf Of Phanendra Vukkisala<br>
> Sent: Friday, January 4, 2019 5:00 PM<br>
> To: dts@dpdk.org<br>
> Cc: Vijaya Bhaskar Annayyolla <avijay@marvell.com>; Faisal Masood<br>
> <fmasood@marvell.com>; Phanendra Vukkisala <pvukkisala@marvell.com><br>
> Subject: [dts] [PATCH] conf/test_case_supportlist.json: Avoid showing fail<br>
> for not supported NICs<br>
> <br>
> From: pvukkisala <pvukkisala@marvell.com><br>
> <br>
> Result is showing as fail for not supported NICs. Added proper fix to avoid<br>
> show test result as fail instead of N/A.<br>
> <br>
> Signed-off-by: phanendra,vukkisala <pvukkisala@marvell.com><br>
> ---<br>
> conf/test_case_supportlist.json | 201<br>
> +++++++++++++++++++++++++++++++++++++++<br>
> 1 file changed, 201 insertions(+)<br>
> <br>
> diff --git a/conf/test_case_supportlist.json<br>
> b/conf/test_case_supportlist.json index 571bb5c..c128c95 100644<br>
> --- a/conf/test_case_supportlist.json<br>
> +++ b/conf/test_case_supportlist.json<br>
> @@ -633,5 +633,206 @@<br>
> "Bug ID": "",<br>
> "Comments": "This case only support on FVL"<br>
> }<br>
> + ],<br>
> + "syn_filter": [<br>
> + {<br>
> + "OS": [<br>
> + "ALL"<br>
> + ],<br>
> + "NIC": [<br>
> + "niantic",<br>
> + "kawela_4",<br>
> + "bartonhills",<br>
> + "powerville"<br>
> + ],<br>
> + "Target": [<br>
> + "ALL"<br>
> + ],<br>
> + "Bug ID": "",<br>
> + "Comments": "This case not support on this NIC"<br>
> + }<br>
> + ],<br>
> + "priority_filter": [<br>
> + {<br>
> + "OS": [<br>
> + "ALL"<br>
> + ],<br>
> + "NIC": [<br>
> + "niantic",<br>
> + "kawela_4",<br>
> + "bartonhills",<br>
> + "powerville"<br>
> + ],<br>
> + "Target": [<br>
> + "ALL"<br>
> + ],<br>
> + "Bug ID": "",<br>
> + "Comments": "This case not support on this NIC"<br>
> + }<br>
> + ],<br>
> + "five_tuple_filter": [<br>
> + {<br>
> + "OS": [<br>
> + "ALL"<br>
> + ],<br>
> + "NIC": [<br>
> + "niantic",<br>
> + "kawela_4"<br>
> + ],<br>
> + "Target": [<br>
> + "ALL"<br>
> + ],<br>
> + "Bug ID": "",<br>
> + "Comments": "This case only support only on Niantic and<br>
> kawela_4"<br>
> + }<br>
> + ],<br>
> + "ethertype_filter": [<br>
> + {<br>
> + "OS": [<br>
> + "ALL"<br>
> + ],<br>
> + "NIC": [<br>
> + "niantic",<br>
> + "kawela_4",<br>
> + "bartonhills",<br>
> + "powerville",<br>
> + "fortville_eagle",<br>
> + "fortville_spirit",<br>
> + "fortville_spirit_single",<br>
> + "fortpark_TLV",<br>
> + "fortville_25g"<br>
> + ],<br>
> + "Target": [<br>
> + "ALL"<br>
> + ],<br>
> + "Bug ID": "",<br>
> + "Comments": "This case is not supported on this NIC"<br>
> + }<br>
> + ],<br>
> + "multiple_filters_10GB": [<br>
> + {<br>
> + "OS": [<br>
> + "ALL"<br>
> + ],<br>
> + "NIC": [<br>
> + "niantic"<br>
> + ],<br>
> + "Target": [<br>
> + "ALL"<br>
> + ],<br>
> + "Bug ID": "",<br>
> + "Comments": "This case only support with Niantic NIC"<br>
> + }<br>
> + ],<br>
> + "twotuple_filter": [<br>
> + {<br>
> + "OS": [<br>
> + "ALL"<br>
> + ],<br>
> + "NIC": [<br>
> + "powerville",<br>
> + "bartonhills"<br>
> + ],<br>
> + "Target": [<br>
> + "ALL"<br>
> + ],<br>
> + "Bug ID": "",<br>
> + "Comments": "This case is not supported on this NIC"<br>
> + }<br>
> + ],<br>
> + "flex_filter": [<br>
> + {<br>
> + "OS": [<br>
> + "ALL"<br>
> + ],<br>
> + "NIC": [<br>
> + "powerville",<br>
> + "bartonhills"<br>
> + ],<br>
> + "Target": [<br>
> + "ALL"<br>
> + ],<br>
> + "Bug ID": "",<br>
> + "Comments": "This case is not supported on this NIC"<br>
> + }<br>
> + ],<br>
> + "multiple_filters_1GB": [<br>
> + {<br>
> + "OS": [<br>
> + "ALL"<br>
> + ],<br>
> + "NIC": [<br>
> + "powerville",<br>
> + "kawela_4",<br>
> + "bartonhills"<br>
> + ],<br>
> + "Target": [<br>
> + "ALL"<br>
> + ],<br>
> + "Bug ID": "",<br>
> + "Comments": "This case is not supported on this NIC"<br>
> + }<br>
> + ],<br>
> + "128_queues": [<br>
> + {<br>
> + "OS": [<br>
> + "ALL"<br>
> + ],<br>
> + "NIC": [<br>
> + "niantic",<br>
> + "ironpond",<br>
> + "twinpond",<br>
> + "twinville",<br>
> + "sageville",<br>
> + "sagepond",<br>
> + "magnolia_park",<br>
> + "springfountain"<br>
> + ],<br>
> + "Target": [<br>
> + "ALL"<br>
> + ],<br>
> + "Bug ID": "",<br>
> + "Comments": "This case only support with ixgbe driver"<br>
> + }<br>
> + ],<br>
> + "rss_key_size": [<br>
> + {<br>
> + "OS": [<br>
> + "ALL"<br>
> + ],<br>
> + "NIC": [<br>
> + "fortville_eagle",<br>
> + "fortville_spirit",<br>
> + "fortville_spirit_single",<br>
> + "fortville_25g",<br>
> + "niantic",<br>
> + "redrockcanyou",<br>
> + "atwood",<br>
> + "boulderrapid",<br>
> + "fortpark_TLV"<br>
> + ],<br>
> + "Target": [<br>
> + "ALL"<br>
> + ],<br>
> + "Bug ID": "",<br>
> + "Comments": "This case is not supported on this NIC"<br>
> + }<br>
> + ],<br>
> + "vlan_qinq_tpid": [<br>
> + {<br>
> + "OS": [<br>
> + "ALL"<br>
> + ],<br>
> + "NIC": [<br>
> + "fortville_eagle",<br>
> + "fortville_spirit",<br>
> + "fortville_spirit_single"<br>
> + ],<br>
> + "Target": [<br>
> + "ALL"<br>
> + ],<br>
> + "Bug ID": "",<br>
> + "Comments": "This case is not supported on this NIC"<br>
> + }<br>
> ]<br>
> }<br>
> --<br>
> 1.7.9.5<br>
<br>
</div>
</span></font></div>
</div>
</body>
</html>