<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<!--[if !mso]><style>v\:* {behavior:url(#default#VML);}
o\:* {behavior:url(#default#VML);}
w\:* {behavior:url(#default#VML);}
.shape {behavior:url(#default#VML);}
</style><![endif]--><style><!--
/* Font Definitions */
@font-face
        {font-family:SimSun;
        panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
        {font-family:"Cambria Math";
        panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
        {font-family:Calibri;
        panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
        {font-family:"\@SimSun";
        panose-1:2 1 6 0 3 1 1 1 1 1;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
        {margin:0cm;
        margin-bottom:.0001pt;
        font-size:12.0pt;
        font-family:"Times New Roman",serif;}
a:link, span.MsoHyperlink
        {mso-style-priority:99;
        color:blue;
        text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
        {mso-style-priority:99;
        color:purple;
        text-decoration:underline;}
p
        {mso-style-priority:99;
        margin:0cm;
        margin-bottom:.0001pt;
        font-size:12.0pt;
        font-family:"Times New Roman",serif;}
span.EmailStyle18
        {mso-style-type:personal-reply;
        font-family:"Calibri",sans-serif;
        color:#1F497D;}
.MsoChpDefault
        {mso-style-type:export-only;
        font-size:10.0pt;}
@page WordSection1
        {size:612.0pt 792.0pt;
        margin:72.0pt 72.0pt 72.0pt 72.0pt;}
div.WordSection1
        {page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><a name="_MailEndCompose"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"><o:p> </o:p></span></a></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0cm 0cm 0cm 4.0pt">
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><a name="_____replyseparator"></a><b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">From:</span></b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif"> Narala Praneeth Reddy [mailto:nareddy@marvell.com]
<br>
<b>Sent:</b> Wednesday, April 24, 2019 4:27 AM<br>
<b>To:</b> Tu, Lijuan <lijuan.tu@intel.com>; dts@dpdk.org<br>
<b>Cc:</b> Faisal Masood <fmasood@marvell.com>; Vijaya Bhaskar Annayyolla <avijay@marvell.com><br>
<b>Subject:</b> Re: [dts] [PATCH] TestSuite_ptype_mapping.py: i40 pmd specific ptype mapping is not supported for cavium_a063<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<div id="divtagdefaultwrapper">
<p><span style="font-family:"Calibri",sans-serif;color:black">Please find inline comments.<o:p></o:p></span></p>
<p class="MsoNormal" style="margin-bottom:12.0pt"><span style="font-family:"Calibri",sans-serif;color:black"><o:p> </o:p></span></p>
<div>
<div class="MsoNormal" align="center" style="text-align:center"><span style="font-family:"Calibri",sans-serif;color:black">
<hr size="3" width="98%" align="center">
</span></div>
<div id="divRplyFwdMsg">
<p class="MsoNormal"><b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:black">From:</span></b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:black"> Tu, Lijuan <<a href="mailto:lijuan.tu@intel.com">lijuan.tu@intel.com</a>><br>
<b>Sent:</b> Wednesday, April 24, 2019 1:10 AM<br>
<b>To:</b> Narala Praneeth Reddy; <a href="mailto:dts@dpdk.org">dts@dpdk.org</a><br>
<b>Cc:</b> Faisal Masood; Vijaya Bhaskar Annayyolla<br>
<b>Subject:</b> [EXT] RE: [dts] [PATCH] TestSuite_ptype_mapping.py: i40 pmd specific ptype mapping is not supported for cavium_a063</span><span style="font-family:"Calibri",sans-serif;color:black">
<o:p></o:p></span></p>
<div>
<p class="MsoNormal"><span style="font-family:"Calibri",sans-serif;color:black"> <o:p></o:p></span></p>
</div>
</div>
<div>
<div>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:black">External Email<br>
<br>
----------------------------------------------------------------------<br>
<br>
<br>
> -----Original Message-----<br>
> From: dts [<a href="mailto:dts-bounces@dpdk.org" id="LPlnk299570">mailto:dts-bounces@dpdk.org</a>] On Behalf Of<br>
> <a href="mailto:nareddy@marvell.com">nareddy@marvell.com</a><br>
> Sent: Monday, April 22, 2019 10:24 PM<br>
> To: <a href="mailto:dts@dpdk.org">dts@dpdk.org</a><br>
> Cc: <a href="mailto:fmasood@marvell.com">fmasood@marvell.com</a>; <a href="mailto:avijay@marvell.com">
avijay@marvell.com</a>; Praneeth Reddy<br>
> <<a href="mailto:nareddy@marvell.com">nareddy@marvell.com</a>><br>
> Subject: [dts] [PATCH] TestSuite_ptype_mapping.py: i40 pmd specific ptype<br>
> mapping is not supported for cavium_a063<br>
> <br>
> From: Praneeth Reddy <<a href="mailto:nareddy@marvell.com">nareddy@marvell.com</a>><br>
> <br>
> Marking this test case as not applicable for cavium_a063<br>
> <br>
> Signed-off-by: Praneeth Reddy <<a href="mailto:nareddy@marvell.com">nareddy@marvell.com</a>><br>
> ---<br>
>  conf/test_case_checklist.json    | 62<br>
> +++++++++++++++++++++++++++++++++++++++-<br>
>  tests/TestSuite_ptype_mapping.py |  2 +-<br>
>  2 files changed, 62 insertions(+), 2 deletions(-)<br>
> <br>
> diff --git a/conf/test_case_checklist.json b/conf/test_case_checklist.json<br>
> index a1aa90b..decc946 100644<br>
> --- a/conf/test_case_checklist.json<br>
> +++ b/conf/test_case_checklist.json<br>
> @@ -2200,5 +2200,65 @@<br>
>              "Bug ID": "",<br>
>              "Comments": "the nic not support this case"<br>
>          }<br>
> -    ]<br>
> +    ],<br>
> +     "ptype_mapping_get": [<br>
> +        {<br>
> +            "OS": [<br>
> +                "ALL"<br>
> +            ],<br>
> +            "NIC": [<br>
> +                "cavium_a063"<br>
> +            ],<br>
> +            "Target": [<br>
> +                "ALL"<br>
> +            ],<br>
> +            "Bug ID": "",<br>
> +            "Comments": "the nic not support this case"<br>
> +        }<br>
> +    ],<br>
> +     "ptype_mapping_replace": [<br>
> +        {<br>
> +            "OS": [<br>
> +                "ALL"<br>
> +            ],<br>
> +            "NIC": [<br>
> +                "cavium_a063"<br>
> +            ],<br>
> +            "Target": [<br>
> +                "ALL"<br>
> +            ],<br>
> +            "Bug ID": "",<br>
> +            "Comments": "the nic not support this case"<br>
> +        }<br>
> +    ],<br>
> +     "ptype_mapping_reset": [<br>
> +        {<br>
> +            "OS": [<br>
> +                "ALL"<br>
> +            ],<br>
> +            "NIC": [<br>
> +                "cavium_a063"<br>
> +            ],<br>
> +            "Target": [<br>
> +                "ALL"<br>
> +            ],<br>
> +            "Bug ID": "",<br>
> +            "Comments": "the nic not support this case"<br>
> +        }<br>
> +    ],<br>
> +     "ptype_mapping_update": [<br>
> +        {<br>
> +            "OS": [<br>
> +                "ALL"<br>
> +            ],<br>
> +            "NIC": [<br>
> +                "cavium_a063"<br>
> +            ],<br>
> +            "Target": [<br>
> +                "ALL"<br>
> +            ],<br>
> +            "Bug ID": "",<br>
> +            "Comments": "the nic not support this case"<br>
> +        }<br>
> +     ]<br>
>  }<br>
> diff --git a/tests/TestSuite_ptype_mapping.py<br>
> b/tests/TestSuite_ptype_mapping.py<br>
> index 2771337..6e1fce1 100644<br>
> --- a/tests/TestSuite_ptype_mapping.py<br>
> +++ b/tests/TestSuite_ptype_mapping.py<br>
> @@ -45,7 +45,7 @@ class TestPtype_Mapping(TestCase):<br>
>          Run at the start of each test suite.<br>
>          """<br>
>          self.verify(self.nic in ['fortville_eagle', 'fortville_spirit',<br>
> -            'fortville_spirit_single', 'fortville_25g'],<br>
> +            'fortville_spirit_single', 'fortville_25g', 'cavium_a063'],<br>
[Lijuan] The NIC in the list above means support these cases. But from other context, Cavium_a063 does not support ptype mapping, Did I miss anything?<o:p></o:p></span></p>
<div>
<p class="MsoNormal" style="margin-left:4.8pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:black">[Praneeth] ptype_mapping test case get FAIL and mention NIC not supported whenever complete DTS test suite ran for cavium_a063, inorder
 to make this test case as N/A, did following changes.<br>
                              1. Added cavium_a063 to support list in TestSuite_ptype_mapping.py, so that ptype_mapping test cases doesn't get fails and moves to next step.<br>
                              2. Later as I added all ptype_mapping test cases in test_case_checklist.json, ptype_mapping test cases gets skip without executing. Finally the result will be N/A instead of FAIL.<br>
                       Is this right way? Is there any other procedure to mark this test case as N/A for cavium_a063.</span><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"><o:p></o:p></span></p>
<p class="MsoNormal"><b><i><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">[Lijuan] it’s the right way to leverage item 2 to skip the test cases if your NIC not support them. Cavium_a063 does not support ptype mapping, so it should
 not be added in the support list in TestSuite_ptype_mapping.py, that’s why you get failure. If the cases don’t be added in checklist, it will go to test cases which including the verify statement, otherwise it will skip the test cases.<o:p></o:p></span></i></b></p>
<p class="MsoNormal"><b><i><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">That’s why you get what you want when you tried item 2, but it doesn’t mean we could use item 1 improperly. Remove item 1 and keep item 2 is suitable for
 your purpose.<o:p></o:p></span></i></b></p>
</div>
<p class="MsoNormal" style="margin-bottom:12.0pt"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:black">>              'ptype mapping test can not support %s nic' % self.nic)<br>
>          ports = self.dut.get_ports()<br>
>          self.verify(len(ports) >= 1, "Insufficient ports for testing")<br>
> --<br>
> 1.8.3.1<o:p></o:p></span></p>
</div>
</div>
</div>
</div>
</div>
</div>
</body>
</html>