<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=Windows-1252"> <style type="text/css" style="display:none;"></style> </head> <body dir="ltr"> <div id="divtagdefaultwrapper" style="font-size: 12pt; color: rgb(0, 0, 0); font-family: Calibri,Helvetica,sans-serif,"EmojiFont","Apple Color Emoji","Segoe UI Emoji",NotoColorEmoji,"Segoe UI Symbol","Android Emoji",EmojiSymbols;" dir="ltr"> <div style="color: rgb(0, 0, 0);"> <hr style="display:inline-block;width:98%" tabindex="-1"> <div id="divRplyFwdMsg" dir="ltr">From: Tu, Lijuan <lijuan.tu@intel.com> Sent: Wednesday, April 24, 2019 10:01 PM To: Narala Praneeth Reddy; dts@dpdk.org Cc: Faisal Masood; Vijaya Bhaskar Annayyolla Subject: RE: [dts] [PATCH] TestSuite_ptype_mapping.py: i40 pmd specific ptype mapping is not supported for cavium_a063 <div> </div> </div> <div link="blue" vlink="purple" lang="EN-US"> <div class="x_WordSection1"> <a name="x__MailEndCompose" id="LPlnk785617" class="OWAAutoLink" previewremoved="true"> </a> <div style="border:none; border-left:solid blue 1.5pt; padding:0cm 0cm 0cm 4.0pt"> <div> <div style="border:none; border-top:solid #E1E1E1 1.0pt; padding:3.0pt 0cm 0cm 0cm"> <a name="x______replyseparator" id="LPlnk176480" class="OWAAutoLink" previewremoved="true"></a>From: Narala Praneeth Reddy [mailto:nareddy@marvell.com] Sent: Wednesday, April 24, 2019 4:27 AM To: Tu, Lijuan <lijuan.tu@intel.com>; dts@dpdk.org Cc: Faisal Masood <fmasood@marvell.com>; Vijaya Bhaskar Annayyolla <avijay@marvell.com> Subject: Re: [dts] [PATCH] TestSuite_ptype_mapping.py: i40 pmd specific ptype mapping is not supported for cavium_a063 </div> </div> <div id="x_divtagdefaultwrapper"> Please find inline comments. <div> <div class="x_MsoNormal" style="text-align:center" align="center"> <hr size="3" align="center" width="98%"> </div> <div id="x_divRplyFwdMsg"> From: Tu, Lijuan <<a href="mailto:lijuan.tu@intel.com" id="LPlnk207610" class="OWAAutoLink" previewremoved="true">lijuan.tu@intel.com</a>> Sent: Wednesday, April 24, 2019 1:10 AM To: Narala Praneeth Reddy; <a href="mailto:dts@dpdk.org" id="LPlnk973037" class="OWAAutoLink" previewremoved="true"> dts@dpdk.org</a> Cc: Faisal Masood; Vijaya Bhaskar Annayyolla Subject: [EXT] RE: [dts] [PATCH] TestSuite_ptype_mapping.py: i40 pmd specific ptype mapping is not supported for cavium_a063 <div> </div> </div> <div> <div> External Email ---------------------------------------------------------------------- > -----Original Message----- > From: dts [<a href="mailto:dts-bounces@dpdk.org" id="LPlnk299570" previewremoved="true">mailto:dts-bounces@dpdk.org</a>] On Behalf Of > <a href="mailto:nareddy@marvell.com" id="LPlnk836250" class="OWAAutoLink" previewremoved="true"> nareddy@marvell.com</a> > Sent: Monday, April 22, 2019 10:24 PM > To: <a href="mailto:dts@dpdk.org" id="LPlnk480531" class="OWAAutoLink" previewremoved="true"> dts@dpdk.org</a> > Cc: <a href="mailto:fmasood@marvell.com" id="LPlnk431230" class="OWAAutoLink" previewremoved="true"> fmasood@marvell.com</a>; <a href="mailto:avijay@marvell.com" id="LPlnk862862" class="OWAAutoLink" previewremoved="true"> avijay@marvell.com</a>; Praneeth Reddy > <<a href="mailto:nareddy@marvell.com" id="LPlnk316680" class="OWAAutoLink" previewremoved="true">nareddy@marvell.com</a>> > Subject: [dts] [PATCH] TestSuite_ptype_mapping.py: i40 pmd specific ptype > mapping is not supported for cavium_a063 > > From: Praneeth Reddy <<a href="mailto:nareddy@marvell.com" id="LPlnk645635" class="OWAAutoLink" previewremoved="true">nareddy@marvell.com</a>> > > Marking this test case as not applicable for cavium_a063 > > Signed-off-by: Praneeth Reddy <<a href="mailto:nareddy@marvell.com" id="LPlnk106661" class="OWAAutoLink" previewremoved="true">nareddy@marvell.com</a>> > --- > conf/test_case_checklist.json | 62 > +++++++++++++++++++++++++++++++++++++++- > tests/TestSuite_ptype_mapping.py | 2 +- > 2 files changed, 62 insertions(+), 2 deletions(-) > > diff --git a/conf/test_case_checklist.json b/conf/test_case_checklist.json > index a1aa90b..decc946 100644 > --- a/conf/test_case_checklist.json > +++ b/conf/test_case_checklist.json > @@ -2200,5 +2200,65 @@ > "Bug ID": "", > "Comments": "the nic not support this case" > } > - ] > + ], > + "ptype_mapping_get": [ > + { > + "OS": [ > + "ALL" > + ], > + "NIC": [ > + "cavium_a063" > + ], > + "Target": [ > + "ALL" > + ], > + "Bug ID": "", > + "Comments": "the nic not support this case" > + } > + ], > + "ptype_mapping_replace": [ > + { > + "OS": [ > + "ALL" > + ], > + "NIC": [ > + "cavium_a063" > + ], > + "Target": [ > + "ALL" > + ], > + "Bug ID": "", > + "Comments": "the nic not support this case" > + } > + ], > + "ptype_mapping_reset": [ > + { > + "OS": [ > + "ALL" > + ], > + "NIC": [ > + "cavium_a063" > + ], > + "Target": [ > + "ALL" > + ], > + "Bug ID": "", > + "Comments": "the nic not support this case" > + } > + ], > + "ptype_mapping_update": [ > + { > + "OS": [ > + "ALL" > + ], > + "NIC": [ > + "cavium_a063" > + ], > + "Target": [ > + "ALL" > + ], > + "Bug ID": "", > + "Comments": "the nic not support this case" > + } > + ] > } > diff --git a/tests/TestSuite_ptype_mapping.py > b/tests/TestSuite_ptype_mapping.py > index 2771337..6e1fce1 100644 > --- a/tests/TestSuite_ptype_mapping.py > +++ b/tests/TestSuite_ptype_mapping.py > @@ -45,7 +45,7 @@ class TestPtype_Mapping(TestCase): > Run at the start of each test suite. > """ > self.verify(self.nic in ['fortville_eagle', 'fortville_spirit', > - 'fortville_spirit_single', 'fortville_25g'], > + 'fortville_spirit_single', 'fortville_25g', 'cavium_a063'], [Lijuan] The NIC in the list above means support these cases. But from other context, Cavium_a063 does not support ptype mapping, Did I miss anything? <div> [Praneeth] ptype_mapping test case get FAIL and mention NIC not supported whenever complete DTS test suite ran for cavium_a063, inorder to make this test case as N/A, did following changes. 1. Added cavium_a063 to support list in TestSuite_ptype_mapping.py, so that ptype_mapping test cases doesn't get fails and moves to next step. 2. Later as I added all ptype_mapping test cases in test_case_checklist.json, ptype_mapping test cases gets skip without executing. Finally the result will be N/A instead of FAIL. Is this right way? Is there any other procedure to mark this test case as N/A for cavium_a063. [Lijuan] it�s the right way to leverage item 2 to skip the test cases if your NIC not support them. Cavium_a063 does not support ptype mapping, so it should not be added in the support list in TestSuite_ptype_mapping.py, that�s why you get failure. If the cases don�t be added in checklist, it will go to test cases which including the verify statement, otherwise it will skip the test cases. That�s why you get what you want when you tried item 2, but it doesn�t mean we could use item 1 improperly. Remove item 1 and keep item 2 is suitable for your purpose. [Praneeth] Ok thanks, for not supported test cases we will skip the test case. </div> > 'ptype mapping test can not support %s nic' % self.nic) > ports = self.dut.get_ports() > self.verify(len(ports) >= 1, "Insufficient ports for testing") > -- > 1.8.3.1 </div> </div> </div> </div> </div> </div> </div> </div> </div> </body> </html>