<div dir="ltr">My apologies about the formatting, gmail wasn't playing nice with sending the patch as a thread. </div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Jun 29, 2020 at 11:59 AM Owen Hilyard <<a href="mailto:ohilyard@iol.unh.edu">ohilyard@iol.unh.edu</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">add a test case which tries to set the mtu to several invalid values<br>
add documented for aformentioned test case.<br>
<br>
Signed-off-by: Owen Hilyard <<a href="mailto:ohilyard@iol.unh.edu" target="_blank">ohilyard@iol.unh.edu</a>><br>
---<br>
test_plans/mtu_update_test_plan.rst | 6 ++++<br>
tests/TestSuite_mtu_update.py | 43 ++++++++++++++++++++---------<br>
2 files changed, 36 insertions(+), 13 deletions(-)<br>
<br>
diff --git a/test_plans/mtu_update_test_plan.rst b/test_plans/mtu_update_test_plan.rst<br>
index b62ec15..70e5c04 100644<br>
--- a/test_plans/mtu_update_test_plan.rst<br>
+++ b/test_plans/mtu_update_test_plan.rst<br>
@@ -152,3 +152,9 @@ Send a packet with size 1600 bytes ::<br>
############################################################################<br>
<br>
Verify that TX-bytes on port 0 and RX-bytes on port 1 are 1500<br>
+<br>
+Test Case: MTU Checks Invalid Values<br>
+=====================================<br>
+This test case consists of attempting to set the MTU of ports to invalid<br>
+values through TestPmd. Values include the range [0, 63], -1, 2 ^ 128,<br>
+strings_should't_work, 1.2, a null character and 10000.<br>
diff --git a/tests/TestSuite_mtu_update.py b/tests/TestSuite_mtu_update.py<br>
index 6e425dc..0547494 100644<br>
--- a/tests/TestSuite_mtu_update.py<br>
+++ b/tests/TestSuite_mtu_update.py<br>
@@ -34,25 +34,14 @@<br>
DPDK Test suite.<br>
MTU Checks example.<br>
"""<br>
-import os<br>
-import subprocess<br>
from time import sleep<br>
-from typing import List, Tuple<br>
+from typing import Tuple<br>
<br>
-import utils<br>
from pmd_output import PmdOutput<br>
-from test_case import TestCase<br>
-<br>
-from pktgen_base import TRANSMIT_S_BURST<br>
<br>
import utils<br>
-import re<br>
import time<br>
from test_case import TestCase<br>
-from pktgen import TRANSMIT_CONT<br>
-<br>
-from framework.packet import Packet<br>
-from framework.settings import HEADER_SIZE<br>
<br>
ETHER_HEADER_LEN = 18<br>
IP_HEADER_LEN = 20<br>
@@ -112,7 +101,6 @@ class TestMtuUpdate(TestCase):<br>
f'Ether(dst=dutmac, src="52:00:00:00:00:00")/IP()/Raw(load="\x50"*{padding})')<br>
return out<br>
<br>
-<br>
def send_packet_of_size_to_tx_port(self, pktsize, received=True):<br>
"""<br>
Send 1 packet to portid<br>
@@ -185,6 +173,12 @@ class TestMtuUpdate(TestCase):<br>
clear up.<br>
"""<br>
self.dut.kill_all()<br>
+ self.pmdout.start_testpmd("Default")<br>
+ self.exec("port stop all")<br>
+ for port in self.dut_ports:<br>
+ self.exec(f"port config mtu {port} 1500")<br>
+ self.exec("port start all")<br>
+ self.pmdout.quit()<br>
<br>
def admin_tester_port(self, local_port, status):<br>
"""<br>
@@ -208,6 +202,7 @@ class TestMtuUpdate(TestCase):<br>
@return: None<br>
"""<br>
self.admin_tester_port(self.tester.get_local_port(self.tx_port), f"mtu {mtu:d}")<br>
+<br>
#<br>
#<br>
#<br>
@@ -264,3 +259,25 @@ class TestMtuUpdate(TestCase):<br>
then being sent packets of size 8999 and 9000.<br>
"""<br>
self.helper_test_mut_checks(9000)<br>
+<br>
+ def test_mtu_checks_invalid_values(self):<br>
+ """<br>
+ Checks that invalid arguments are rejected.<br>
+ """<br>
+ self.pmdout.start_testpmd("Default")<br>
+ self.exec("port stop all")<br>
+ for port in self.dut_ports:<br>
+ self.exec(f"port config mtu {port} 1500")<br>
+ for invalid_arg in -1, 2 ** 128, "strings_should't_work", 1.2, '\0':<br>
+ self.verify("Bad arguments" in self.exec(f"port config mtu {port :d} {invalid_arg}"),<br>
+ f"MTU {invalid_arg} was accepted when it shouldn't have been.")<br>
+ mtu: int = int(self.pmdout.get_detail_from_port_info("MTU: ", "\d+", port))<br>
+ for to_low_arg in range(0, 64):<br>
+ self.verify("mtu cannot be less than 64" in self.exec(f"port config mtu {port :d} {to_low_arg}"),<br>
+ f"MTU {to_low_arg} was accepted when it shouldn't have been.")<br>
+ # Check 10000, which should barely be to high for most NICS<br>
+ self.verify("is not in valid range" in self.exec(f"port config mtu {port :d} 10000"),<br>
+ f"MTU 10000 was accepted when it shouldn't have been.")<br>
+<br>
+ self.exec("port start all")<br>
+ self.pmdout.quit()<br>
-- <br>
2.25.1<br>
<br>
</blockquote></div>