<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"> <head> <meta http-equiv="Content-Type" content="text/html; charset=utf-8"> <meta name="Generator" content="Microsoft Word 15 (filtered medium)"> <style></style> </head> <body lang="EN-US" link="blue" vlink="purple"> <div class="WordSection1"> <p class="MsoNormal">Hi Owen,<o:p></o:p></p> <p class="MsoNormal"><o:p> </o:p></p> <p class="MsoNormal">Reduce the number of invocations is a good idea, and your design is more perfect for a common case. But we still need to consider the boundary, the minimum and the maximum queue number. I really suggest we might get a random number from the minimum, maximum, and normal queue number, if then invocation is reduced, besides boundary checking is covered. Definitely we will run test for a long time not only once.<o:p></o:p></p> <p class="MsoNormal"><o:p> </o:p></p> <p class="MsoNormal">thanks<o:p></o:p></p> <p class="MsoNormal"><o:p> </o:p></p> <div style="border:none;border-left:solid blue 1.5pt;padding:0cm 0cm 0cm 4.0pt"> <div> <div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm"> <p class="MsoNormal"><b>From:</b> dts <dts-bounces@dpdk.org> <b>On Behalf Of </b> Owen Hilyard<br> <b>Sent:</b> 2020<span lang="ZH-CN" style="font-family:"Microsoft YaHei",sans-serif">年</span>9<span lang="ZH-CN" style="font-family:"Microsoft YaHei",sans-serif">月</span>3<span lang="ZH-CN" style="font-family:"Microsoft YaHei",sans-serif">日</span> 2:42<br> <b>To:</b> Ma, LihongX <lihongx.ma@intel.com><br> <b>Cc:</b> dts@dpdk.org; Zhang, Yuwei1 <yuwei1.zhang@intel.com>; changqingx.wu@intel.com; Xiao, QimaiX <qimaix.xiao@intel.com>; Hunt, David <david.hunt@intel.com>; lylavoie@iol.unh.edu<br> <b>Subject:</b> Re: [dts] [PATCH] rx interrupt: Fixed test case<o:p></o:p></p> </div> </div> <p class="MsoNormal"><o:p> </o:p></p> <div> <p class="MsoNormal" style="margin-bottom:12.0pt">Hello<o:p></o:p></p> <div> <p class="MsoNormal">I'm able to see a material difference between what I've suggested and what the prior test case did. I was attempting to reduce the number of invocations of a pmd during the test, since those invocations are time consuming and, from what I measured, made up the majority of the runtime of the test. Is there a reason why all queues and port's can't be opened at the same time and then ignored until they are needed? The way I re-did the configs was designed to create all possible combinations of settings in the format that was originally there. Are all 3 invocations of the pmd needed or is it possible to merge those and throw out my other changes? Most of my changes were done because I was already planning on submitting a patch to remove the extra invocations and aren't as important. <br> <br> Thanks for your help<o:p></o:p></p> </div> <div> <p class="MsoNormal">Owen<o:p></o:p></p> </div> </div> <p class="MsoNormal"><o:p> </o:p></p> <div> <div> <p class="MsoNormal">On Tue, Sep 1, 2020 at 10:02 PM Ma, LihongX <<a href="mailto:lihongx.ma@intel.com">lihongx.ma@intel.com</a>> wrote:<o:p></o:p></p> </div> <blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0cm 0cm 0cm 6.0pt;margin-left:4.8pt;margin-right:0cm"> <p class="MsoNormal" style="margin-bottom:12.0pt">Hi, Owen<br> I think the change of the plan is not make sense, the case ' PF interrupt pmd with different queue' is want to test the interrupt on different queue,<br> The original case will test the queue on min number, max number and normal number(between minimum and maximum), but your patch will only test one situation.<br> <br> <br> Regards,<br> Ma,lihong<br> <br> > -----Original Message-----<br> > From: dts <<a href="mailto:dts-bounces@dpdk.org" target="_blank">dts-bounces@dpdk.org</a>> On Behalf Of Owen Hilyard<br> > Sent: Wednesday, August 26, 2020 11:04 PM<br> > To: <a href="mailto:dts@dpdk.org" target="_blank">dts@dpdk.org</a><br> > Cc: Zhang, Yuwei1 <<a href="mailto:yuwei1.zhang@intel.com" target="_blank">yuwei1.zhang@intel.com</a>>; <a href="mailto:changqingx.wu@intel.com" target="_blank">changqingx.wu@intel.com</a>; Xiao,<br> > QimaiX <<a href="mailto:qimaix.xiao@intel.com" target="_blank">qimaix.xiao@intel.com</a>>; Hunt, David <<a href="mailto:david.hunt@intel.com" target="_blank">david.hunt@intel.com</a>>;<br> > <a href="mailto:lylavoie@iol.unh.edu" target="_blank">lylavoie@iol.unh.edu</a>; Owen Hilyard <<a href="mailto:ohilyard@iol.unh.edu" target="_blank">ohilyard@iol.unh.edu</a>><br> > Subject: [dts] [PATCH] rx interrupt: Fixed test case<br> > <br> > fixed test case issues with eal params<br> > removed extra instances of l3fwd-power<br> > <br> > Signed-off-by: Owen Hilyard <<a href="mailto:ohilyard@iol.unh.edu" target="_blank">ohilyard@iol.unh.edu</a>><br> > ---<br> > test_plans/interrupt_pmd_test_plan.rst | 58 +++++++++-----------<br> > tests/TestSuite_interrupt_pmd.py | 73 ++++++++++++++------------<br> > 2 files changed, 64 insertions(+), 67 deletions(-)<br> > <br> > diff --git a/test_plans/interrupt_pmd_test_plan.rst<br> > b/test_plans/interrupt_pmd_test_plan.rst<br> > index cb8b2f1..1f8816d 100644<br> > --- a/test_plans/interrupt_pmd_test_plan.rst<br> > +++ b/test_plans/interrupt_pmd_test_plan.rst<o:p></o:p></p> </blockquote> </div> </div> </div> </body> </html>