<div dir="ltr"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">-        build_type = load_global_setting(HOST_BUILD_TYPE_SETTING)<br>-        set_build_options = getattr(self, 'set_build_options_%s' % (build_type))<br>+        set_build_options = getattr(self, 'set_build_options_meson')<br>         set_build_options(config_parms, config_file)<br></blockquote><div><br></div><div>It seems like this could just be:<br><br><font face="monospace">set_build_options_meson(config_parms, config_file)</font> </div><div><br></div><div>That avoids using reflection to get the function and is much easer to read in my opinion<br><br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> build_install_dpdk = getattr(self, 'build_install_dpdk_%s_meson' % self.get_os_type())</blockquote><div><br></div><div>While changes are being made here, could you convert this to use a chain of if statements? <br><br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> build_dpdk_apps = getattr(self, 'build_dpdk_apps_%s_meson' % self.get_os_type())</blockquote><div><br></div><div>Same as the last one.  </div></div></div><div></div></div></div>