[spp] [PATCH 12/57] spp_vf: fix compiler warning in command_proc.c

x-fn-spp at sl.ntt-tx.co.jp x-fn-spp at sl.ntt-tx.co.jp
Thu Dec 28 05:55:19 CET 2017


From: Hiroyuki Nakamura <nakamura.hioryuki at po.ntt-tx.co.jp>

* Fix type unmatch.
* Refactor log.

Signed-off-by: Daiki Yamashita <yamashita.daiki.z01 at as.ntt-tx.co.jp>
Signed-off-by: Yasufum Ogawa <ogawa.yasufumi at lab.ntt.co.jp>
---
 src/vf/command_proc.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/src/vf/command_proc.c b/src/vf/command_proc.c
index 7a5ed56..d203857 100644
--- a/src/vf/command_proc.c
+++ b/src/vf/command_proc.c
@@ -540,17 +540,19 @@ decode_request(struct request *request, const char *request_str, size_t request_
 
 	/* parse json string */
 	top_obj = json_loadb(request_str, request_str_len, 0, &json_error);
-	if (unlikely(*top_obj == NULL)) {
+	if (unlikely(top_obj == NULL)) {
 		RTE_LOG(ERR, SPP_COMMAND_PROC, "Cannot parse command request. "
 				"error=%s, request_str=%.*s\n", 
-				json_error.text, request_str_len, request_str);
+				json_error.text, (int)request_str_len, request_str);
 		return -1;
 	}
 
 	/* decode request object */
 	ret = decode_json_object(request, top_obj, DECODERULE_REQUEST);
 	if (unlikely(ret != 0)) {
-		// TODO:エラー
+		RTE_LOG(ERR, SPP_COMMAND_PROC, "Cannot decode command request. "
+				"ret=%d, request_str=%.*s\n", 
+				ret, (int)request_str_len, request_str);
 		return -1;
 	}
 
@@ -597,7 +599,7 @@ process_request(const char *request_str, size_t request_str_len)
 	struct request request;
 
 	RTE_LOG(DEBUG, SPP_COMMAND_PROC, "Receive command request. "
-			"request_str=%.*s\n", request_str_len, request_str);
+			"request_str=%.*s\n", (int)request_str_len, request_str);
 
 	memset(&request, 0, sizeof(struct request));
 
-- 
1.9.1



More information about the spp mailing list