[spp] [spp 02168] Re: [PATCH 02/57] spp_vf: support multi process

Nakamura Hioryuki nakamura.hiroyuki at po.ntt-tx.co.jp
Thu Feb 8 07:44:29 CET 2018


> On 12/28/2017 4:55 AM, x-fn-spp at sl.ntt-tx.co.jp wrote:
> > From: Hiroyuki Nakamura <nakamura.hioryuki at po.ntt-tx.co.jp>
> > 
> > spp_vf was only a single process so far, but spp_vf supported
> > multi process. Following modification has been made.
> > 
> > * Change naming machanism to allow hashtable on shared memory
> >   to be operated by multiple processes.
> > * Get config file path from command line argument.
> > 
> > And following modification has been made.
> > * Modify comment.
> > * Add and modify log message.
> > * Add function to remove vhost socket file.
> > 
> > Signed-off-by: Daiki Yamashita <yamashita.daiki.z01 at as.ntt-tx.co.jp>
> > Signed-off-by: Yasufum Ogawa <ogawa.yasufumi at lab.ntt.co.jp>
> 
<snip>
> 
> Would you mind translating comments to English. It helps if code understood by
> more people.


All the comment of latest code on http://dpdk.org/git/apps/spp has
already been translated to English. 

> > +
> > +		/* Set log level  */
> > +		rte_log_set_global_level(RTE_LOG_LEVEL);
> 
> Hi Daiki, Yasufum,
> 
> This breaks the build with dpdk master because RTE_LOG_LEVEL removed in this
> release.
> 
> Can you please check this?

We've sent a patch,
[PATCH 9/9] spp_vf: change log level setting

This will enable spp_vf to build on dpdk master.

Thanks,

-- 
Nakamura Hioryuki <nakamua.hiroyuki at po.ntt-tx.co.jp>
-- 
Nakamura Hioryuki <nakamua.hiroyuki at po.ntt-tx.co.jp>
NTTテクノクロス フューチャーネットワーク事業部 第一事業ユニット
〒167-0043 杉並区上荻1-2-1 インテグラルタワー 14階
TEL:03-5347-8024 FAX:03-3392-2907




More information about the spp mailing list