[spp] [PATCH 1/2] spp: update to improve usability

Ferruh Yigit ferruh.yigit at intel.com
Thu Feb 22 12:35:54 CET 2018


On 2/8/2018 3:18 PM, ogawa.yasufumi at lab.ntt.co.jp (ogawa.yasufumi at lab.ntt.co.jp)
wrote:
> From: Yasufumi Ogawa <ogawa.yasufumi at lab.ntt.co.jp>
> 
> SPP controller executes previous command if user just types enter in
> command line. It decreases usability and might cause a wrong operation.
> In addition, users cannot use empty lines in config files loaded from
> `playback` command. It also decreases maintainability.
> 
> For maintainability, it is another problem for SPP controller does not
> accept comment line from CLI (only able to use only in config file).
> User cannot record comment in 'record' command for the reason.
> 
> This patch includes following updates.
> 
> * Override emptyline() of Shell class to not repeat previous command.
> 
> * Override default() to accept comment line. To find the comment, add
>   is_comment_line() which support python and C style comment.
> 
> * Remove lower() for user's input to avoid unexpected behaviour.
> 
> Signed-off-by: Yasufumi Ogawa <ogawa.yasufumi at lab.ntt.co.jp>

Series applied to dpdk-next-net/master, thanks.


More information about the spp mailing list