[spp] [PATCH 0/2] doc:Fix error and improve document under spp_vf

Yasufumi Ogawa ogawa.yasufumi at lab.ntt.co.jp
Wed May 9 08:33:07 CEST 2018


On 2018/05/09 14:43, x-fn-spp at sl.ntt-tx.co.jp wrote:
> From: Hideyuki-Yamashita <yamashita.hideyuki at po.ntt-tx.co.jp>
> 
> Hello, this patch set fix and improve document related to spp_vf.
> 
> Hideyuki-Yamashita (2):
>    doc: Fix document error under spp_vf directory
>    doc: Improve document under spp_vf directory
Hideyuki,

Thank you for your first contribution!

I would like to review your patches. However, could you update them before because commit messages are not appripriate? You need 
to start subject from "docs: " (not "doc: ") and follow lowercase, "Fix" should be "fix" and also "Improve" should be "improve".

Could you make updated patches with version number "2" with -v option like as following example?
$ git format-patch d63ef8c -o ~/patch/ -v 2

Please refer DPDK contribution guide for details.
http://dpdk.org/doc/guides/contributing/patches.html

Thanks,
Yasufumi
> 
>   docs/guides/spp_vf/gsg/build.rst          | 53 ++++++++++++++----
>   docs/guides/spp_vf/use_cases/usecase1.rst | 89 +++++++++++++++++--------------
>   2 files changed, 91 insertions(+), 51 deletions(-)
> 


-- 
Yasufumi Ogawa
NTT Network Service Systems Labs



More information about the spp mailing list