[spp] [PATCH v3 0/2] docs:fix error and improve document under spp_vf

Yasufumi Ogawa ogawa.yasufumi at lab.ntt.co.jp
Thu May 17 06:00:14 CEST 2018


On 2018/05/16 17:49, x-fn-spp at sl.ntt-tx.co.jp wrote:
> From: Hideyuki-Yamashita <yamashita.hideyuki at po.ntt-tx.co.jp>
> 
> Hello Yasufumi-san,
> 
> I followed your guidance and made following changes on patch set:
>    1.Additionally fix typo on "unmount" and add detailed descriptions about
>      fixed errors in commit message in the first patch(0001).
>    2.Unify usage of VM_NAME.And also change description around virsh edit
>      in the second patch(0002).
> 
Thank you for revising your patches. However, commit messages of both of patches are too long.

It is noticed that "commit message should be wrapped at 72 characters" in DPDK's contribution guide, or warned from 
dpdk/devtools/checkpatches.sh if it is over 75 chars. Basically, SPP is following with DPDK's guide.
> BR,
> Hideyuki Yamashita
> 
> Hideyuki-Yamashita (2):
>    docs: fix document error under spp_vf directory
>    docs: improve document under spp_vf directory
> 
>   docs/guides/spp_vf/gsg/build.rst          | 53 ++++++++++++++----
>   docs/guides/spp_vf/use_cases/usecase1.rst | 89 +++++++++++++++++--------------
>   2 files changed, 90 insertions(+), 52 deletions(-)
> 


-- 
Yasufumi Ogawa
NTT Network Service Systems Labs



More information about the spp mailing list