[dpdk-stable] patch 'net/i40e: fix logging on VF close' has been queued to LTS release 18.11.2

Kevin Traynor ktraynor at redhat.com
Wed May 8 12:15:03 CEST 2019


Hi,

FYI, your patch has been queued to LTS release 18.11.2

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 05/13/19. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable-queue

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable-queue/commit/03f418f7f68ea6380bfbae4891f33e1c11bd01c5

Thanks.

Kevin Traynor

---
>From 03f418f7f68ea6380bfbae4891f33e1c11bd01c5 Mon Sep 17 00:00:00 2001
From: Beilei Xing <beilei.xing at intel.com>
Date: Thu, 18 Apr 2019 13:52:27 +0800
Subject: [PATCH] net/i40e: fix logging on VF close

[ upstream commit 108e9b0fec14b47127b79ef953af19cbf3b425d7 ]

When launch testpmd with VF and quit testpmd, there'll
be lots of messages "i40evf_handle_aq_msg(): Request 0
is not supported yet", which are triggered during VF
reset and VF needn't do anything. So cancel alarm handler
before VF reset to ignore the admin queue messages.

Fixes: e0e6a7f2154e ("net/i40e: cancel alarm handler at the end of closure")

Signed-off-by: Beilei Xing <beilei.xing at intel.com>
Acked-by: Qi Zhang <qi.z.zhang at intel.com>
---
 drivers/net/i40e/i40e_ethdev_vf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c
index ae0812bff..551f6fa61 100644
--- a/drivers/net/i40e/i40e_ethdev_vf.c
+++ b/drivers/net/i40e/i40e_ethdev_vf.c
@@ -2262,9 +2262,9 @@ i40evf_dev_close(struct rte_eth_dev *dev)
 	i40evf_dev_promiscuous_disable(dev);
 	i40evf_dev_allmulticast_disable(dev);
+	rte_eal_alarm_cancel(i40evf_dev_alarm_handler, dev);
 
 	i40evf_reset_vf(dev);
 	i40e_shutdown_adminq(hw);
 	i40evf_disable_irq0(hw);
-	rte_eal_alarm_cancel(i40evf_dev_alarm_handler, dev);
 	hw->adapter_closed = 1;
 }
-- 
2.20.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2019-05-08 11:05:06.901587277 +0100
+++ 0021-net-i40e-fix-logging-on-VF-close.patch	2019-05-08 11:05:05.801933347 +0100
@@ -1 +1 @@
-From 108e9b0fec14b47127b79ef953af19cbf3b425d7 Mon Sep 17 00:00:00 2001
+From 03f418f7f68ea6380bfbae4891f33e1c11bd01c5 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 108e9b0fec14b47127b79ef953af19cbf3b425d7 ]
+
@@ -13 +14,0 @@
-Cc: stable at dpdk.org
@@ -22 +23 @@
-index 87c45f278..a34897293 100644
+index ae0812bff..551f6fa61 100644
@@ -25 +26 @@
-@@ -2325,9 +2325,9 @@ i40evf_dev_close(struct rte_eth_dev *dev)
+@@ -2262,9 +2262,9 @@ i40evf_dev_close(struct rte_eth_dev *dev)


More information about the stable mailing list