[dpdk-stable] [DPDK] net/i40e: fix error when create two RSS flow rule

wei zhao wei.zhao1 at intel.com
Thu May 9 04:42:50 CEST 2019


There is need to refuse to create the second RSS flow rule
as only one RSS key and HASH register for each PF port.
Users should delete the first rule before setup the second
rule.

Fixes: ecad87d22383 ("net/i40e: move RSS to flow API")
Cc: stable at dpdk.org

Signed-off-by: Wei Zhao <wei.zhao1 at intel.com>
---
 drivers/net/i40e/i40e_flow.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c
index 5447e4e..68c1d43 100644
--- a/drivers/net/i40e/i40e_flow.c
+++ b/drivers/net/i40e/i40e_flow.c
@@ -4444,6 +4444,14 @@ i40e_flow_parse_rss_action(struct rte_eth_dev *dev,
 		}
 	}
 
+	if (rss_info->conf.queue_num) {
+			rte_flow_error_set(error, EINVAL,
+					  RTE_FLOW_ERROR_TYPE_ACTION,
+					  act,
+					  "rss only allow one valid rule");
+			   return -rte_errno;
+	}
+
 	/* Parse RSS related parameters from configuration */
 	if (rss->func != RTE_ETH_HASH_FUNCTION_DEFAULT)
 		return rte_flow_error_set
-- 
2.7.5



More information about the stable mailing list