[dpdk-stable] [dpdk-dev] [PATCH] net/virtio: remove useless check on mempool

Jens Freimann jfreimann at redhat.com
Thu May 9 15:29:01 CEST 2019


On Thu, May 09, 2019 at 10:03:48AM +0200, David Marchand wrote:
>This .rx_queue_setup devop is called after ethdev already dereferenced
>the mempool pointer.
>No need to check and we can remove this rte_exit.
>
>Fixes: 48cec290a3d2 ("net/virtio: move queue configure code to proper place")
>Cc: stable at dpdk.org
>
>Signed-off-by: David Marchand <david.marchand at redhat.com>

Agree, the pointer is accessed before in the caller. That said, afaics the
pointer is never checked in rte_eth_rx_queue_setup() before it's
dereferenced...

Reviewed-by: Jens Freimann <jfreimann at redhat.com> 


More information about the stable mailing list