[dpdk-stable] patch 'crypto/octeontx2: fix IPsec session member overlap' has been queued to stable release 20.11.3
luca.boccassi at gmail.com
luca.boccassi at gmail.com
Mon Jul 26 15:52:42 CEST 2021
Hi,
FYI, your patch has been queued to stable release 20.11.3
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 07/28/21. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://github.com/bluca/dpdk-stable
This queued commit can be viewed at:
https://github.com/bluca/dpdk-stable/commit/48181d181df0629486f3b7428286fb5b21041d07
Thanks.
Luca Boccassi
---
>From 48181d181df0629486f3b7428286fb5b21041d07 Mon Sep 17 00:00:00 2001
From: Anoob Joseph <anoobj at marvell.com>
Date: Tue, 13 Jul 2021 15:57:06 +0530
Subject: [PATCH] crypto/octeontx2: fix IPsec session member overlap
[ upstream commit 40beec4bf4e37327437dbcf0e9991a48ed369848 ]
The member 'dir' should not overlap with 'ip'. Usage of union for all
members would mean dir would get corrupt.
Fixes: e91b4f45ff54 ("net/octeontx2: support anti-replay for security session")
Signed-off-by: Anoob Joseph <anoobj at marvell.com>
Acked-by: Akhil Goyal <gakhil at marvell.com>
---
drivers/crypto/octeontx2/otx2_security.h | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/crypto/octeontx2/otx2_security.h b/drivers/crypto/octeontx2/otx2_security.h
index 33d3b15155..7087ea33c7 100644
--- a/drivers/crypto/octeontx2/otx2_security.h
+++ b/drivers/crypto/octeontx2/otx2_security.h
@@ -19,14 +19,16 @@
#define OTX2_SEC_AES_GCM_ROUNDUP_BYTE_LEN 4
#define OTX2_SEC_AES_CBC_ROUNDUP_BYTE_LEN 16
-union otx2_sec_session_ipsec {
- struct otx2_sec_session_ipsec_ip ip;
- struct otx2_sec_session_ipsec_lp lp;
+struct otx2_sec_session_ipsec {
+ union {
+ struct otx2_sec_session_ipsec_ip ip;
+ struct otx2_sec_session_ipsec_lp lp;
+ };
enum rte_security_ipsec_sa_direction dir;
};
struct otx2_sec_session {
- union otx2_sec_session_ipsec ipsec;
+ struct otx2_sec_session_ipsec ipsec;
void *userdata;
/**< Userdata registered by the application */
} __rte_cache_aligned;
--
2.30.2
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2021-07-26 13:53:16.865873368 +0100
+++ 0019-crypto-octeontx2-fix-IPsec-session-member-overlap.patch 2021-07-26 13:53:15.833292286 +0100
@@ -1 +1 @@
-From 40beec4bf4e37327437dbcf0e9991a48ed369848 Mon Sep 17 00:00:00 2001
+From 48181d181df0629486f3b7428286fb5b21041d07 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 40beec4bf4e37327437dbcf0e9991a48ed369848 ]
+
@@ -10 +11,0 @@
-Cc: stable at dpdk.org
@@ -19 +20 @@
-index 9f1ba71b46..29c8fc351b 100644
+index 33d3b15155..7087ea33c7 100644
@@ -22 +23 @@
-@@ -20,14 +20,16 @@
+@@ -19,14 +19,16 @@
More information about the stable
mailing list