[dpdk-stable] [PATCH 0/7] Do not change build/link behavior on stable release

Christian Ehrhardt christian.ehrhardt at canonical.com
Mon Mar 22 12:21:28 CET 2021


Hi,
most of you have been on CC on the discussion around this already.
Background:
http://mails.dpdk.org/archives/stable/2021-March/029418.html

Summary:
- changes to DPDK linking were proposed to stable @19.11.4 and
  identified to be bad
- in the 19.11.6 time-frame the responses were ok so they were
  accepted in there
- but the old issue still exists and e.g. OVS is non-buildable vs
  DPDK >=19.11.6
- IMHO an upgrade of 19.11.x should not break how linking is done
- But, OTOH one can now say "upgrading from 19.11.6 -> 19.11.8 this
  changes"

I'm unsure if this is worth an early 19.11.8 or maybe just
pushing it to git and an entry in the known-issues for 19.11.7?
But before we bike-shed over that let us discuss and agree if
taking those changes out of the 19.11.x release is the right
approach.


Christian Ehrhardt (7):
  Revert "Revert "Revert "build/pkg-config: prevent overlinking"""
  Revert "Revert "Revert "build/pkg-config: improve static linking
    flags"""
  Revert "Revert "Revert "build/pkg-config: output drivers first for
    static build"""
  Revert "Revert "Revert "build/pkg-config: move pkg-config file
    creation"""
  Revert "Revert "Revert "build: always link whole DPDK static
    libraries"""
  Revert "Revert "Revert "devtools: test static linkage with
    pkg-config"""
  Regenerate meson.build changes required due to reverts

 MAINTAINERS                                   |  2 -
 app/test/meson.build                          |  2 +-
 buildtools/pkg-config/meson.build             | 59 -------------------
 .../pkg-config/set-static-linker-flags.py     | 38 ------------
 devtools/test-meson-builds.sh                 |  2 +-
 doc/build-sdk-meson.txt                       |  2 +-
 drivers/meson.build                           |  2 +-
 examples/bbdev_app/Makefile                   |  2 +-
 examples/bond/Makefile                        |  2 +-
 examples/cmdline/Makefile                     |  2 +-
 examples/distributor/Makefile                 |  2 +-
 examples/eventdev_pipeline/Makefile           |  2 +-
 examples/fips_validation/Makefile             |  2 +-
 examples/flow_classify/Makefile               |  2 +-
 examples/flow_filtering/Makefile              |  2 +-
 examples/helloworld/Makefile                  |  2 +-
 examples/ioat/Makefile                        |  2 +-
 examples/ip_fragmentation/Makefile            |  2 +-
 examples/ip_pipeline/Makefile                 |  2 +-
 examples/ip_reassembly/Makefile               |  2 +-
 examples/ipsec-secgw/Makefile                 |  2 +-
 examples/ipv4_multicast/Makefile              |  2 +-
 examples/kni/Makefile                         |  2 +-
 examples/l2fwd-cat/Makefile                   |  2 +-
 examples/l2fwd-crypto/Makefile                |  2 +-
 examples/l2fwd-event/Makefile                 |  2 +-
 examples/l2fwd-jobstats/Makefile              |  2 +-
 examples/l2fwd-keepalive/Makefile             |  2 +-
 examples/l2fwd/Makefile                       |  2 +-
 examples/l3fwd-acl/Makefile                   |  2 +-
 examples/l3fwd-power/Makefile                 |  2 +-
 examples/l3fwd/Makefile                       |  2 +-
 examples/link_status_interrupt/Makefile       |  2 +-
 examples/meson.build                          |  6 +-
 examples/ntb/Makefile                         |  2 +-
 examples/packet_ordering/Makefile             |  2 +-
 examples/ptpclient/Makefile                   |  2 +-
 examples/qos_meter/Makefile                   |  2 +-
 examples/qos_sched/Makefile                   |  2 +-
 examples/rxtx_callbacks/Makefile              |  2 +-
 examples/service_cores/Makefile               |  2 +-
 examples/skeleton/Makefile                    |  2 +-
 examples/tep_termination/Makefile             |  2 +-
 examples/timer/Makefile                       |  2 +-
 examples/vdpa/Makefile                        |  2 +-
 examples/vhost/Makefile                       |  2 +-
 examples/vhost_blk/Makefile                   |  2 +-
 examples/vhost_crypto/Makefile                |  2 +-
 examples/vmdq/Makefile                        |  2 +-
 examples/vmdq_dcb/Makefile                    |  2 +-
 lib/meson.build                               |  2 +-
 meson.build                                   | 30 +++++++++-
 52 files changed, 78 insertions(+), 151 deletions(-)
 delete mode 100644 buildtools/pkg-config/meson.build
 delete mode 100644 buildtools/pkg-config/set-static-linker-flags.py

-- 
2.30.0



More information about the stable mailing list