[dpdk-stable] patch 'app/testpmd: check MAC address query' has been queued to stable release 20.11.2
Xueming Li
xuemingl at nvidia.com
Mon May 10 18:00:10 CEST 2021
Hi,
FYI, your patch has been queued to stable release 20.11.2
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 05/12/21. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://github.com/steevenlee/dpdk
This queued commit can be viewed at:
https://github.com/steevenlee/dpdk/commit/9a7fd13201b9e6a874713ff5fa05db26f49f0ba6
Thanks.
Xueming Li <xuemingl at nvidia.com>
---
>From 9a7fd13201b9e6a874713ff5fa05db26f49f0ba6 Mon Sep 17 00:00:00 2001
From: Kalesh AP <kalesh-anakkur.purayil at broadcom.com>
Date: Tue, 16 Mar 2021 12:21:36 +0530
Subject: [PATCH] app/testpmd: check MAC address query
Cc: Luca Boccassi <bluca at debian.org>
[ upstream commit 2382a607599ec1e44594bd74175fc8ffcc260a47 ]
This patch checks return value for rte_eth_dev_info_get() in show_macs().
Coverity issue: 353629
Fixes: e1d44d0ad623 ("app/testpmd: show MAC addresses added to a port")
Signed-off-by: Kalesh AP <kalesh-anakkur.purayil at broadcom.com>
Acked-by: Xiaoyun Li <xiaoyun.li at intel.com>
Acked-by: Andrew Rybchenko <andrew.rybchenko at oktetlabs.ru>
---
app/test-pmd/config.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
index dab8afe5dd..336d3e59b1 100644
--- a/app/test-pmd/config.c
+++ b/app/test-pmd/config.c
@@ -5219,7 +5219,8 @@ show_macs(portid_t port_id)
dev = &rte_eth_devices[port_id];
- rte_eth_dev_info_get(port_id, &dev_info);
+ if (eth_dev_info_get_print_err(port_id, &dev_info))
+ return;
for (i = 0; i < dev_info.max_mac_addrs; i++) {
addr = &dev->data->mac_addrs[i];
--
2.25.1
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2021-05-10 23:59:28.240979900 +0800
+++ 0062-app-testpmd-check-MAC-address-query.patch 2021-05-10 23:59:26.410000000 +0800
@@ -1 +1 @@
-From 2382a607599ec1e44594bd74175fc8ffcc260a47 Mon Sep 17 00:00:00 2001
+From 9a7fd13201b9e6a874713ff5fa05db26f49f0ba6 Mon Sep 17 00:00:00 2001
@@ -4,0 +5,3 @@
+Cc: Luca Boccassi <bluca at debian.org>
+
+[ upstream commit 2382a607599ec1e44594bd74175fc8ffcc260a47 ]
@@ -10 +12,0 @@
-Cc: stable at dpdk.org
@@ -20 +22 @@
-index 576d5acab5..4ce75a8e73 100644
+index dab8afe5dd..336d3e59b1 100644
@@ -23 +25 @@
-@@ -4930,7 +4930,8 @@ show_macs(portid_t port_id)
+@@ -5219,7 +5219,8 @@ show_macs(portid_t port_id)
More information about the stable
mailing list