[dpdk-stable] patch 'net/hns3: remove redundant mailbox response' has been queued to stable release 20.11.2

Xueming Li xuemingl at nvidia.com
Mon May 10 18:02:46 CEST 2021


Hi,

FYI, your patch has been queued to stable release 20.11.2

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 05/12/21. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/steevenlee/dpdk

This queued commit can be viewed at:
https://github.com/steevenlee/dpdk/commit/2782c994db516427c52240bdeef260fe7d8b46be

Thanks.

Xueming Li <xuemingl at nvidia.com>

---
>From 2782c994db516427c52240bdeef260fe7d8b46be Mon Sep 17 00:00:00 2001
From: Huisong Li <lihuisong at huawei.com>
Date: Sat, 17 Apr 2021 17:54:55 +0800
Subject: [PATCH] net/hns3: remove redundant mailbox response
Cc: Luca Boccassi <bluca at debian.org>

[ upstream commit 17ff95283fa10c6f296e9008558555ead6d8a3a2 ]

Some mbx messages do not need to reply with data. In this case,
it is no need to set the response data address and the response
length.

This patch removes these redundant codes from mbx messages that do
not need be replied.

Fixes: a5475d61fa34 ("net/hns3: support VF")

Signed-off-by: Huisong Li <lihuisong at huawei.com>
Signed-off-by: Min Hu (Connor) <humin29 at huawei.com>
---
 drivers/net/hns3/hns3_ethdev_vf.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/net/hns3/hns3_ethdev_vf.c b/drivers/net/hns3/hns3_ethdev_vf.c
index ac11befa16..78e7a1bba3 100644
--- a/drivers/net/hns3/hns3_ethdev_vf.c
+++ b/drivers/net/hns3/hns3_ethdev_vf.c
@@ -1455,13 +1455,12 @@ hns3vf_set_tc_queue_mapping(struct hns3_adapter *hns, uint16_t nb_rx_q,
 static void
 hns3vf_request_link_info(struct hns3_hw *hw)
 {
-	uint8_t resp_msg;
 	int ret;
 
 	if (rte_atomic16_read(&hw->reset.resetting))
 		return;
 	ret = hns3_send_mbx_msg(hw, HNS3_MBX_GET_LINK_STATUS, 0, NULL, 0, false,
-				&resp_msg, sizeof(resp_msg));
+				NULL, 0);
 	if (ret)
 		hns3_err(hw, "Failed to fetch link status from PF: %d", ret);
 }
@@ -1657,11 +1656,10 @@ hns3vf_keep_alive_handler(void *param)
 	struct rte_eth_dev *eth_dev = (struct rte_eth_dev *)param;
 	struct hns3_adapter *hns = eth_dev->data->dev_private;
 	struct hns3_hw *hw = &hns->hw;
-	uint8_t respmsg;
 	int ret;
 
 	ret = hns3_send_mbx_msg(hw, HNS3_MBX_KEEP_ALIVE, 0, NULL, 0,
-				false, &respmsg, sizeof(uint8_t));
+				false, NULL, 0);
 	if (ret)
 		hns3_err(hw, "VF sends keeping alive cmd failed(=%d)",
 			 ret);
-- 
2.25.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2021-05-10 23:59:32.175922900 +0800
+++ 0218-net-hns3-remove-redundant-mailbox-response.patch	2021-05-10 23:59:26.690000000 +0800
@@ -1 +1 @@
-From 17ff95283fa10c6f296e9008558555ead6d8a3a2 Mon Sep 17 00:00:00 2001
+From 2782c994db516427c52240bdeef260fe7d8b46be Mon Sep 17 00:00:00 2001
@@ -4,0 +5,3 @@
+Cc: Luca Boccassi <bluca at debian.org>
+
+[ upstream commit 17ff95283fa10c6f296e9008558555ead6d8a3a2 ]
@@ -14 +16,0 @@
-Cc: stable at dpdk.org
@@ -23 +25 @@
-index e65f3c1173..065d3181c5 100644
+index ac11befa16..78e7a1bba3 100644
@@ -26 +28,2 @@
-@@ -1511,7 +1511,6 @@ static void
+@@ -1455,13 +1455,12 @@ hns3vf_set_tc_queue_mapping(struct hns3_adapter *hns, uint16_t nb_rx_q,
+ static void
@@ -29 +31,0 @@
- 	struct hns3_vf *vf = HNS3_DEV_HW_TO_VF(hw);
@@ -31 +32,0 @@
- 	bool send_req;
@@ -34 +35 @@
-@@ -1524,7 +1523,7 @@ hns3vf_request_link_info(struct hns3_hw *hw)
+ 	if (rte_atomic16_read(&hw->reset.resetting))
@@ -36 +36,0 @@
- 
@@ -40,4 +40,4 @@
- 	if (ret) {
- 		hns3_err(hw, "failed to fetch link status, ret = %d", ret);
- 		return;
-@@ -1756,11 +1755,10 @@ hns3vf_keep_alive_handler(void *param)
+ 	if (ret)
+ 		hns3_err(hw, "Failed to fetch link status from PF: %d", ret);
+ }
+@@ -1657,11 +1656,10 @@ hns3vf_keep_alive_handler(void *param)


More information about the stable mailing list