patch 'rcu: fix acked token in debug log' has been queued to stable release 23.11.1
Xueming Li
xuemingl at nvidia.com
Tue Mar 5 10:46:34 CET 2024
Hi,
FYI, your patch has been queued to stable release 23.11.1
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 03/31/24. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging
This queued commit can be viewed at:
https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=c30a4f8b3162bbe1178e79fdf476b2d65f182ea9
Thanks.
Xueming Li <xuemingl at nvidia.com>
---
>From c30a4f8b3162bbe1178e79fdf476b2d65f182ea9 Mon Sep 17 00:00:00 2001
From: Honnappa Nagarahalli <honnappa.nagarahalli at arm.com>
Date: Mon, 5 Feb 2024 04:59:49 +0000
Subject: [PATCH] rcu: fix acked token in debug log
Cc: Xueming Li <xuemingl at nvidia.com>
[ upstream commit df33fb53e464cb1efc79fa65f923aaa60ae10f42 ]
Debug print should use acked token value that was used for comparison.
Fixes: bf386ae377aa ("rcu: add additional debug logs")
Reported-by: Nathan Brown <nathan.brown at arm.com>
Signed-off-by: Honnappa Nagarahalli <honnappa.nagarahalli at arm.com>
Reviewed-by: Nathan Brown <nathan.brown at arm.com>
---
lib/rcu/rte_rcu_qsbr.h | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/lib/rcu/rte_rcu_qsbr.h b/lib/rcu/rte_rcu_qsbr.h
index 66780b324b..8bda00e911 100644
--- a/lib/rcu/rte_rcu_qsbr.h
+++ b/lib/rcu/rte_rcu_qsbr.h
@@ -664,17 +664,20 @@ __rte_rcu_qsbr_check_all(struct rte_rcu_qsbr *v, uint64_t t, bool wait)
static __rte_always_inline int
rte_rcu_qsbr_check(struct rte_rcu_qsbr *v, uint64_t t, bool wait)
{
+ uint64_t acked_token;
+
RTE_ASSERT(v != NULL);
/* Check if all the readers have already acknowledged this token */
- if (likely(t <= rte_atomic_load_explicit(&v->acked_token,
- rte_memory_order_relaxed))) {
+ acked_token = rte_atomic_load_explicit(&v->acked_token,
+ rte_memory_order_relaxed);
+ if (likely(t <= acked_token)) {
__RTE_RCU_DP_LOG(DEBUG,
"%s: check: token = %" PRIu64 ", wait = %d",
__func__, t, wait);
__RTE_RCU_DP_LOG(DEBUG,
"%s: status: least acked token = %" PRIu64,
- __func__, v->acked_token);
+ __func__, acked_token);
return 1;
}
--
2.34.1
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2024-03-05 17:39:32.576372153 +0800
+++ 0053-rcu-fix-acked-token-in-debug-log.patch 2024-03-05 17:39:30.753566492 +0800
@@ -1 +1 @@
-From df33fb53e464cb1efc79fa65f923aaa60ae10f42 Mon Sep 17 00:00:00 2001
+From c30a4f8b3162bbe1178e79fdf476b2d65f182ea9 Mon Sep 17 00:00:00 2001
@@ -4,0 +5,3 @@
+Cc: Xueming Li <xuemingl at nvidia.com>
+
+[ upstream commit df33fb53e464cb1efc79fa65f923aaa60ae10f42 ]
@@ -9 +11,0 @@
-Cc: stable at dpdk.org
@@ -19 +21 @@
-index ef1621d597..e7ef788175 100644
+index 66780b324b..8bda00e911 100644
@@ -22 +24 @@
-@@ -663,17 +663,20 @@ __rte_rcu_qsbr_check_all(struct rte_rcu_qsbr *v, uint64_t t, bool wait)
+@@ -664,17 +664,20 @@ __rte_rcu_qsbr_check_all(struct rte_rcu_qsbr *v, uint64_t t, bool wait)
More information about the stable
mailing list