[PATCH] bus/vdev: fix devargs memory leak
Thomas Monjalon
thomas at monjalon.net
Wed Mar 6 15:01:31 CET 2024
01/09/2023 09:24, Mingjin Ye:
> When a device is created by a secondary process, an empty devargs is
> temporarily generated and bound to it. This causes the device to not
> be associated with the correct devargs, and the empty devargs are not
> released when the resource is freed.
>
> This patch fixes the issue by matching the devargs when inserting a
> device in secondary process.
>
> Fixes: dda987315ca2 ("vdev: make virtual bus use its device struct")
> Fixes: a16040453968 ("eal: extract vdev infra")
> Cc: stable at dpdk.org
>
> Signed-off-by: Mingjin Ye <mingjinx.ye at intel.com>
> ---
> +static struct rte_devargs *
> +vdev_devargs_lookup(const char *name)
> +{
> + struct rte_devargs *devargs;
> + char dev_name[32];
> +
> + RTE_EAL_DEVARGS_FOREACH("vdev", devargs) {
> + devargs->bus->parse(devargs->name, &dev_name);
> + if (strcmp(dev_name, name) == 0) {
> + VDEV_LOG(INFO, "**Devargs matched %s", dev_name);
The beginning of the log does not need such attention characters.
Removing while merging.
With Acked-by: Anatoly Burakov <anatoly.burakov at intel.com>
Applied, thanks.
More information about the stable
mailing list