[PATCH 2/4] app/testpmd: fix burst option parsing
Stephen Hemminger
stephen at networkplumber.org
Wed Mar 13 17:32:13 CET 2024
On Wed, 13 Mar 2024 12:09:01 +0000
Ferruh Yigit <ferruh.yigit at amd.com> wrote:
> > Which is really close to the existing log message.
> >
> > if (rec_nb_pkts == 0)
> > rte_exit(EXIT_FAILURE,
> > "PMD does not
> > recommend a burst size. "
> > "Provided
> > value must be between "
> > "1 and %d\n",
> > MAX_PKT_BURST);
> >
> > I am unconvinced, but if you think strongly for this, I won't debate more.
> >
> >
>
> Yes it is close, and I don't have strong opinion on this,
>
> But existing message says "PMD does not recommend a burst size.", I
> think this may be confusing for user.
>
> If I see that message I would either debug relevant driver code or
> communicate with driver maintainer for it. But that is not the case,
> just failed to get recommended burst size and problem is in testpmd.
>
> Anyway, my concern is existing message can be misleading for user.
Maybe shorter:
"PMD does not provide required burst size\n"
More information about the stable
mailing list