[PATCH v5 1/6] examples/l3fwd: fix lcore ID restriction

[Tummala, Sivaprasad]

[AMD Official Use Only - General]

Hi Thomas,

> -----Original Message-----
> From: Thomas Monjalon <thomas at monjalon.net>
> Sent: Thursday, March 21, 2024 3:25 PM
> To: Tummala, Sivaprasad <Sivaprasad.Tummala at amd.com>
> Cc: david.hunt at intel.com; anatoly.burakov at intel.com; jerinj at marvell.com;
> radu.nicolau at intel.com; gakhil at marvell.com; cristian.dumitrescu at intel.com; Yigit,
> Ferruh <Ferruh.Yigit at amd.com>; konstantin.ananyev at huawei.com;
> stephen at networkplumber.org; david.marchand at redhat.com; dev at dpdk.org;
> stable at dpdk.org; Morten Brørup <mb at smartsharesystems.com>
> Subject: Re: [PATCH v5 1/6] examples/l3fwd: fix lcore ID restriction
>
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
>
>
> 19/03/2024 08:24, Morten Brørup:
> > > From: Sivaprasad Tummala [mailto:sivaprasad.tummala at amd.com]
> > > Sent: Monday, 18 March 2024 18.32
> > >
> > > Currently the config option allows lcore IDs up to 255, irrespective
> > > of RTE_MAX_LCORES and needs to be fixed.
> > >
> > > The patch allows config options based on DPDK config.
> > >
> > > Fixes: af75078fece3 ("first public release")
> > > Cc: stable at dpdk.org
> > >
> > > Signed-off-by: Sivaprasad Tummala <sivaprasad.tummala at amd.com>
> > > Acked-by: Konstantin Ananyev <konstantin.ananyev at huawei.com>
> > > ---
> >
> > I suggest you update the description of the individual patches too, like you did
> for patch 0/6.
> >
> > E.g. this patch not only fixes the lcore_id, but also the queue_id type size.
> >
> >
> > For the series,
> > Acked-by: Morten Brørup <mb at smartsharesystems.com>
>
> I would recommend a separate patch for queue id as it is a separate issue.
> However, there is no need to split per directory.
> You can have patches changing all examples at once.
>
There's a functional dependency and queue id change is required to support
higher lcore IDs and hence it makes sense to add in the same patch.
I had split the examples to help the maintainers review the patches individually.
Please feel free to squash the git commits while merging.