patch 'pdump: handle primary process exit' has been queued to stable release 24.11.4

[Kevin Traynor]

Hi,

FYI, your patch has been queued to stable release 24.11.4

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 11/26/25. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable/commit/21344e6cc36bf127fdbe82f28fea62bdd5439987

Thanks.

Kevin

---
>From 21344e6cc36bf127fdbe82f28fea62bdd5439987 Mon Sep 17 00:00:00 2001
From: Stephen Hemminger <stephen at networkplumber.org>
Date: Tue, 4 Nov 2025 10:07:05 -0800
Subject: [PATCH] pdump: handle primary process exit

[ upstream commit cefd5edce236e69496693ea0ecbf3e61434ff348 ]

If primary process exits, then it is not possible (or needed)
to cleanup resources. Instead just exit after closing the
capture file.

Bugzilla ID: 1760
Fixes: a99a311ba101 ("app/pdump: exit with primary process")
Fixes: cbb44143be74 ("app/dumpcap: add new packet capture application")

Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>
Acked-by: Bruce Richardson <bruce.richardson at intel.com>
Acked-by: Khadem Ullah <14pwcse1224 at uetpeshawar.edu.pk>
---
 app/dumpcap/main.c |  4 ++++
 app/pdump/main.c   | 12 +++++++-----
 2 files changed, 11 insertions(+), 5 deletions(-)

diff --git a/app/dumpcap/main.c b/app/dumpcap/main.c
index 3d3c0dbc66..7b19c830b5 100644
--- a/app/dumpcap/main.c
+++ b/app/dumpcap/main.c
@@ -1059,4 +1059,8 @@ int main(int argc, char **argv)
 		pcap_dump_close(out.dumper);
 
+	/* If primary has exited, do not try and communicate with it */
+	if (!rte_eal_primary_proc_alive(NULL))
+		return 0;
+
 	cleanup_pdump_resources();
 
diff --git a/app/pdump/main.c b/app/pdump/main.c
index f3ac81cb80..49bac5025e 100644
--- a/app/pdump/main.c
+++ b/app/pdump/main.c
@@ -1027,12 +1027,14 @@ main(int argc, char **argv)
 
 	disable_primary_monitor();
-	cleanup_pdump_resources();
+
 	/* dump debug stats */
 	print_pdump_stats();
 
-	ret = rte_eal_cleanup();
-	if (ret)
-		printf("Error from rte_eal_cleanup(), %d\n", ret);
+	/* If primary has exited, do not try and communicate with it */
+	if (!rte_eal_primary_proc_alive(NULL))
+		return 0;
 
-	return 0;
+	cleanup_pdump_resources();
+
+	return rte_eal_cleanup() ? EXIT_FAILURE : 0;
 }
-- 
2.51.0

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2025-11-21 11:05:11.450058105 +0000
+++ 0059-pdump-handle-primary-process-exit.patch	2025-11-21 11:05:09.536201481 +0000
@@ -1 +1 @@
-From cefd5edce236e69496693ea0ecbf3e61434ff348 Mon Sep 17 00:00:00 2001
+From 21344e6cc36bf127fdbe82f28fea62bdd5439987 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit cefd5edce236e69496693ea0ecbf3e61434ff348 ]
+
@@ -13 +14,0 @@
-Cc: stable at dpdk.org
@@ -24 +25 @@
-index e5ba36350b..3621c0ebe3 100644
+index 3d3c0dbc66..7b19c830b5 100644
@@ -27 +28 @@
-@@ -1060,4 +1060,8 @@ int main(int argc, char **argv)
+@@ -1059,4 +1059,8 @@ int main(int argc, char **argv)
@@ -37 +38 @@
-index 89347d70dc..7cbf1b8c34 100644
+index f3ac81cb80..49bac5025e 100644
@@ -40 +41 @@
-@@ -1028,12 +1028,14 @@ main(int argc, char **argv)
+@@ -1027,12 +1027,14 @@ main(int argc, char **argv)