patch 'common/mlx5: release unused mempool entries' has been queued to stable release 24.11.4
Kevin Traynor
ktraynor at redhat.com
Fri Nov 21 12:21:12 CET 2025
Hi,
FYI, your patch has been queued to stable release 24.11.4
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 11/26/25. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable
This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable/commit/94afc380af73f6b0f05f430dd07a06be6cfedb10
Thanks.
Kevin
---
>From 94afc380af73f6b0f05f430dd07a06be6cfedb10 Mon Sep 17 00:00:00 2001
From: Roi Dayan <roid at nvidia.com>
Date: Wed, 12 Nov 2025 09:41:31 +0200
Subject: [PATCH] common/mlx5: release unused mempool entries
[ upstream commit aef94343d3d0b7e11071747f0d2fd66546d7b724 ]
When creating a new mempool but assigning a shared entries
from a different mempool need to release the newly unused
allocated entries. Fix it.
Fixes: 8947eebc999e ("common/mlx5: fix shared memory region ranges allocation")
Signed-off-by: Roi Dayan <roid at nvidia.com>
Signed-off-by: Gregory Etelson <getelson at nvidia.com>
Acked-by: Suanming Mou <suanmingm at nvidia.com>
---
drivers/common/mlx5/mlx5_common_mr.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/common/mlx5/mlx5_common_mr.c b/drivers/common/mlx5/mlx5_common_mr.c
index 50922ad398..177255f308 100644
--- a/drivers/common/mlx5/mlx5_common_mr.c
+++ b/drivers/common/mlx5/mlx5_common_mr.c
@@ -1711,4 +1711,6 @@ mlx5_mr_mempool_register_primary(struct mlx5_mr_share_cache *share_cache,
*/
if (share_hugepage) {
+ struct mlx5_mempool_mr *gc_mrs = NULL;
+
rte_rwlock_write_lock(&share_cache->rwlock);
LIST_FOREACH(mpr, &share_cache->mempool_reg_list, next) {
@@ -1717,4 +1719,6 @@ mlx5_mr_mempool_register_primary(struct mlx5_mr_share_cache *share_cache,
}
if (mpr != NULL) {
+ /* Releasing MRs here can create a dead-lock on share_cache->rwlock */
+ gc_mrs = new_mpr->mrs;
new_mpr->mrs = mpr->mrs;
mlx5_mempool_reg_attach(new_mpr);
@@ -1723,4 +1727,6 @@ mlx5_mr_mempool_register_primary(struct mlx5_mr_share_cache *share_cache,
}
rte_rwlock_write_unlock(&share_cache->rwlock);
+ if (gc_mrs != NULL)
+ mlx5_free(gc_mrs);
if (mpr != NULL) {
DRV_LOG(DEBUG, "Shared MR %#x in PD %p for mempool %s with mempool %s",
--
2.51.0
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2025-11-21 11:05:12.289339217 +0000
+++ 0088-common-mlx5-release-unused-mempool-entries.patch 2025-11-21 11:05:09.591201715 +0000
@@ -1 +1 @@
-From aef94343d3d0b7e11071747f0d2fd66546d7b724 Mon Sep 17 00:00:00 2001
+From 94afc380af73f6b0f05f430dd07a06be6cfedb10 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit aef94343d3d0b7e11071747f0d2fd66546d7b724 ]
+
@@ -20 +22 @@
-index c41ffff2d5..8ed988dec9 100644
+index 50922ad398..177255f308 100644
@@ -23 +25 @@
-@@ -1718,4 +1718,6 @@ mlx5_mr_mempool_register_primary(struct mlx5_mr_share_cache *share_cache,
+@@ -1711,4 +1711,6 @@ mlx5_mr_mempool_register_primary(struct mlx5_mr_share_cache *share_cache,
@@ -30 +32 @@
-@@ -1724,4 +1726,6 @@ mlx5_mr_mempool_register_primary(struct mlx5_mr_share_cache *share_cache,
+@@ -1717,4 +1719,6 @@ mlx5_mr_mempool_register_primary(struct mlx5_mr_share_cache *share_cache,
@@ -37 +39 @@
-@@ -1730,4 +1734,6 @@ mlx5_mr_mempool_register_primary(struct mlx5_mr_share_cache *share_cache,
+@@ -1723,4 +1727,6 @@ mlx5_mr_mempool_register_primary(struct mlx5_mr_share_cache *share_cache,
More information about the stable
mailing list