patch 'app/testpmd: fix FD leak in mbuf history command parsing' has been queued to stable release 25.11.1
Kevin Traynor
ktraynor at redhat.com
Thu Mar 19 11:03:26 CET 2026
Hi,
FYI, your patch has been queued to stable release 25.11.1
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 03/23/26. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable
This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable/commit/f4d7dc995b33b1b677bda7143228b9df68ea687a
Thanks.
Kevin
---
>From f4d7dc995b33b1b677bda7143228b9df68ea687a Mon Sep 17 00:00:00 2001
From: Kevin Traynor <ktraynor at redhat.com>
Date: Thu, 12 Mar 2026 10:36:06 +0000
Subject: [PATCH] app/testpmd: fix FD leak in mbuf history command parsing
[ upstream commit f3b9adc8c02df3ba1318a276fa1646c30c6e4fcb ]
In error cases, the FD was not being closed.
Add label for error case that will close the FD.
Fixes: 1303b50a9c21 ("app/testpmd: add commands to dump mbuf history")
Signed-off-by: Kevin Traynor <ktraynor at redhat.com>
Reviewed-by: Thomas Monjalon <thomas at monjalon.net>
---
app/test-pmd/cmdline.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index 012a3ad32f..18cc358035 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -9362,5 +9362,5 @@ static void cmd_dump_mbuf_history_parsed(void *parsed_result,
"Failed to find mempool '%s'\n",
res->name);
- return;
+ goto out_close;
}
rte_mbuf_history_dump_mempool(out, mp);
@@ -9375,5 +9375,5 @@ static void cmd_dump_mbuf_history_parsed(void *parsed_result,
cmdline_printf(cl,
"Invalid mbuf pointer format. Use 0x<address>\n");
- return;
+ goto out_close;
}
mbuf = (struct rte_mbuf *)mbuf_addr;
@@ -9385,4 +9385,5 @@ static void cmd_dump_mbuf_history_parsed(void *parsed_result,
}
+out_close:
if (out != stdout)
fclose(out);
--
2.53.0
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2026-03-19 10:01:09.589201542 +0000
+++ 0088-app-testpmd-fix-FD-leak-in-mbuf-history-command-pars.patch 2026-03-19 10:01:07.138331259 +0000
@@ -1 +1 @@
-From f3b9adc8c02df3ba1318a276fa1646c30c6e4fcb Mon Sep 17 00:00:00 2001
+From f4d7dc995b33b1b677bda7143228b9df68ea687a Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit f3b9adc8c02df3ba1318a276fa1646c30c6e4fcb ]
+
@@ -11 +12,0 @@
-Cc: stable at dpdk.org
@@ -20 +21 @@
-index f8b6828dab..c5abeb5730 100644
+index 012a3ad32f..18cc358035 100644
@@ -23 +24 @@
-@@ -9424,5 +9424,5 @@ static void cmd_dump_mbuf_history_parsed(void *parsed_result,
+@@ -9362,5 +9362,5 @@ static void cmd_dump_mbuf_history_parsed(void *parsed_result,
@@ -30 +31 @@
-@@ -9437,5 +9437,5 @@ static void cmd_dump_mbuf_history_parsed(void *parsed_result,
+@@ -9375,5 +9375,5 @@ static void cmd_dump_mbuf_history_parsed(void *parsed_result,
@@ -37 +38 @@
-@@ -9447,4 +9447,5 @@ static void cmd_dump_mbuf_history_parsed(void *parsed_result,
+@@ -9385,4 +9385,5 @@ static void cmd_dump_mbuf_history_parsed(void *parsed_result,
More information about the stable
mailing list