patch 'net/tap: free IPC reply buffer on queue count mismatch' has been queued to stable release 24.11.5
luca.boccassi at gmail.com
luca.boccassi at gmail.com
Thu Mar 19 23:02:24 CET 2026
Hi,
FYI, your patch has been queued to stable release 24.11.5
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 03/21/26. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://github.com/bluca/dpdk-stable
This queued commit can be viewed at:
https://github.com/bluca/dpdk-stable/commit/46dce0f3ffba4ba12a1357bb760f8d72d7d181dc
Thanks.
Luca Boccassi
---
>From 46dce0f3ffba4ba12a1357bb760f8d72d7d181dc Mon Sep 17 00:00:00 2001
From: Stephen Hemminger <stephen at networkplumber.org>
Date: Sun, 22 Feb 2026 09:30:45 -0800
Subject: [PATCH] net/tap: free IPC reply buffer on queue count mismatch
[ upstream commit 86a3ffe64f4e2cdde9ebe9c05b737a185c77034a ]
In tap_mp_attach_queues(), if the reply queue count does not match
the number of received file descriptors, the function returns -1
without freeing the reply buffer allocated by rte_mp_request_sync().
Add the missing free().
Bugzilla ID: 1881
Fixes: 9ad43ad8fbee ("net/tap: fix potential IPC buffer overrun")
Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>
---
drivers/net/tap/rte_eth_tap.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
index ed86d80a88..a8c9f4465f 100644
--- a/drivers/net/tap/rte_eth_tap.c
+++ b/drivers/net/tap/rte_eth_tap.c
@@ -2341,6 +2341,7 @@ tap_mp_attach_queues(const char *port_name, struct rte_eth_dev *dev)
/* Attach the queues from received file descriptors */
if (reply_param->q_count != reply->num_fds) {
TAP_LOG(ERR, "Unexpected number of fds received");
+ free(reply);
return -1;
}
--
2.47.3
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2026-03-19 22:00:48.967525586 +0000
+++ 0032-net-tap-free-IPC-reply-buffer-on-queue-count-mismatc.patch 2026-03-19 22:00:47.806359366 +0000
@@ -1 +1 @@
-From 86a3ffe64f4e2cdde9ebe9c05b737a185c77034a Mon Sep 17 00:00:00 2001
+From 46dce0f3ffba4ba12a1357bb760f8d72d7d181dc Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 86a3ffe64f4e2cdde9ebe9c05b737a185c77034a ]
+
@@ -13 +14,0 @@
-Cc: stable at dpdk.org
@@ -21 +22 @@
-index 63d5ac5630..93c93cd33d 100644
+index ed86d80a88..a8c9f4465f 100644
@@ -24 +25 @@
-@@ -2374,6 +2374,7 @@ tap_mp_attach_queues(const char *port_name, struct rte_eth_dev *dev)
+@@ -2341,6 +2341,7 @@ tap_mp_attach_queues(const char *port_name, struct rte_eth_dev *dev)
More information about the stable
mailing list