patch 'test/stack: scale test based on core count' has been queued to stable release 24.11.5
luca.boccassi at gmail.com
luca.boccassi at gmail.com
Thu Mar 19 23:02:47 CET 2026
Hi,
FYI, your patch has been queued to stable release 24.11.5
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 03/21/26. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://github.com/bluca/dpdk-stable
This queued commit can be viewed at:
https://github.com/bluca/dpdk-stable/commit/89e8fc7ad8fbb1551dc821cac1f94ec390e1b78b
Thanks.
Luca Boccassi
---
>From 89e8fc7ad8fbb1551dc821cac1f94ec390e1b78b Mon Sep 17 00:00:00 2001
From: Stephen Hemminger <stephen at networkplumber.org>
Date: Thu, 5 Mar 2026 09:50:58 -0800
Subject: [PATCH] test/stack: scale test based on core count
[ upstream commit 837afbfc49c08620b9be08d7cedbada5da14027d ]
This test uses loops to synchronize but has problems on systems
with high number of cores. Scale iterations to the number of
cores.
Fixes: 5e2e61b99e91 ("test/stack: check stack API")
Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>
---
app/test/test_stack.c | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/app/test/test_stack.c b/app/test/test_stack.c
index 9150cc9fed..067d1bcdd0 100644
--- a/app/test/test_stack.c
+++ b/app/test/test_stack.c
@@ -268,10 +268,12 @@ test_free_null(void)
return 0;
}
-#define NUM_ITERS_PER_THREAD 100000
+#define NUM_ITERS_BASE 100000u
+#define NUM_ITERS_MIN 1000u
struct test_args {
struct rte_stack *s;
+ unsigned int num_iters;
};
static struct test_args thread_test_args;
@@ -280,9 +282,9 @@ static int
stack_thread_push_pop(__rte_unused void *args)
{
void *obj_table[MAX_BULK];
- int i;
+ unsigned int i;
- for (i = 0; i < NUM_ITERS_PER_THREAD; i++) {
+ for (i = 0; i < thread_test_args.num_iters; i++) {
unsigned int num;
num = rte_rand() % MAX_BULK;
@@ -308,12 +310,14 @@ test_stack_multithreaded(uint32_t flags)
{
unsigned int lcore_id;
struct rte_stack *s;
+ unsigned int iterations;
int result = 0;
if (rte_lcore_count() < 2) {
printf("Not enough cores for test_stack_multithreaded, expecting at least 2\n");
return TEST_SKIPPED;
}
+ iterations = test_scale_iterations(NUM_ITERS_BASE, NUM_ITERS_MIN);
printf("[%s():%u] Running with %u lcores\n",
__func__, __LINE__, rte_lcore_count());
@@ -325,6 +329,7 @@ test_stack_multithreaded(uint32_t flags)
return -1;
}
+ thread_test_args.num_iters = iterations;
thread_test_args.s = s;
if (rte_eal_mp_remote_launch(stack_thread_push_pop, NULL, CALL_MAIN))
--
2.47.3
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2026-03-19 22:00:49.763249994 +0000
+++ 0055-test-stack-scale-test-based-on-core-count.patch 2026-03-19 22:00:47.818359365 +0000
@@ -1 +1 @@
-From 837afbfc49c08620b9be08d7cedbada5da14027d Mon Sep 17 00:00:00 2001
+From 89e8fc7ad8fbb1551dc821cac1f94ec390e1b78b Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 837afbfc49c08620b9be08d7cedbada5da14027d ]
+
@@ -11 +12,0 @@
-Cc: stable at dpdk.org
@@ -19 +20 @@
-index abc3114729..5517982774 100644
+index 9150cc9fed..067d1bcdd0 100644
More information about the stable
mailing list