patch 'net/mlx5: fix send skew settings when using wait on time' has been queued to stable release 24.11.5
luca.boccassi at gmail.com
luca.boccassi at gmail.com
Thu Mar 26 13:57:43 CET 2026
Hi,
FYI, your patch has been queued to stable release 24.11.5
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 03/28/26. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://github.com/bluca/dpdk-stable
This queued commit can be viewed at:
https://github.com/bluca/dpdk-stable/commit/4ee58962dc717fe5b27ebfe3492b6e1c11b58cb7
Thanks.
Luca Boccassi
---
>From 4ee58962dc717fe5b27ebfe3492b6e1c11b58cb7 Mon Sep 17 00:00:00 2001
From: Viacheslav Ovsiienko <viacheslavo at nvidia.com>
Date: Fri, 20 Mar 2026 13:14:10 +0200
Subject: [PATCH] net/mlx5: fix send skew settings when using wait on time
[ upstream commit cf69152295fa8d777ea0869f3ac33b8e4f11680d ]
There are two modes to support tx send scheduling in mlx5 drivers,
using the Clock Queue and tx_pp parameter, and using the wait_on_time
hardware capability. The tx_skew devarg is applicable for both, but
in case of tx_pp=0 (that supposes wait_on_time mode is engaged
on ConnectX-7 and above), the tx_skew setting was missed (as
mlx5_txpp_create was not invoked).
Fixes: 2f5122dfc41f ("net/mlx5: configure Tx queue with send on time offload")
Signed-off-by: Viacheslav Ovsiienko <viacheslavo at nvidia.com>
Acked-by: Dariusz Sosnowski <dsosnowski at nvidia.com>
---
drivers/net/mlx5/mlx5.c | 2 ++
drivers/net/mlx5/mlx5_txpp.c | 3 ---
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c
index 5cd5cafb1b..29b1d6d693 100644
--- a/drivers/net/mlx5/mlx5.c
+++ b/drivers/net/mlx5/mlx5.c
@@ -1879,6 +1879,8 @@ mlx5_alloc_shared_dev_ctx(const struct mlx5_dev_spawn_data *spawn,
strerror(rte_errno));
goto error;
}
+ /* Used on Tx send scheduling (tx_pp=1 or wait-on-time). */
+ sh->txpp.skew = sh->config.tx_skew;
sh->refcnt = 1;
sh->max_port = spawn->max_port;
strncpy(sh->ibdev_name, mlx5_os_get_ctx_device_name(sh->cdev->ctx),
diff --git a/drivers/net/mlx5/mlx5_txpp.c b/drivers/net/mlx5/mlx5_txpp.c
index e6d3ad83e9..e9cc44a539 100644
--- a/drivers/net/mlx5/mlx5_txpp.c
+++ b/drivers/net/mlx5/mlx5_txpp.c
@@ -812,7 +812,6 @@ mlx5_txpp_create(struct mlx5_dev_ctx_shared *sh)
/* Store the requested pacing parameters. */
sh->txpp.tick = tx_pp >= 0 ? tx_pp : -tx_pp;
sh->txpp.test = !!(tx_pp < 0);
- sh->txpp.skew = sh->config.tx_skew;
sh->txpp.freq = sh->cdev->config.hca_attr.dev_freq_khz;
ret = mlx5_txpp_create_event_channel(sh);
if (ret)
@@ -838,7 +837,6 @@ exit:
mlx5_txpp_destroy_event_channel(sh);
sh->txpp.tick = 0;
sh->txpp.test = 0;
- sh->txpp.skew = 0;
}
return ret;
}
@@ -860,7 +858,6 @@ mlx5_txpp_destroy(struct mlx5_dev_ctx_shared *sh)
mlx5_txpp_destroy_event_channel(sh);
sh->txpp.tick = 0;
sh->txpp.test = 0;
- sh->txpp.skew = 0;
}
/**
--
2.47.3
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2026-03-26 12:56:33.826217344 +0000
+++ 0009-net-mlx5-fix-send-skew-settings-when-using-wait-on-t.patch 2026-03-26 12:56:33.429543574 +0000
@@ -1 +1 @@
-From cf69152295fa8d777ea0869f3ac33b8e4f11680d Mon Sep 17 00:00:00 2001
+From 4ee58962dc717fe5b27ebfe3492b6e1c11b58cb7 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit cf69152295fa8d777ea0869f3ac33b8e4f11680d ]
+
@@ -14 +15,0 @@
-Cc: stable at dpdk.org
@@ -24 +25 @@
-index e795948187..d9bc5ee197 100644
+index 5cd5cafb1b..29b1d6d693 100644
@@ -27 +28 @@
-@@ -1876,6 +1876,8 @@ mlx5_alloc_shared_dev_ctx(const struct mlx5_dev_spawn_data *spawn,
+@@ -1879,6 +1879,8 @@ mlx5_alloc_shared_dev_ctx(const struct mlx5_dev_spawn_data *spawn,
@@ -37 +38 @@
-index 0e99b58bde..9f616fd7a7 100644
+index e6d3ad83e9..e9cc44a539 100644
@@ -40 +41 @@
-@@ -823,7 +823,6 @@ mlx5_txpp_create(struct mlx5_dev_ctx_shared *sh)
+@@ -812,7 +812,6 @@ mlx5_txpp_create(struct mlx5_dev_ctx_shared *sh)
@@ -48 +49 @@
-@@ -849,7 +848,6 @@ exit:
+@@ -838,7 +837,6 @@ exit:
@@ -56 +57 @@
-@@ -871,7 +869,6 @@ mlx5_txpp_destroy(struct mlx5_dev_ctx_shared *sh)
+@@ -860,7 +858,6 @@ mlx5_txpp_destroy(struct mlx5_dev_ctx_shared *sh)
More information about the stable
mailing list