patch 'common/mlx5: fix error logging for queue modify' has been queued to stable release 24.11.5

[luca.boccassi at gmail.com]

Hi,

FYI, your patch has been queued to stable release 24.11.5

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 03/28/26. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/bluca/dpdk-stable

This queued commit can be viewed at:
https://github.com/bluca/dpdk-stable/commit/98d9baa8cd506459a4bab9d6832c3a7178584097

Thanks.

Luca Boccassi

---
>From 98d9baa8cd506459a4bab9d6832c3a7178584097 Mon Sep 17 00:00:00 2001
From: Dariusz Sosnowski <dsosnowski at nvidia.com>
Date: Tue, 24 Mar 2026 18:10:27 +0100
Subject: [PATCH] common/mlx5: fix error logging for queue modify

[ upstream commit 1855b0c11b27797431b1602156b8896341874bfd ]

Add missing verbose log of FW errors when modifying SQ and RQ.

Fixes: b0067860959d ("common/mlx5: update log for DevX general command failure")

Signed-off-by: Dariusz Sosnowski <dsosnowski at nvidia.com>
Acked-by: Viacheslav Ovsiienko <viacheslavo at nvidia.com>
---
 drivers/common/mlx5/mlx5_devx_cmds.c | 18 ++++++++----------
 1 file changed, 8 insertions(+), 10 deletions(-)

diff --git a/drivers/common/mlx5/mlx5_devx_cmds.c b/drivers/common/mlx5/mlx5_devx_cmds.c
index 3b4da3db9b..e48c910d03 100644
--- a/drivers/common/mlx5/mlx5_devx_cmds.c
+++ b/drivers/common/mlx5/mlx5_devx_cmds.c
@@ -1594,12 +1594,11 @@ mlx5_devx_cmd_modify_rq(struct mlx5_devx_obj *rq,
 	}
 	ret = mlx5_glue->devx_obj_modify(rq->obj, in, sizeof(in),
 					 out, sizeof(out));
-	if (ret) {
-		DRV_LOG(ERR, "Failed to modify RQ using DevX");
-		rte_errno = errno;
-		return -errno;
+	if (ret || MLX5_FW_STATUS(out)) {
+		DEVX_DRV_LOG(ERR, out, "RQ modify", "rq_id", rq->id);
+		return MLX5_DEVX_ERR_RC(ret);
 	}
-	return ret;
+	return 0;
 }
 
 /*
@@ -2029,12 +2028,11 @@ mlx5_devx_cmd_modify_sq(struct mlx5_devx_obj *sq,
 	MLX5_SET(sqc, sq_ctx, hairpin_peer_vhca, sq_attr->hairpin_peer_vhca);
 	ret = mlx5_glue->devx_obj_modify(sq->obj, in, sizeof(in),
 					 out, sizeof(out));
-	if (ret) {
-		DRV_LOG(ERR, "Failed to modify SQ using DevX");
-		rte_errno = errno;
-		return -rte_errno;
+	if (ret || MLX5_FW_STATUS(out)) {
+		DEVX_DRV_LOG(ERR, out, "SQ modify", "sq_id", sq->id);
+		return MLX5_DEVX_ERR_RC(ret);
 	}
-	return ret;
+	return 0;
 }
 
 /*
-- 
2.47.3

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2026-03-26 12:56:34.168285154 +0000
+++ 0018-common-mlx5-fix-error-logging-for-queue-modify.patch	2026-03-26 12:56:33.449544033 +0000
@@ -1 +1 @@
-From 1855b0c11b27797431b1602156b8896341874bfd Mon Sep 17 00:00:00 2001
+From 98d9baa8cd506459a4bab9d6832c3a7178584097 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 1855b0c11b27797431b1602156b8896341874bfd ]
+
@@ -9 +10,0 @@
-Cc: stable at dpdk.org
@@ -14,2 +15,2 @@
- drivers/common/mlx5/mlx5_devx_cmds.c | 19 ++++++++-----------
- 1 file changed, 8 insertions(+), 11 deletions(-)
+ drivers/common/mlx5/mlx5_devx_cmds.c | 18 ++++++++----------
+ 1 file changed, 8 insertions(+), 10 deletions(-)
@@ -18 +19 @@
-index d12ebf8487..d46aa045df 100644
+index 3b4da3db9b..e48c910d03 100644
@@ -21 +22 @@
-@@ -1672,13 +1672,11 @@ mlx5_devx_cmd_modify_rq(struct mlx5_devx_obj *rq,
+@@ -1594,12 +1594,11 @@ mlx5_devx_cmd_modify_rq(struct mlx5_devx_obj *rq,
@@ -25 +25,0 @@
--
@@ -39 +39 @@
-@@ -2116,12 +2114,11 @@ mlx5_devx_cmd_modify_sq(struct mlx5_devx_obj *sq,
+@@ -2029,12 +2028,11 @@ mlx5_devx_cmd_modify_sq(struct mlx5_devx_obj *sq,