patch 'rcu: fix build with MSVC' has been queued to stable release 23.11.7
Shani Peretz
shperetz at nvidia.com
Tue Mar 31 08:23:28 CEST 2026
Hi,
FYI, your patch has been queued to stable release 23.11.7
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 04/05/26. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://github.com/shanipr/dpdk-stable
This queued commit can be viewed at:
https://github.com/shanipr/dpdk-stable/commit/44205ca509a02469dc3d76e56eea7b830b69f942
Thanks.
Shani
---
>From 44205ca509a02469dc3d76e56eea7b830b69f942 Mon Sep 17 00:00:00 2001
From: Bruce Richardson <bruce.richardson at intel.com>
Date: Thu, 4 Dec 2025 11:29:02 +0000
Subject: [PATCH] rcu: fix build with MSVC
[ upstream commit d1ab1a2facf9b823bc400e573aa39381ca7b915f ]
Within GitHub actions, with MSVC 19.44.35219,
the following error can be reported:
...\rte_rcu_qsbr.h(566): error C2220:
the following warning is treated as an error
...\rte_rcu_qsbr.h(566): warning C4319:
'~': zero extending 'unsigned long' to 'uint64_t' of greater size
To fix this, replace the "1UL" with RTE_BIT64 to force a 64-bit value
on all platforms.
Fixes: 64994b56cfd7 ("rcu: add RCU library supporting QSBR mechanism")
Signed-off-by: Bruce Richardson <bruce.richardson at intel.com>
---
lib/rcu/rte_rcu_qsbr.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/rcu/rte_rcu_qsbr.h b/lib/rcu/rte_rcu_qsbr.h
index 8bda00e911..ab06690c9c 100644
--- a/lib/rcu/rte_rcu_qsbr.h
+++ b/lib/rcu/rte_rcu_qsbr.h
@@ -563,7 +563,7 @@ __rte_rcu_qsbr_check_selective(struct rte_rcu_qsbr *v, uint64_t t, bool wait)
if (c != __RTE_QSBR_CNT_THR_OFFLINE && acked_token > c)
acked_token = c;
- bmap &= ~(1UL << j);
+ bmap &= ~RTE_BIT64(j);
}
}
--
2.43.0
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2026-03-31 00:32:30.478183871 +0300
+++ 0009-rcu-fix-build-with-MSVC.patch 2026-03-31 00:32:28.444263000 +0300
@@ -1 +1 @@
-From d1ab1a2facf9b823bc400e573aa39381ca7b915f Mon Sep 17 00:00:00 2001
+From 44205ca509a02469dc3d76e56eea7b830b69f942 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit d1ab1a2facf9b823bc400e573aa39381ca7b915f ]
+
@@ -18 +19,0 @@
-Cc: stable at dpdk.org
@@ -26 +27 @@
-index 550fadf56a..d89a43c186 100644
+index 8bda00e911..ab06690c9c 100644
More information about the stable
mailing list