<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Mar 29, 2022 at 3:01 PM Ali Alnubani <<a href="mailto:alialnu@nvidia.com">alialnu@nvidia.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Use netlink.h provided by the kernel headers instead<br>
of adding a dependency on the headers provided by the libnl package,<br>
which weren't being found in some cases, even with libnl-3 and<br>
libnl-route-3 libs installed via the package manager.<br>
Also see usage in netlink(3).<br></blockquote><div><br></div><div>Thank you, indeed various other includers of netlink.h already use the kernel headers and this makes this consistent.</div><div>Applied to the WIP 19.11.12</div><div><br></div><div>Since it is only a build fix - unless someone is totally blocked on verifying 19.11.12 - this isn't forcing a new round with an -rc2.</div><div><br></div><div>I'll do a cross arch/distro rebuild test to be sure it has no unexpected side effects ...</div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
Resolves the build error:<br>
drivers/net/mlx5/mlx5.h:15:10:<br>
fatal error: netlink/netlink.h: No such file or directory<br>
The error reproduces on Ubuntu 16.04/18.04/20.04, openSUSE Leap 15.3,<br>
and CentOS 7/8. It reproduces with Make and Meson.<br>
<br>
Fixes: 7bd18f45ed47 ("common/mlx5: add Netlink event helpers")<br>
Cc: <a href="mailto:dkozlyuk@nvidia.com" target="_blank">dkozlyuk@nvidia.com</a><br>
<br>
Signed-off-by: Ali Alnubani <<a href="mailto:alialnu@nvidia.com" target="_blank">alialnu@nvidia.com</a>><br>
---<br>
drivers/net/mlx5/mlx5.h | 2 +-<br>
1 file changed, 1 insertion(+), 1 deletion(-)<br>
<br>
diff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h<br>
index 1cf5f41689..9f6b355182 100644<br>
--- a/drivers/net/mlx5/mlx5.h<br>
+++ b/drivers/net/mlx5/mlx5.h<br>
@@ -12,7 +12,7 @@<br>
#include <limits.h><br>
#include <net/if.h><br>
#include <netinet/in.h><br>
-#include <netlink/netlink.h><br>
+#include <linux/netlink.h><br>
#include <sys/queue.h><br>
<br>
/* Verbs header. */<br>
-- <br>
2.25.1<br>
<br>
</blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr" class="gmail_signature">Christian Ehrhardt<br>Staff Engineer, Ubuntu Server<br>Canonical Ltd</div></div>