<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Apr 1, 2022 at 7:29 AM Vanshika Shukla <<a href="mailto:vanshika.shukla@nxp.com">vanshika.shukla@nxp.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi,<br>
I have reviewed the issue. 4690a6114ff6993afc5c005fc340af0b1e4dbe94 commit (<a href="https://github.com/DPDK/dpdk/commit/4690a6114ff6993afc5c005fc340af0b1e4dbe94" rel="noreferrer" target="_blank">https://github.com/DPDK/dpdk/commit/4690a6114ff6993afc5c005fc340af0b1e4dbe94</a>) which is a new feature that is not required to be backported on the stable branch declares the variable that is causing issue here. I have a patch ready to fix this issue. Please confirm if I can submit the patch on <a href="mailto:stable@dpdk.org" target="_blank">stable@dpdk.org</a> mailing list?<br></blockquote><div><br></div><div>Yes you can send it there, here a copy&paste from our call for backports about the preferred style.</div><div><br></div><div>A backport should contain a reference to the DPDK main branch commit <br>in it's commit message in the following fashion: <br> [ upstream commit <commit's dpdk main branch SHA-1 checksum> ] <br> <br> For example: <br> <a href="https://git.dpdk.org/dpdk-stable/commit/?h=18.11&id=d90e6ae6f936ecdc2fd3811ff9f26aec7f3c06eb">https://git.dpdk.org/dpdk-stable/commit/?h=18.11&id=d90e6ae6f936ecdc2fd3811ff9f26aec7f3c06eb</a><br> <br> When sending the backported patch, please indicate the target branch in the <br> subject line, as we have multiple branches, for example: <br> [PATCH 20.11] foo/bar: fix baz <br> <br> With git format-patch, this can be achieved by appending the parameter: <br> --subject-prefix='PATCH 20.11' <br></div><div> </div><div>Keeping Luca on CC when submitting the patch will also help.</div><div><br></div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
Regards,<br>
Vanshika<br>
<br>
-----Original Message-----<br>
From: Luca Boccassi <<a href="mailto:bluca@debian.org" target="_blank">bluca@debian.org</a>> <br>
Sent: Thursday, 31 March 2022 5:56 pm<br>
To: dpdk stable <<a href="mailto:stable@dpdk.org" target="_blank">stable@dpdk.org</a>><br>
Cc: Vanshika Shukla <<a href="mailto:vanshika.shukla@nxp.com" target="_blank">vanshika.shukla@nxp.com</a>>; Lingli Chen <<a href="mailto:linglix.chen@intel.com" target="_blank">linglix.chen@intel.com</a>>; Hemant Agrawal <<a href="mailto:hemant.agrawal@nxp.com" target="_blank">hemant.agrawal@nxp.com</a>><br>
Subject: [EXT] Re: [PATCH 20.11 2/2] dpaa2: fix build with RTE_LIBRTE_IEEE1588<br>
<br>
Caution: EXT Email<br>
<br>
On Tue, 29 Mar 2022 at 15:11, Luca Boccassi <<a href="mailto:bluca@debian.org" target="_blank">bluca@debian.org</a>> wrote:<br>
><br>
> On Tue, 2022-03-29 at 13:09 +0100, <a href="mailto:luca.boccassi@gmail.com" target="_blank">luca.boccassi@gmail.com</a> wrote:<br>
> > From: Luca Boccassi <<a href="mailto:bluca@debian.org" target="_blank">bluca@debian.org</a>><br>
> ><br>
> > ../drivers/net/dpaa2/dpaa2_rxtx.c: In function ‘dpaa2_dev_rx’:<br>
> > ../drivers/net/dpaa2/dpaa2_rxtx.c:863:4: error: ‘priv’ undeclared (first use in this function); did you mean ‘ldiv’?<br>
> > priv->rx_timestamp =<br>
> > ^~~~<br>
> > ldiv<br>
> ><br>
> > Bugzilla ID: 982<br>
> ><br>
> > Fixes: 1d10966a22ca ("net/dpaa2: fix timestamping for IEEE1588")<br>
> ><br>
> > Signed-off-by: Luca Boccassi <<a href="mailto:bluca@debian.org" target="_blank">bluca@debian.org</a>><br>
> > ---<br>
> > drivers/net/dpaa2/dpaa2_rxtx.c | 3 +++<br>
> > 1 file changed, 3 insertions(+)<br>
> ><br>
> > diff --git a/drivers/net/dpaa2/dpaa2_rxtx.c <br>
> > b/drivers/net/dpaa2/dpaa2_rxtx.c index ecd004f9fa..23e193f86c 100644<br>
> > --- a/drivers/net/dpaa2/dpaa2_rxtx.c<br>
> > +++ b/drivers/net/dpaa2/dpaa2_rxtx.c<br>
> > @@ -772,6 +772,9 @@ dpaa2_dev_rx(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)<br>
> > const struct qbman_fd *fd;<br>
> > struct qbman_pull_desc pulldesc;<br>
> > struct rte_eth_dev_data *eth_data = dpaa2_q->eth_data;<br>
> > +#if defined(RTE_LIBRTE_IEEE1588)<br>
> > + struct dpaa2_dev_priv *priv = eth_data->dev_private; #endif<br>
> ><br>
> ><br>
> > if (unlikely(!DPAA2_PER_LCORE_DPIO)) {<br>
> > ret = dpaa2_affine_qbman_swp();<br>
><br>
> FYI Vanshika, Hemant and Lingli<br>
<br>
Ping - this is a blocker for the 20.11.5 LTS release, would it be possible to have a quick review from NXP?<br>
<br>
Thanks!<br>
</blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr" class="gmail_signature">Christian Ehrhardt<br>Staff Engineer, Ubuntu Server<br>Canonical Ltd</div></div>