<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"> <head> <meta http-equiv="Content-Type" content="text/html; charset=utf-8"> <meta name="Generator" content="Microsoft Word 15 (filtered medium)"> <style></style> </head> <body lang="EN-IE" link="blue" vlink="purple" style="word-wrap:break-word"> <div class="WordSection1"> Trying to remember now, but I believe I originally encountered the issue fixed by 12016895fc in the context of setting up runtime queue reconfiguration from commit [1]. In the absence of that new feature being backported, I assumed there was no need to backport the fix, since others had not previously reported it. Since it seems that was a mistake, we should indeed look to backport the patch in question.<o:p></o:p> <o:p> </o:p> Stable-tree maintainers, can we re-add 12016895fc to the list of backports for next point releases?<o:p></o:p> <o:p> </o:p> Regards,<o:p></o:p> /Bruce<o:p></o:p> <o:p> </o:p> [1] <a href="http://git.dpdk.org/dpdk/commit/?id=d492ea071056a8a0de2991c42daee9d9acca8e35"> http://git.dpdk.org/dpdk/commit/?id=d492ea071056a8a0de2991c42daee9d9acca8e35</a><o:p></o:p> <o:p> </o:p> PS: Link in your email is inaccessible to me, it’s perhaps a cisco-internal-only reference.<o:p></o:p> <o:p> </o:p> <div style="border:none;border-left:solid blue 1.5pt;padding:0cm 0cm 0cm 4.0pt"> <div> <div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm"> From: Chris Brezovec (cbrezove) <cbrezove@cisco.com> Sent: Monday, March 25, 2024 1:34 PM To: Richardson, Bruce <bruce.richardson@intel.com>; dpdk stable <stable@dpdk.org> Subject: Re: please help backporting some patches to stable release 20.11.10<o:p></o:p> </div> </div> <o:p> </o:p> Hey Bruce,<o:p></o:p> <o:p> </o:p> I was wondering why you thought it was ok to skip backporting 12016895fc to earlier releases?<o:p></o:p> <o:p> </o:p> It looks like I ran into this issue on v21.11and v22.11. I patched this back locally and saw that we no longer were leaking mbufs in TX queue stop with IAVF. It did not patch cleanly because <a href="https://polaris-git.cisco.com/iosxe-dpt/cisco_dpdk/commit/4f8259df563a2f754cd99fa6191c9482ce2b2201"> https://polaris-git.cisco.com/iosxe-dpt/cisco_dpdk/commit/4f8259df563a2f754cd99fa6191c9482ce2b2201</a> was not backported either.<o:p></o:p> <o:p> </o:p> It does seems like this issue exists in earlier releases though, so wondering the reasoning for not backporting.<o:p></o:p> <o:p> </o:p> Thanks!<o:p></o:p> -Chrisb<o:p></o:p> <o:p> </o:p> <o:p> </o:p> <div id="mail-editor-reference-message-container"> <div> <div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0cm 0cm 0cm"> From: Richardson, Bruce <<a href="mailto:bruce.richardson@intel.com">bruce.richardson@intel.com</a>> Date: Monday, October 23, 2023 at 5:39 AM To: dpdk stable <<a href="mailto:stable@dpdk.org">stable@dpdk.org</a>> Subject: RE: please help backporting some patches to stable release 20.11.10<o:p></o:p> </div> <div> Ok to skip 12016895fc, it should not be necessary for backport. > -----Original Message----- > From: <a href="mailto:luca.boccassi@gmail.com">luca.boccassi@gmail.com</a> <<a href="mailto:luca.boccassi@gmail.com">luca.boccassi@gmail.com</a>> > Sent: Thursday, October 19, 2023 1:03 AM > To: dpdk stable <<a href="mailto:stable@dpdk.org">stable@dpdk.org</a>> > Cc: Sinha, Abhijit <<a href="mailto:abhijit.sinha@intel.com">abhijit.sinha@intel.com</a>>; Burakov, Anatoly > <<a href="mailto:anatoly.burakov@intel.com">anatoly.burakov@intel.com</a>>; Xing, Beilei <<a href="mailto:beilei.xing@intel.com">beilei.xing@intel.com</a>>; Bernard > Iremonger <<a href="mailto:bernard.iremonger@intel.com">bernard.iremonger@intel.com</a>>; Richardson, Bruce > <<a href="mailto:bruce.richardson@intel.com">bruce.richardson@intel.com</a>>; Chandubabu Namburu <<a href="mailto:chandu@amd.com">chandu@amd.com</a>>; Power, > Ciara <<a href="mailto:ciara.power@intel.com">ciara.power@intel.com</a>>; Doherty, Declan <<a href="mailto:declan.doherty@intel.com">declan.doherty@intel.com</a>>; > Deepak Kumar Jain <<a href="mailto:deepak.k.jain@intel.com">deepak.k.jain@intel.com</a>>; Dmitry Kozlyuk > <<a href="mailto:dkozlyuk@nvidia.com">dkozlyuk@nvidia.com</a>>; Ferruh Yigit <<a href="mailto:ferruh.yigit@amd.com">ferruh.yigit@amd.com</a>>; Ferruh Yigit > <<a href="mailto:ferruh.yigit@intel.com">ferruh.yigit@intel.com</a>>; Trahe, Fiona <<a href="mailto:fiona.trahe@intel.com">fiona.trahe@intel.com</a>>; Vargas, > Hernan <<a href="mailto:hernan.vargas@intel.com">hernan.vargas@intel.com</a>>; Jie Hai <<a href="mailto:haijie1@huawei.com">haijie1@huawei.com</a>>; Wu, > Jingjing <<a href="mailto:jingjing.wu@intel.com">jingjing.wu@intel.com</a>>; Griffin, John <<a href="mailto:john.griffin@intel.com">john.griffin@intel.com</a>>; > Konstantin Ananyev <<a href="mailto:konstantin.ananyev@intel.com">konstantin.ananyev@intel.com</a>>; Leyi Rong > <<a href="mailto:leyi.rong@intel.com">leyi.rong@intel.com</a>>; Long Li <<a href="mailto:longli@microsoft.com">longli@microsoft.com</a>>; Matan Azrad > <<a href="mailto:matan@nvidia.com">matan@nvidia.com</a>>; Maxime Coquelin <<a href="mailto:maxime.coquelin@redhat.com">maxime.coquelin@redhat.com</a>>; Chautru, > Nicolas <<a href="mailto:nicolas.chautru@intel.com">nicolas.chautru@intel.com</a>>; Zhang, Qi Z <<a href="mailto:qi.z.zhang@intel.com">qi.z.zhang@intel.com</a>>; > Nicolau, Radu <<a href="mailto:radu.nicolau@intel.com">radu.nicolau@intel.com</a>>; Singhal, Saurabh > <<a href="mailto:saurabhs@arista.com">saurabhs@arista.com</a>>; Selwin Sebastian <<a href="mailto:selwin.sebastian@amd.com">selwin.sebastian@amd.com</a>>; > Somalapuram Amaranath <<a href="mailto:asomalap@amd.com">asomalap@amd.com</a>>; Thomas Monjalon > <<a href="mailto:thomas@monjalon.net">thomas@monjalon.net</a>>; Wei Hu <<a href="mailto:weh@microsoft.com">weh@microsoft.com</a>>; Lu, Wenzhuo > <<a href="mailto:wenzhuo.lu@intel.com">wenzhuo.lu@intel.com</a>> > Subject: please help backporting some patches to stable release 20.11.10 > > Hi commit authors (and maintainers), > > Despite being selected by the DPDK maintenance tool ./devtools/git-log- > fixes.sh > I didn't apply following commits from DPDK main to 20.11 > stable branch, as conflicts or build errors occur. > > Can authors check your patches in the following list and either: > - Backport your patches to the 20.11 branch, or > - Indicate that the patch should not be backported > > Please do either of the above by 2023/10/26. > > You can find the a temporary work-in-progress branch of the coming > 20.11.10 > release at: > <a href="https://github.com/bluca/dpdk-stable">https://github.com/bluca/dpdk-stable</a> > It is recommended to backport on top of that to minimize further conflicts > or > misunderstandings. > > Some notes on stable backports: > > A backport should contain a reference to the DPDK main branch commit > in it's commit message in the following fashion: > [ upstream commit <commit's dpdk main branch SHA-1 checksum> ] > > For example: > <a href="https://git.dpdk.org/dpdk-">https://git.dpdk.org/dpdk-</a> > stable/commit/?h=18.11&id=d90e6ae6f936ecdc2fd3811ff9f26aec7f3c06eb > > When sending the backported patch, please indicate the target branch in > the > subject line, as we have multiple branches, for example: > [PATCH 20.11] foo/bar: fix baz > > With git format-patch, this can be achieved by appending the parameter: > --subject-prefix='PATCH 20.11' > > Send the backported patch to "<a href="mailto:stable@dpdk.org">stable@dpdk.org</a>" but not "<a href="mailto:dev@dpdk.org">dev@dpdk.org</a>". > > FYI, branch 20.11 is located at tree: > <a href="https://git.dpdk.org/dpdk-stable">https://git.dpdk.org/dpdk-stable</a> > > Thanks. > > Luca Boccassi > > --- > 12016895fc Bruce Richardson net/iavf: fix buffer leak on Tx queue stop > d7d52b37e8 Ciara Power crypto/qat: fix raw API null algorithm digest > 7d04891664 Hernan Vargas baseband/acc: fix ACC100 HARQ input alignment > 37b68fa144 Jie Hai app/testpmd: fix primary process not polling > all queues > e35a5737a7 Saurabh Singhal net/iavf: unregister interrupt handler before > FD close > a27ff9cac1 Selwin Sebastian net/axgbe: identify CPU with cpuid > 26c6bdf3d1 Wei Hu net/mana: add 32-bit short doorbell > 74decf3bf0 Wei Hu net/mana: enable 32-bit build<o:p></o:p> </div> </div> </div> </div> </div> </body> </html>