<html xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"> <head> <meta http-equiv="Content-Type" content="text/html; charset=utf-8"> <meta name="Generator" content="Microsoft Word 15 (filtered medium)"> <style></style> </head> <body lang="EN-US" link="blue" vlink="purple" style="word-wrap:break-word"> <div class="WordSection1"> Hey Bruce,<o:p></o:p> <o:p> </o:p> I was wondering why you thought it was ok to skip backporting 12016895fc to earlier releases?<o:p></o:p> <o:p> </o:p> It looks like I ran into this issue on v21.11and v22.11. I patched this back locally and saw that we no longer were leaking mbufs in TX queue stop with IAVF. It did not patch cleanly because <a href="https://polaris-git.cisco.com/iosxe-dpt/cisco_dpdk/commit/4f8259df563a2f754cd99fa6191c9482ce2b2201"> https://polaris-git.cisco.com/iosxe-dpt/cisco_dpdk/commit/4f8259df563a2f754cd99fa6191c9482ce2b2201</a> was not backported either.<o:p></o:p> <o:p> </o:p> It does seems like this issue exists in earlier releases though, so wondering the reasoning for not backporting.<o:p></o:p> <o:p> </o:p> Thanks!<o:p></o:p> -Chrisb<o:p></o:p> <o:p> </o:p> <o:p> </o:p> <div id="mail-editor-reference-message-container"> <div> <div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in"> From: Richardson, Bruce <bruce.richardson@intel.com> Date: Monday, October 23, 2023 at 5:39 AM To: dpdk stable <stable@dpdk.org> Subject: RE: please help backporting some patches to stable release 20.11.10<o:p></o:p> </div> <div> Ok to skip 12016895fc, it should not be necessary for backport. > -----Original Message----- > From: luca.boccassi@gmail.com <luca.boccassi@gmail.com> > Sent: Thursday, October 19, 2023 1:03 AM > To: dpdk stable <stable@dpdk.org> > Cc: Sinha, Abhijit <abhijit.sinha@intel.com>; Burakov, Anatoly > <anatoly.burakov@intel.com>; Xing, Beilei <beilei.xing@intel.com>; Bernard > Iremonger <bernard.iremonger@intel.com>; Richardson, Bruce > <bruce.richardson@intel.com>; Chandubabu Namburu <chandu@amd.com>; Power, > Ciara <ciara.power@intel.com>; Doherty, Declan <declan.doherty@intel.com>; > Deepak Kumar Jain <deepak.k.jain@intel.com>; Dmitry Kozlyuk > <dkozlyuk@nvidia.com>; Ferruh Yigit <ferruh.yigit@amd.com>; Ferruh Yigit > <ferruh.yigit@intel.com>; Trahe, Fiona <fiona.trahe@intel.com>; Vargas, > Hernan <hernan.vargas@intel.com>; Jie Hai <haijie1@huawei.com>; Wu, > Jingjing <jingjing.wu@intel.com>; Griffin, John <john.griffin@intel.com>; > Konstantin Ananyev <konstantin.ananyev@intel.com>; Leyi Rong > <leyi.rong@intel.com>; Long Li <longli@microsoft.com>; Matan Azrad > <matan@nvidia.com>; Maxime Coquelin <maxime.coquelin@redhat.com>; Chautru, > Nicolas <nicolas.chautru@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>; > Nicolau, Radu <radu.nicolau@intel.com>; Singhal, Saurabh > <saurabhs@arista.com>; Selwin Sebastian <selwin.sebastian@amd.com>; > Somalapuram Amaranath <asomalap@amd.com>; Thomas Monjalon > <thomas@monjalon.net>; Wei Hu <weh@microsoft.com>; Lu, Wenzhuo > <wenzhuo.lu@intel.com> > Subject: please help backporting some patches to stable release 20.11.10 > > Hi commit authors (and maintainers), > > Despite being selected by the DPDK maintenance tool ./devtools/git-log- > fixes.sh > I didn't apply following commits from DPDK main to 20.11 > stable branch, as conflicts or build errors occur. > > Can authors check your patches in the following list and either: > - Backport your patches to the 20.11 branch, or > - Indicate that the patch should not be backported > > Please do either of the above by 2023/10/26. > > You can find the a temporary work-in-progress branch of the coming > 20.11.10 > release at: > <a href="https://github.com/bluca/dpdk-stable">https://github.com/bluca/dpdk-stable</a> > It is recommended to backport on top of that to minimize further conflicts > or > misunderstandings. > > Some notes on stable backports: > > A backport should contain a reference to the DPDK main branch commit > in it's commit message in the following fashion: > [ upstream commit <commit's dpdk main branch SHA-1 checksum> ] > > For example: > <a href="https://git.dpdk.org/dpdk-">https://git.dpdk.org/dpdk-</a> > stable/commit/?h=18.11&id=d90e6ae6f936ecdc2fd3811ff9f26aec7f3c06eb > > When sending the backported patch, please indicate the target branch in > the > subject line, as we have multiple branches, for example: > [PATCH 20.11] foo/bar: fix baz > > With git format-patch, this can be achieved by appending the parameter: > --subject-prefix='PATCH 20.11' > > Send the backported patch to "stable@dpdk.org" but not "dev@dpdk.org". > > FYI, branch 20.11 is located at tree: > <a href="https://git.dpdk.org/dpdk-stable">https://git.dpdk.org/dpdk-stable</a> > > Thanks. > > Luca Boccassi > > --- > 12016895fc Bruce Richardson net/iavf: fix buffer leak on Tx queue stop > d7d52b37e8 Ciara Power crypto/qat: fix raw API null algorithm digest > 7d04891664 Hernan Vargas baseband/acc: fix ACC100 HARQ input alignment > 37b68fa144 Jie Hai app/testpmd: fix primary process not polling > all queues > e35a5737a7 Saurabh Singhal net/iavf: unregister interrupt handler before > FD close > a27ff9cac1 Selwin Sebastian net/axgbe: identify CPU with cpuid > 26c6bdf3d1 Wei Hu net/mana: add 32-bit short doorbell > 74decf3bf0 Wei Hu net/mana: enable 32-bit build<o:p></o:p> </div> </div> </div> </div> </body> </html>