<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=gb2312"> </head> <body> Ok, thanks for letting me know. <div><br> </div> <div id="ms-outlook-mobile-signature" dir="auto">삿혤<a href="https://aka.ms/AAb9ysg">Outlook for Android</a></div> <hr style="display:inline-block;width:98%" tabindex="-1"> <div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Chaoyong He <chaoyong.he@corigine.com><br> <b>Sent:</b> Tuesday, May 7, 2024 9:56:31 AM<br> <b>To:</b> Xueming Li <xuemingl@nvidia.com>; stable@dpdk.org <stable@dpdk.org><br> <b>Cc:</b> oss-drivers <oss-drivers@corigine.com>; Long Wu <Long.Wu@nephogine.com>; Nole Zhang <peng.zhang@corigine.com><br> <b>Subject:</b> RE: [PATCH 23.11] net/nfp: fix port ID meta data use in Rx</font> <div> </div> </div> <style>  </style> <div lang="EN-US" link="blue" vlink="purple" style="word-wrap:break-word"> <div class="x_WordSection1"> <p class="x_MsoNormal"><span style="font-size:11.0pt">Hi Xueming,</span></p> <p class="x_MsoNormal"><span style="font-size:11.0pt"> </span></p> <p class="x_MsoNormal"><span style="font-size:11.0pt">After checking the logic carefully, we found this patch need not backport, because this bug is imported by another patch series which is not exist in DPDK 23.11 release version.</span></p> <p class="x_MsoNormal"><span style="font-size:11.0pt"> </span></p> <p class="x_MsoNormal"><span style="font-size:11.0pt">Really sorry about this.</span></p> <p class="x_MsoNormal"><span style="font-size:11.0pt"> </span></p> <div style="border:none; border-left:solid blue 1.5pt; padding:0in 0in 0in 4.0pt"> <div> <div style="border:none; border-top:solid #E1E1E1 1.0pt; padding:3.0pt 0in 0in 0in"> <p class="x_MsoNormal"><b><span style="font-size:11.0pt; font-family:"Calibri",sans-serif">From:</span></b><span style="font-size:11.0pt; font-family:"Calibri",sans-serif"> Xueming Li <xuemingl@nvidia.com> <br> <b>Sent:</b> Wednesday, May 1, 2024 9:51 AM<br> <b>To:</b> Chaoyong He <chaoyong.he@corigine.com>; stable@dpdk.org<br> <b>Cc:</b> oss-drivers <oss-drivers@corigine.com>; Long Wu <Long.Wu@nephogine.com>; Nole Zhang <peng.zhang@corigine.com><br> <b>Subject:</b> Re: [PATCH 23.11] net/nfp: fix port ID meta data use in Rx</span></p> </div> </div> <p class="x_MsoNormal"> </p> <table class="x_MsoNormalTable" border="0" cellspacing="0" cellpadding="0" align="left" width="100%" style="width:100.0%"> <tbody> <tr> <td style="background:#A6A6A6; padding:5.25pt 1.5pt 5.25pt 1.5pt"></td> <td width="100%" style="width:100.0%; background:#EAEAEA; padding:5.25pt 3.75pt 5.25pt 11.25pt"> <div> <p class="x_MsoNormal" style=""><span style="font-size:9.0pt; font-family:"Segoe UI",sans-serif; color:#212121">Some people who received this message don't often get email from <a href="mailto:xuemingl@nvidia.com">xuemingl@nvidia.com</a>. <a href="https://aka.ms/LearnAboutSenderIdentification"> Learn why this is important</a></span></p> </div> </td> <td width="75" style="width:56.25pt; background:#EAEAEA; padding:5.25pt 3.75pt 5.25pt 3.75pt"> </td> </tr> </tbody> </table> <div> <div> <p class="x_MsoNormal" style="margin-bottom:12.0pt"><span style="color:black">I got following compilation error:</span></p> </div> <div> <p class="x_MsoNormal" style="margin-bottom:12.0pt"><span style="color:black"> ../../auto/swgwork/xuemingl/workspace/dpdk/drivers/net/nfp/nfp_rxtx.c:763:14: error: no member named 'flags' in 'struct nfp_meta_parsed'</span></p> </div> <div> <p class="x_MsoNormal"><span style="color:black">Could you please address ASAP? make sure it tested.</span></p> </div> <div> <p class="x_MsoNormal"><span style="color:black"> </span></p> </div> <div> <p class="x_MsoNormal"><span style="color:black">Thanks,</span></p> </div> <div class="x_MsoNormal" align="center" style="text-align:center"> <hr size="2" width="98%" align="center"> </div> <div id="x_divRplyFwdMsg"> <p class="x_MsoNormal"><b><span style="font-size:11.0pt; font-family:"Calibri",sans-serif; color:black">From:</span></b><span style="font-size:11.0pt; font-family:"Calibri",sans-serif; color:black"> Xueming Li <<a href="mailto:xuemingl@nvidia.com">xuemingl@nvidia.com</a>><br> <b>Sent:</b> Wednesday, May 1, 2024 9:19 AM<br> <b>To:</b> Chaoyong He <<a href="mailto:chaoyong.he@corigine.com">chaoyong.he@corigine.com</a>>; <a href="mailto:stable@dpdk.org">stable@dpdk.org</a> <<a href="mailto:stable@dpdk.org">stable@dpdk.org</a>><br> <b>Cc:</b> <a href="mailto:oss-drivers@corigine.com">oss-drivers@corigine.com</a> <<a href="mailto:oss-drivers@corigine.com">oss-drivers@corigine.com</a>>; Long Wu <<a href="mailto:long.wu@corigine.com">long.wu@corigine.com</a>>; Peng Zhang <<a href="mailto:peng.zhang@corigine.com">peng.zhang@corigine.com</a>><br> <b>Subject:</b> Re: [PATCH 23.11] net/nfp: fix port ID meta data use in Rx</span> </p> <div> <p class="x_MsoNormal"> </p> </div> </div> <div> <div> <p class="x_MsoNormal"><span style="color:black">Hi Chaoyong,</span></p> </div> <div> <p class="x_MsoNormal"><span style="color:black"> </span></p> </div> <div> <p class="x_MsoNormal"><span style="color:black">Thanks for your help, patch added into release queue.</span></p> </div> <div class="x_MsoNormal" align="center" style="text-align:center"> <hr size="2" width="98%" align="center"> </div> <div id="x_x_divRplyFwdMsg"> <p class="x_MsoNormal"><b><span style="font-size:11.0pt; font-family:"Calibri",sans-serif; color:black">From:</span></b><span style="font-size:11.0pt; font-family:"Calibri",sans-serif; color:black"> Chaoyong He <<a href="mailto:chaoyong.he@corigine.com">chaoyong.he@corigine.com</a>><br> <b>Sent:</b> Monday, April 15, 2024 10:40 AM<br> <b>To:</b> <a href="mailto:stable@dpdk.org">stable@dpdk.org</a> <<a href="mailto:stable@dpdk.org">stable@dpdk.org</a>><br> <b>Cc:</b> <a href="mailto:oss-drivers@corigine.com">oss-drivers@corigine.com</a> <<a href="mailto:oss-drivers@corigine.com">oss-drivers@corigine.com</a>>; Long Wu <<a href="mailto:long.wu@corigine.com">long.wu@corigine.com</a>>; Chaoyong He <<a href="mailto:chaoyong.he@corigine.com">chaoyong.he@corigine.com</a>>; Peng Zhang <<a href="mailto:peng.zhang@corigine.com">peng.zhang@corigine.com</a>><br> <b>Subject:</b> [PATCH 23.11] net/nfp: fix port ID meta data use in Rx</span> </p> <div> <p class="x_MsoNormal"> </p> </div> </div> <div> <div> <p class="x_MsoNormal" style="margin-bottom:12.0pt"><span style="font-size:11.0pt">From: Long Wu <<a href="mailto:long.wu@corigine.com">long.wu@corigine.com</a>><br> <br> [ upstream commit ddc84b53f38281ff2c15f7feb7e3a0b556dd92b2 ]<br> <br> Meta data parsing should be controlled by meta data flag. So use<br> flag to determine if receive function can use 'port_id' meta data.<br> <br> Fixes: 580ea0b09a7c ("net/nfp: fix Rx descriptor")<br> <br> Signed-off-by: Long Wu <<a href="mailto:long.wu@corigine.com">long.wu@corigine.com</a>><br> Reviewed-by: Chaoyong He <<a href="mailto:chaoyong.he@corigine.com">chaoyong.he@corigine.com</a>><br> Reviewed-by: Peng Zhang <<a href="mailto:peng.zhang@corigine.com">peng.zhang@corigine.com</a>><br> ---<br> drivers/net/nfp/nfp_rxtx.c | 2 +-<br> 1 file changed, 1 insertion(+), 1 deletion(-)<br> <br> diff --git a/drivers/net/nfp/nfp_rxtx.c b/drivers/net/nfp/nfp_rxtx.c<br> index 8ca651ba55..5033d659d3 100644<br> --- a/drivers/net/nfp/nfp_rxtx.c<br> +++ b/drivers/net/nfp/nfp_rxtx.c<br> @@ -760,7 +760,7 @@ nfp_net_recv_pkts(void *rx_queue,<br> if (unlikely(rxq->rd_p == rxq->rx_count)) /* Wrapping */<br> rxq->rd_p = 0;<br> <br> - if (meta.port_id == 0) {<br> + if (((meta.flags >> NFP_NET_META_PORTID) & 0x1) == 0) {<br> rx_pkts[avail++] = mb;<br> } else if (nfp_flower_pf_dispatch_pkts(hw, mb, meta.port_id)) {<br> avail_multiplexed++;<br> -- <br> 2.27.0</span></p> </div> </div> </div> </div> </div> </div> </div> </body> </html>