<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Hi David,</div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Thanks for pointing this out, fixed and pushed to 23.11-staging.</div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Regards,</div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Xueming</div>
<div id="appendonsend" style="color: inherit;"></div>
<div style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<hr style="display: inline-block; width: 98%;">
<div id="divRplyFwdMsg" dir="ltr" style="color: inherit;"><span style="font-family: Calibri, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);"><b>From:</b> David Marchand <david.marchand@redhat.com><br>
<b>Sent:</b> Friday, July 12, 2024 7:05 PM<br>
<b>To:</b> Xueming Li <xuemingl@nvidia.com><br>
<b>Cc:</b> Bruce Richardson <bruce.richardson@intel.com>; dpdk stable <stable@dpdk.org><br>
<b>Subject:</b> Re: patch 'eal/unix: support ZSTD compression for firmware' has been queued to stable release 23.11.2</span>
<div> </div>
</div>
<div style="font-size: 11pt;">Hello Xueming,<br>
<br>
On Fri, Jul 12, 2024 at 12:46 PM Xueming Li <xuemingl@nvidia.com> wrote:<br>
> diff --git a/lib/eal/unix/eal_firmware.c b/lib/eal/unix/eal_firmware.c<br>
> index 1a7cf8e7b7..33e989188e 100644<br>
> --- a/lib/eal/unix/eal_firmware.c<br>
> +++ b/lib/eal/unix/eal_firmware.c<br>
> @@ -15,6 +15,8 @@<br>
><br>
> #include "eal_firmware.h"<br>
><br>
> +static const char * const compression_suffixes[] = { "xz", "zst" };<br>
> +<br>
> #ifdef RTE_HAS_LIBARCHIVE<br>
><br>
> struct firmware_read_ctx {<br>
> @@ -36,7 +38,11 @@ firmware_open(struct firmware_read_ctx *ctx, const char *name, size_t blocksize)<br>
><br>
> err = archive_read_support_filter_xz(ctx->a);<br>
> if (err != ARCHIVE_OK && err != ARCHIVE_WARN)<br>
> - goto error;<br>
> + RTE_LOG(DEBUG, EAL, "could not initialise libarchive for xz compression");<br>
> +<br>
> + err = archive_read_support_filter_zstd(ctx->a);<br>
> + if (err != ARCHIVE_OK && err != ARCHIVE_WARN)<br>
> + RTE_LOG(DEBUG, EAL, "could not initialise libarchive for zstd compression");<br>
<br>
EAL_LOG (in the main branch) appends a \n.<br>
However RTE_LOG() won't do it for you.<br>
So a \n is missing in both calls above.<br>
<br>
<br>
--<br>
David Marchand<br>
<br>
</div>
</body>
</html>