<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Hi Ian,</div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Thanks for your help, patch enqueued to LTS release candidates.</div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Best Regards,</div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Xueming</div>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Ian Stokes <ian.stokes@intel.com><br>
<b>Sent:</b> Thursday, August 15, 2024 9:11 PM<br>
<b>To:</b> stable@dpdk.org <stable@dpdk.org><br>
<b>Cc:</b> Tomasz Wakula <tomaszx.wakula@intel.com>; Ian Stokes <ian.stokes@intel.com>; Bruce Richardson <bruce.richardson@intel.com><br>
<b>Subject:</b> [PATCH 23.11] net/ice/base: fix preparing PHY for timesync command</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">From: Tomasz Wakula <tomaszx.wakula@intel.com><br>
<br>
When preparing a port for timesync command SW should provide Rx type,<br>
which indicates the type for the Rx metadata in the ONPI interface.<br>
According to the documentation, Rx type should always equal 0x18.<br>
<br>
Fixes: 97f4f78bbd9f ("net/ice/base: add functions for device clock control")<br>
Cc: stable@dpdk.org<br>
<br>
Signed-off-by: Tomasz Wakula <tomaszx.wakula@intel.com><br>
Signed-off-by: Ian Stokes <ian.stokes@intel.com><br>
Acked-by: Bruce Richardson <bruce.richardson@intel.com><br>
---<br>
drivers/net/ice/base/ice_ptp_hw.c | 4 ++--<br>
drivers/net/ice/base/ice_ptp_hw.h | 2 ++<br>
2 files changed, 4 insertions(+), 2 deletions(-)<br>
<br>
diff --git a/drivers/net/ice/base/ice_ptp_hw.c b/drivers/net/ice/base/ice_ptp_hw.c<br>
index 548ef5e820..c507f211df 100644<br>
--- a/drivers/net/ice/base/ice_ptp_hw.c<br>
+++ b/drivers/net/ice/base/ice_ptp_hw.c<br>
@@ -2817,8 +2817,8 @@ ice_ptp_one_port_cmd_e822(struct ice_hw *hw, u8 port, enum ice_ptp_tmr_cmd cmd,<br>
val &= ~TS_CMD_MASK;<br>
val |= cmd_val;<br>
<br>
- status = ice_write_phy_reg_e822_lp(hw, port, P_REG_TX_TMR_CMD, val,<br>
- lock_sbq);<br>
+ status = ice_write_phy_reg_e822_lp(hw, port, P_REG_TX_TMR_CMD,<br>
+ val | TS_CMD_RX_TYPE, lock_sbq);<br>
if (status) {<br>
ice_debug(hw, ICE_DBG_PTP, "Failed to write back TX_TMR_CMD, status %d\n",<br>
status);<br>
diff --git a/drivers/net/ice/base/ice_ptp_hw.h b/drivers/net/ice/base/ice_ptp_hw.h<br>
index 3667c9882d..f53b9e3ecc 100644<br>
--- a/drivers/net/ice/base/ice_ptp_hw.h<br>
+++ b/drivers/net/ice/base/ice_ptp_hw.h<br>
@@ -295,6 +295,8 @@ enum ice_status ice_ptp_init_phy_cfg(struct ice_hw *hw);<br>
#define TS_CMD_MASK_E810 0xFF<br>
#define TS_CMD_MASK 0xF<br>
#define SYNC_EXEC_CMD 0x3<br>
+#define TS_CMD_RX_TYPE_S 0x4<br>
+#define TS_CMD_RX_TYPE MAKEMASK(0x18, TS_CMD_RX_TYPE_S)<br>
<br>
/* Macros to derive port low and high addresses on both quads */<br>
#define P_Q0_L(a, p) ((((a) + (0x2000 * (p)))) & 0xFFFF)<br>
-- <br>
2.34.1<br>
<br>
</div>
</span></font></div>
</body>
</html>