<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Thanks, I'll update.</div>
<div id="appendonsend"></div>
<div style="font-family:Aptos,Aptos_EmbeddedFont,Aptos_MSFontService,Calibri,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
<br>
</div>
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>From:</b> David Marchand <david.marchand@redhat.com><br>
<b>Sent:</b> Monday, December 9, 2024 3:00 PM<br>
<b>To:</b> Xueming Li <xuemingl@nvidia.com><br>
<b>Cc:</b> Luca Boccassi <bluca@debian.org>; Stephen Hemminger <stephen@networkplumber.org>; Chengwen Feng <fengchengwen@huawei.com>; dpdk stable <stable@dpdk.org><br>
<b>Subject:</b> Re: patch 'eal/unix: optimize thread creation' has been queued to stable release 23.11.3</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt">
<div class="PlainText">Hello Xueming,<br>
<br>
On Sat, Dec 7, 2024 at 9:02 AM Xueming Li <xuemingl@nvidia.com> wrote:<br>
> @@ -176,6 +192,14 @@ rte_thread_create(rte_thread_t *thread_id,<br>
>                 }<br>
>         }<br>
><br>
> +#ifdef RTE_EAL_PTHREAD_ATTR_SETAFFINITY_NP<br>
> +       ret = pthread_create((pthread_t *)&thread_id->opaque_id, attrp,<br>
> +               (void *)(void *)thread_func, args);<br>
> +       if (ret != 0) {<br>
> +               RTE_LOG(DEBUG, EAL, "pthread_create failed");<br>
<br>
A \n is missing here.<br>
<br>
> +               goto cleanup;<br>
> +       }<br>
> +#else /* !RTE_EAL_PTHREAD_ATTR_SETAFFINITY_NP */<br>
>         ret = pthread_create((pthread_t *)&thread_id->opaque_id, attrp,<br>
>                 thread_start_wrapper, &ctx);<br>
>         if (ret != 0) {<br>
<br>
<br>
-- <br>
David Marchand<br>
<br>
</div>
</span></font></div>
</body>
</html>